Roel Janssen skribis: > Ludovic Courtès writes: > >> Hi Roel! >> >> Roel Janssen skribis: >> >>>>From aaef88b2ab14fd0c631ae7fec296fd899ebf42dd Mon Sep 17 00:00:00 2001 >>> From: Roel Janssen >>> Date: Sun, 26 Feb 2017 11:57:34 +0100 >>> Subject: [PATCH] gnu: Add LLVM and CLANG 3.9.1. >>> >>> * gnu/packages/llvm.scm (llvm-3.9.1): New variable. >>> * gnu/packages/llvm.scm (clang-3.9.1): New variable. >>> * gnu/packages/llvm.scm (clang-runtime-3.9.1): New variable. >> >> I agree with Catonano here, no need to repeat the file name. :-) >> >>> +(define-public llvm-3.9.1 >>> + (package (inherit llvm) >>> + (name "llvm") >>> + (version "3.9.1") >>> + (source >>> + (origin >>> + (method url-fetch) >>> + (uri (string-append "http://llvm.org/releases/" >>> + version "/llvm-" version ".src.tar.xz")) >>> + (sha256 >>> + (base32 >>> + "1vi9sf7rx1q04wj479rsvxayb6z740iaz3qniwp266fgp5a07n8z")))))) >>> + >>> +(define-public clang-runtime-3.9.1 >>> + (clang-runtime-from-llvm >>> + llvm-3.9.1 >>> + "16gc2gdmp5c800qvydrdhsp0bzb97s8wrakl6i8a4lgslnqnf2fk")) >>> + >>> +(define-public clang-3.9.1 >>> + (clang-from-llvm llvm-3.9.1 clang-runtime-3.9.1 >>> + "0qsyyb40iwifhhlx9a3drf8z6ni6zwyk3bvh0kx2gs6yjsxwxi76" >>> + #:patches '())) >> >> Could you add a comment explaining why we need to keep this version >> specifically? >> >> Other than that LGTM. > > Well, actually, this is just the latest release, so maybe I should > update the 3.8.1 recipe to3.9.1 instead. WDYT? If the other users of LLVM and Clang (as per ‘guix refresh -l llvm’) can cope with it, upgrading sounds better indeed. Could you check if that is the case? Thanks, Ludo’.