From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 29 16:12:16 2017 Received: (at 25787) by debbugs.gnu.org; 29 Oct 2017 20:12:16 +0000 Received: from localhost ([127.0.0.1]:40939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8twO-0005Ly-93 for submit@debbugs.gnu.org; Sun, 29 Oct 2017 16:12:16 -0400 Received: from mout.gmx.net ([212.227.15.15]:49375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e8twL-0005Ll-Vc for 25787@debbugs.gnu.org; Sun, 29 Oct 2017 16:12:14 -0400 Received: from labiere ([80.229.147.137]) by mail.gmx.com (mrgmx002 [212.227.17.184]) with ESMTPSA (Nemesis) id 0MYwyp-1ddqQk24d1-00VizW; Sun, 29 Oct 2017 21:12:01 +0100 References: <20170218133830.24091-1-pierre.langlois@gmx.com> <20170218180249.1522-1-pierre.langlois@gmx.com> <87h93mfbkm.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <871su5d0is.fsf@gnu.org> <87vaphppr7.fsf@gnu.org> <8760b3coak.fsf@elephly.net> User-agent: mu4e 0.9.19; emacs 25.3.1 From: Pierre Langlois To: Ricardo Wurmus Subject: Re: bug#25787: [PATCH 6/6] gnu: Add Clementine. In-reply-to: <8760b3coak.fsf@elephly.net> Date: Sun, 29 Oct 2017 20:11:59 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:Jwt3Jx0t54JKd05RyYd/51aQZBcZk49sGkGz40ZsygVORMVMvz9 MUzH2iE2/QGsstV0TSK3rBqnYbZJfFZgknh0koYeBKUR3xGrWFCovklBK73tAcJiQMum7yU XmRWc81uotsUIbZybTjMSmwcUzMwYKzJlQ+n3/pscr25GTfgmudDGnoByX324EeoJRnTMcD On52Nu9spAejAxxXBmqKQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:2dfdZW/HCUk=:GY59iIOEpyogkE46UI6Kjq FeO41iFw1NjR3eFZq0/YKhQC03hDv0ky1Zstd+evYBuONYMXptCqr6wLMld/HrqIsa99vdmVB E3Zyftt6uRUEOx8vQrx7Fso7vzIv1sSc5dlAi+vdZSuvxwesIi7gPg2hXsVU2Q4wVUSgh0Mrj 0NLQyRW0otvU/tWIEP5T6IMljwoMiHB42oa/RpbGImOZpO/Po/84KLY32ffyuu9/u+rhSrgZk fb1CesEPlv36t7ksMsP5OCby0gb76Y3MF8dfwLk+Aqts4Jn4+V/ATHCOTEtd6TdR4D1vlrDPB 1lY8L2OJGNzP9kQOMAcaj9jNelMmOW7nimeRdP50gJoQyuWC703+3dh6drwLYdif43rTO4N9k 6loFqt+1hxFDDYRP7jc1EBJ+nrBm19b6MHdpS3I+CHlHsO2b213VpJPiCBrqbIUkCkbZtmxeD tuYAtpYGTLmxslEkmo+rdjhHLCoXzhLW92BIR4wPDJP7Slgj05rdA2UjGIhC+UP/hDUJ+9N9R gqH/OypsJai9N4aQ1JkqAxUIjWwFHupBRcoUGH5BeQyKNEhntH9mtXttY8x1RKj8x2LgHye/Q /IdC3EeiHqj0HiiHJiMG0B+DlRvkpML8CL2/S0q0PaaqorDSI2AxhlqqsN8zhF6WaGp1avyf+ q8MDxzyhjJVpQXRUSx0+daaGKbTryVh121rYqFpSA7NfUUz/gr7fIVELFgybSjeso0M2SgqCF xws9NA1ny0KagBYDo5MgkDRIac8jyhEWVKOxvRfrRsRmvZMMOjUYeRSk6OIxw7ipybVi4l9Bc HhjfeJJTL+NJ7lPN9o7wreeTVTzX2rnuQTC5mjP+0su2LPgZDk= X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 25787 Cc: Marius Bakke , Ludovic =?utf-8?Q?Court=C3=A8s?= , Pierre Langlois , 25787@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Hi Ricardo Ricardo Wurmus writes: > Hi Pierre, > > I have taken your patches and implemented the suggested changes. > The > only remaining problem is that Clementine seems to bundle a lot > of > libraries, which is why I’m not comfortable with pushing the > updated > version as is. Thanks a lot for looking at this! I'm sorry I've left this dragging for so long, let me get my act together and complete this :-). About the bundling, I agree this is problematic and I'm afraid I haven't been able to get rid of all of them. The remaining libs still bundled are: - qxt: It appears to have gone unmaintained and Clementine devs have updated it for it to work with qt5. - qtsingleapplication: Needs packaging. I might take a stab at it but I'm not sure I'll have the time. But, the CMakeLists.txt file says the bundled version is patched so I'm unsure just packaging it will be enough. - gmock: We have gmock in our googletest package but the tests segfault with it. The bundled version might be too old. - qsqlite: They have bundled the QT sqlite driver: ~~~(CMakeList.txt) # Build our copy of QSqlLiteDriver. # We do this because we can't guarantee that the driver shipped with Qt exposes the # raw sqlite3_ functions required for FTS support. This way we know that those symbols # exist at compile-time and that our code links to the same sqlite library as the # Qt driver. ~~~ I tried to build a version a qtbase with sqlite-with-fts3 as input instead of sqlite, to see if that could be a replacement. But the symbols where still not found so I'm unsure what to do here. Finally, I haven't had the time to look at those last two: - qocoa - qtiocompressor I was able to unbundle "libmygpo-qt" (new package) and "sha2" (replaced by openssl). > > QJson is not found, but it is used by a bundled library anyway, > so I > think the bundling should be fixed first. So, as it turns out only libmygpo-qt's QT4 version was depending on qjson, so this is no longer necessary for clementine! > > Attached is the updated version of the Clementine patch. Thanks again! I have update the patch to remove the unbundled libs and enabled testing. Pierre