From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 10:29:24 2017 Received: (at 25733) by debbugs.gnu.org; 18 Feb 2017 15:29:24 +0000 Received: from localhost ([127.0.0.1]:45170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf6wu-0007Zf-9x for submit@debbugs.gnu.org; Sat, 18 Feb 2017 10:29:24 -0500 Received: from fragranza.investici.org ([178.175.144.26]:26106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf6ws-0007ZW-4k for 25733@debbugs.gnu.org; Sat, 18 Feb 2017 10:29:23 -0500 Received: from [178.175.144.26] (fragranza [178.175.144.26]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id 40F4F2C01BA; Sat, 18 Feb 2017 15:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1487431760; bh=5Gkz0yTUx32/TPwFJr/eabBE1Q9fKK5TQ35/FIglL4s=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HkGdoil6lVt6SUvGUD57zbGqJmwna++O+vVTBQqXg8MlKaTt5qtjEgi56cpnANPR8 /BKLjsHG3xJ086Dl52YsGTNQ74j2Fu2aA8dnULnXY377SYZiMUWW2YOk/mMd6kds2A FpAM78rByi3/5H76v00s98YRrZQngZ91ZNg5YfSI= Date: Sat, 18 Feb 2017 15:31:17 +0000 From: ng0 To: Ricardo Wurmus Subject: Re: bug#25733: [PATCH 12/18] gnu: Add python-docutils-0.11. Message-ID: <20170218153117.j2h5voptiwbwidby@wasp> Mail-Followup-To: Ricardo Wurmus , 25733@debbugs.gnu.org, ng0 References: <20170214201602.10864-1-contact.ng0@cryptolab.net> <20170214201602.10864-12-contact.ng0@cryptolab.net> <87ino7sn8d.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ino7sn8d.fsf@elephly.net> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25733 Cc: ng0 , 25733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 17-02-18 13:21:54, Ricardo Wurmus wrote: > > contact.ng0@cryptolab.net writes: > > > From: ng0 > > > > * gnu/packages/python.scm (python-docutils-0.11): New variable. > > --- > > […] > > > +;; kallithea-0.3.2 needs this > > I wonder: does Kallithea *really* need these particular versions or does > it just have overly strict version checks? > > > +(define-public python-docutils-0.11 > > + (package > > + (inherit python-docutils) > > + (version "0.11") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (pypi-uri "docutils" version)) > > + (sha256 > > + (base32 > > + "1jbybs5a396nrjy9m13pgvsxdwaj7jw7nsawkhl4fi1nvxm1dx4s")))))) > > Okay. > > > +(define-public python2-docutils-0.11 > > + (package-with-python2 python-docutils-0.11)) > > + > > Much better! But: I’d rather not add the Python 2 variant unless it’s > really needed. If Kallithea really just needs the Python 2 variant, > then please do not add the Python 3 variant. The same comment applies > to all other patches in this series that add variants like this. > > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net > Thanks for your review, I'll send updates soon. I think the weird constructions of some python2 variants originated in the fact that the branch is too old to remember why I did it ;) So here's my idea: I'll send an email upstream and ask about the restrictions and if we could simply use a newer version, current one, etc etc. I have not been following kallithea development since I packaged this, but I know there has been no new release. These patches just reflect what I tested, and I didn't even get to kallithea itself afaik because I still needed dependencies for running tests. Does this sound appropriate for you? -- ng0 -- https://www.inventati.org/patternsinthechaos/