From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 07:00:40 2017 Received: (at 25733) by debbugs.gnu.org; 18 Feb 2017 12:00:40 +0000 Received: from localhost ([127.0.0.1]:44267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf3gu-0007UM-9c for submit@debbugs.gnu.org; Sat, 18 Feb 2017 07:00:40 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf3gs-0007UD-JB for 25733@debbugs.gnu.org; Sat, 18 Feb 2017 07:00:38 -0500 Received: from localhost (xd933e48a.dyn.telefonica.de [217.51.228.138]) by mx.zohomail.com with SMTPS id 148741923543273.21882824843487; Sat, 18 Feb 2017 04:00:35 -0800 (PST) References: <20170214201602.10864-1-contact.ng0@cryptolab.net> <20170214201602.10864-4-contact.ng0@cryptolab.net> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Ricardo Wurmus To: contact.ng0@cryptolab.net Subject: Re: bug#25733: [PATCH 04/18] gnu: Add mercurial@3.7.3. In-reply-to: <20170214201602.10864-4-contact.ng0@cryptolab.net> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sat, 18 Feb 2017 13:00:32 +0100 Message-ID: <87tw7rso7z.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25733 Cc: ng0 , 25733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) contact.ng0@cryptolab.net writes: > From: ng0 > > * gnu/packages/version-control.scm (mercurial@3.7.3): New variable. […] > +(define-public mercurial@3.7.3 The variable name should be “mercurial-3.7.3” (if the exact version number is important). Why does it have to be this particular version? If any of the 3.7 series is sufficient then it should be called “mercurial-3.7”; if any version 3.x is okay, then it should be called “mercurial-3”. Please add a comment above this package definition that explains why this particular variant is required, so that we know whether it is fine to update or remove it in the future. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net