From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 18 06:59:48 2017 Received: (at 25728) by debbugs.gnu.org; 18 Jun 2017 10:59:49 +0000 Received: from localhost ([127.0.0.1]:54008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMXvk-000387-Sn for submit@debbugs.gnu.org; Sun, 18 Jun 2017 06:59:48 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMXvi-00037x-Fp for 25728@debbugs.gnu.org; Sun, 18 Jun 2017 06:59:43 -0400 Received: from localhost (port-92-200-37-134.dynamic.qsc.de [92.200.37.134]) by mx.zohomail.com with SMTPS id 1497783578294278.05760921083265; Sun, 18 Jun 2017 03:59:38 -0700 (PDT) References: <20170214185339.25538-1-contact.ng0@cryptolab.net> <20170214185339.25538-2-contact.ng0@cryptolab.net> <871suvu8yu.fsf@elephly.net> <20170415152843.2vyk7uhycuny5rov@abyayala> <20170415160053.qqqpga27hqsdhet3@abyayala> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Ricardo Wurmus To: ng0 Subject: Re: bug#25728: [PATCH 2/2] gnu: Add colorforth. In-reply-to: <20170415160053.qqqpga27hqsdhet3@abyayala> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sun, 18 Jun 2017 12:59:35 +0200 Message-ID: <87d1a17e94.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 25728 Cc: 25728@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) ng0 writes: > Version two of the patches attached. > -- […] >>From 9c0221c7558b6d87124563fdc4fdde5c32a0374d Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Thu, 6 Oct 2016 22:31:46 +0000 > Subject: [PATCH 2/2] gnu: Add colorforth. > > * gnu/packages/forth.scm (colorforth): New variable. > --- […] > + > +(define-public colorforth > + (let ((commit "94aec438f1ded202681f18801b98c52dc3beee41") > + (revision "1")) > + (package > + (name "colorforth") > + (version (string-append "0.0.0-" revision "." (string-take commit 7))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/narke/colorForth") > + (commit commit))) > + (sha256 > + (base32 > + "0s602k568bm6vmvpahsms77liicg38vksn59j5m8ax4h9l9ca77r")))) > + (arguments > + `(#:tests? #f There should be a comment to explain why tests are disabled. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) ;No configure script > + (replace 'install ;No install target > + (lambda* (#:key outputs #:allow-other-keys) > + (install-file "cf2012.img" > + (string-append (assoc-ref outputs "out") > + "/bin")) > + #t))))) If I understood this correctly, this is not an executable. One is supposed to run this with qemu. This means that it doesn’t belong in “bin”. > + (native-inputs > + `(("nasm" ,nasm))) > + (build-system gnu-build-system) > + (home-page "https://github.com/narke/colorForth") > + (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu") > + (description > + "Colorforth is a @code{colorForth} implementation written in > +x86 assembly. It is a dialect of Forth that uses color to replace > +punctation, includes its own operating system and produces extremely > +compact programs. Applications compile from pre-parsed source. > +Colorforth applications can be run using @code{Bochs} and @code{Qemu}. > +It is adapted from @url{http://sourceforge.net/projects/colorforth, > +colorforth}.") > + (license license:public-domain)))) I could not find a license statement anywhere in the repository. How do you know it’s public domain software? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net