[PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.

  • Done
  • quality assurance status badge
Details
2 participants
  • Sharlatan Hellseher
  • Troy Figiel
Owner
unassigned
Submitted by
Troy Figiel
Severity
normal
T
T
Troy Figiel wrote on 25 Feb 18:16 +0100
(address . guix-patches@gnu.org)
874jdwa2cq.fsf@troyfigiel.com
This patch series fixes some inaccuracies, enables the tests for
go-github-com-cheggaaa-pb-v3 and cleans up its package definition.

Troy Figiel (3):
gnu: go-github-com-vividcortex-ewma: Fix import-path.
gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary inputs.

gnu/packages/golang.scm | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)


base-commit: b25b94335a3ee8d68d2145da8e5ea0325ecea451
--
2.42.0
T
T
Troy Figiel wrote on 25 Feb 18:13 +0100
[PATCH 3/3] gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary inputs.
(address . 69390@debbugs.gnu.org)
87zfvo8mdy.fsf@troyfigiel.com
* gnu/packages/golang.scm (go-github-com-cheggaaa-pb-v3): Remove unnecessary
inputs.
[propagated-inputs]: Remove go-golang-org-x-sys and go-github-com-rivo-uniseg.
---
gnu/packages/golang.scm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 2cff7a0d62..714322932d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8791,9 +8791,7 @@ (define-public go-github-com-cheggaaa-pb-v3
'(#:import-path "github.com/cheggaaa/pb/v3"
#:unpack-path "github.com/cheggaaa/pb"))
(propagated-inputs
- (list go-golang-org-x-sys
- go-github-com-rivo-uniseg
- go-github-com-mattn-go-runewidth
+ (list go-github-com-mattn-go-runewidth
go-github-com-mattn-go-isatty
go-github-com-mattn-go-colorable
go-github-com-fatih-color
--
2.42.0
T
T
Troy Figiel wrote on 25 Feb 18:07 +0100
[PATCH 1/3] gnu: go-github-com-vividcortex-ewma: Fix import-path.
(address . 69390@debbugs.gnu.org)
8734tga101.fsf@troyfigiel.com
* gnu/packages/golang.scm (go-github-com-vividcortex-ewma): Fix import-path.
[arguments]<#:import-path>: Use proper capitalization.
---
gnu/packages/golang.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e8abaffb56..2c0f3b932a 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9625,7 +9625,7 @@ (define-public go-github-com-vividcortex-ewma
(sha256
(base32 "0whx516l9nm4n41spagb605ry7kfnz1qha96mcshnfjlahhnnylq"))))
(build-system go-build-system)
- (arguments '(#:import-path "github.com/vividcortex/ewma"))
+ (arguments '(#:import-path "github.com/VividCortex/ewma"))
(home-page "https://github.com/VividCortex/ewma")
(synopsis "Exponentially Weighted Moving Average algorithms for Go")
(description
--
2.42.0
T
T
Troy Figiel wrote on 25 Feb 18:11 +0100
[PATCH 2/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
(address . 69390@debbugs.gnu.org)
871q90a0yt.fsf@troyfigiel.com
* gnu/packages/golang.scm (go-github-com-cheggaaa-pb-v3): Enable tests.
[arguments]<#:tests?>: Set to true.
<#:unpack-path>: Set unpack-path to the repository root.
---
gnu/packages/golang.scm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 2c0f3b932a..2cff7a0d62 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8789,9 +8789,7 @@ (define-public go-github-com-cheggaaa-pb-v3
(build-system go-build-system)
(arguments
'(#:import-path "github.com/cheggaaa/pb/v3"
- ;; XXX: it does have tests but I'm not sure how to run them.
- ;; go-build-system is looking in the wrong directory.
- #:tests? #f))
+ #:unpack-path "github.com/cheggaaa/pb"))
(propagated-inputs
(list go-golang-org-x-sys
go-github-com-rivo-uniseg
--
2.42.0
S
S
Sharlatan Hellseher wrote on 7 Mar 00:56 +0100
[PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
(address . 69390-done@debbugs.gnu.org)
87a5na6hj6.fsf@gmail.com
Pushed as 2477aea26d..436cd5a625 to master.

--
Oleg
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmXpAr0ACgkQdtcnv/Ys
0rXs9g//bqex4TeL4bV/GGANTpPg646nPhvOb+BrE7Ck+eJD7TV5jv2v/0TMWohM
eA57EITsH4AqhfeKuJbEAumroRzo4nT1WlFQPLtIYTwgmt8L+4uk0mO9GBkrZ3yA
Ze8/DJ3WtmZ7MQwNZocMhgHN8PCnT8qKxaq++UZX4klObDI5L8CYcVPIRXk3tx6c
e9jMHuB+5eR0DZ3zK6S9qnMG0xBQP01s5vqShKqMPDgakbUJdMC/Jb2bubvjCUvs
jnulnLXj0ebtOhDvpjYnSEWeMgrC02p+JUi2XBrrb6/nMKsqxn7DiNt1nOQyojev
if9Z2eRu1xK1KVBhm85RbH4L+phceRKHh6lhkM80q8TpdN9ILQsrENE3r2PNlPmU
PCPr2Il41zY4BnzEkA6SbbqhNrDCCnibRIvgSfO3esBNm1CttQNX5mYgdaMFm2Ll
FIC3ioDK+1EzWJ2FWsRu8mMXxsc3ihx61ElLOnS7T9P6webSZYAwvcIWBWSx5kI6
ldiu3ddN5QJicVJCJCUxNhfrIPyBzIJXMPZ76N5S44mVV1Jhhu+XEcDHhyDHsfqU
+iAURXSIwLhhO2yc0ej9ojZcKQyMgDFccnyHOiJ1c1VtXk4+gEELccCBK8FvrenA
OFvrFYSsLxzwtNmLop0JPaaePmrNHI6rXG9/TJA1Nzhbp0hgfv0=
=QuDG
-----END PGP SIGNATURE-----

Closed
?