[PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.

Done

Details

2 participants

Artyom V. Poptsov
Sharlatan Hellseher

Owner: unassigned

Submitted by: Artyom V. Poptsov

Severity: normal

Artyom V. Poptsov wrote on 20 Jan 19:09 +0100

Recipients:(address . guix-patches@gnu.org)

Message-ID:87msszev23.fsf@gmail.com

Hello,

this patch adds "go-github-com-gabriel-vasile-mimetype"[1]

From 140d517610c3e9be4c5fb74e354f411c51d25cdc Mon Sep 17 00:00:00 2001

Message-ID: <140d517610c3e9be4c5fb74e354f411c51d25cdc.1705774054.git.poptsov.artyom@gmail.com>

* gnu/packages/golang.scm (go-github-com-gabriel-vasile-mimetype): New

variable.

Change-Id: Icb1624eb9a890b6f711dacf5ff80f15b041f3b7d

---

gnu/packages/golang.scm | 36 ++++++++++++++++++++++++++++++++++++

1 file changed, 36 insertions(+)

Toggle diff (51 lines)diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 8fea581248..c2154ca675 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -4410,6 +4410,42 @@ (define-public go-github-com-technoweenie-multipartstreamer
 without reading the entire content into memory.")
     (license license:expat)))
 
+(define-public go-github-com-gabriel-vasile-mimetype
+  (package
+    (name "go-github-com-gabriel-vasile-mimetype")
+    (version "1.4.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/gabriel-vasile/mimetype")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "11swnjczhrza0xi8q2wlk056nnbcghm44vqs52zfv6rwqvy6imhj"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:go go-1.20
+      #:import-path "github.com/gabriel-vasile/mimetype"
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'add-supported-mimes-md
+            (lambda* (#:key inputs #:allow-other-keys #:rest args)
+              ;; This file needs to be available for writing during the
+              ;; tests otherwise they will fail.
+              (let ((file
+                     "src/github.com/gabriel-vasile/mimetype/supported_mimes.md"))
+                (invoke "touch" file)
+                (chmod file #o644)))))))
+    (propagated-inputs (list go-golang-org-x-net))
+    (home-page "https://github.com/gabriel-vasile/mimetype")
+    (synopsis "Golang library for media type and file extension detection")
+    (description
+     "A fast Golang library for media type and file extension detection, based on
+magic numbers .")
+    (license license:expat)))
+
 (define-public go-github-com-tevino-abool
   (let ((commit
           "3c25f2fe7cd0ef3eabefce1d90efd69a65d35b12")

base-commit: 9c367ee1967b213b507a8bf041ea6c2623ceea96
-- 
2.41.0

Thanks,
- avp

References:
1. https://github.com/gabriel-vasile/mimetype/

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Sharlatan Hellseher wrote on 3 Feb 06:42 +0100

Recipients:(address . 68617@debbugs.gnu.org)(address . poptsov.artyom@gmail.com)

Message-ID:CAO+9K5qvoD4FGBK7Or8Vh_OduMvuYqAWnF8o7hkWEG=vLG5UyQ@mail.gmail.com

Hi,

Thank you for the patch!

Toggle quote (3 lines)

> + (add-before 'check 'add-supported-mimes-md

> + (lambda* (#:key inputs #:allow-other-keys #:rest args)

> + ;; This file needs to be available for writing during the

Instead of path string you may use import-path (change inputs in

lambda to use it. Check for examples in golang.scm.

Toggle quote (3 lines)

> + ;; tests otherwise they will fail.

> + (let ((file

> + "src/

github.com/gabriel-vasile/mimetype/supported_mimes.md"))

It would be something like this (invoke "touch" (string-append import-path

"supported_mimes.md"). Or check if the code

depends on HOME envar.

Toggle quote (2 lines)

>+ (description

> + "A fast Golang library for media type and file extension detection,

based on

Toggle quote (1 lines)

> +magic numbers .")

Trailing space in the end of the sentence. Try to add more detail,

I've checked github page there is a link to a little bit detailed doc.

Apply common steps: guix lint, guix style.

Looking forward for v2.

Thanks,

Oleg

Attachment: file

Artyom V. Poptsov wrote on 4 Feb 07:58 +0100

Recipients:(address . guix-patches@gnu.org)

Message-ID:878r404sxu.fsf@gmail.com

Hello,

I took into account the comments from Sharlatan Hellseher and updated

the patch.

From c090118a564bd6c3b2672f5422490b765efcc56e Mon Sep 17 00:00:00 2001

Message-ID: <c090118a564bd6c3b2672f5422490b765efcc56e.1707029680.git.poptsov.artyom@gmail.com>

* gnu/packages/golang.scm (go-github-com-gabriel-vasile-mimetype): New

variable.

Change-Id: Icb1624eb9a890b6f711dacf5ff80f15b041f3b7d

---

gnu/packages/golang.scm | 36 ++++++++++++++++++++++++++++++++++++

1 file changed, 36 insertions(+)

Toggle diff (51 lines)diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 014ca01602..966a8b0eaa 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -4112,6 +4112,42 @@ (define-public go-github-com-technoweenie-multipartstreamer
 without reading the entire content into memory.")
     (license license:expat)))
 
+(define-public go-github-com-gabriel-vasile-mimetype
+  (package
+    (name "go-github-com-gabriel-vasile-mimetype")
+    (version "1.4.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/gabriel-vasile/mimetype")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "11swnjczhrza0xi8q2wlk056nnbcghm44vqs52zfv6rwqvy6imhj"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:go go-1.20
+      #:import-path "github.com/gabriel-vasile/mimetype"
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'add-supported-mimes-md
+            (lambda* (#:key inputs #:allow-other-keys #:rest args)
+              ;; This file needs to be available for writing during the
+              ;; tests otherwise they will fail.
+              (let ((file
+                     "src/github.com/gabriel-vasile/mimetype/supported_mimes.md"))
+                (invoke "touch" file)
+                (chmod file #o644)))))))
+    (propagated-inputs (list go-golang-org-x-net))
+    (home-page "https://github.com/gabriel-vasile/mimetype")
+    (synopsis "Golang library for media type and file extension detection")
+    (description
+     "A fast Golang library for media type and file extension detection, based on
+magic numbers .")
+    (license license:expat)))
+
 (define-public go-github-com-tevino-abool
   (let ((commit
           "3c25f2fe7cd0ef3eabefce1d90efd69a65d35b12")

base-commit: abeffc82379c4f9bd2e6226ea27453b22cb4e0c8
-- 
2.41.0

Thanks,
- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Artyom V. Poptsov wrote on 4 Feb 18:14 +0100

Recipients:(address . guix-patches@gnu.org)

Message-ID:874jeo40e4.fsf@gmail.com

Hello,

I attached the old version of the patch by mistake to the previous

email.

Here's the right version.

From c6cc2c6c04019a10717bc19c80a4d4f18013e793 Mon Sep 17 00:00:00 2001

Message-ID: <c6cc2c6c04019a10717bc19c80a4d4f18013e793.1707066776.git.poptsov.artyom@gmail.com>

* gnu/packages/golang.scm (go-github-com-gabriel-vasile-mimetype): New

variable.

Change-Id: Icb1624eb9a890b6f711dacf5ff80f15b041f3b7d

---

gnu/packages/golang.scm | 51 +++++++++++++++++++++++++++++++++++++++++

1 file changed, 51 insertions(+)

Toggle diff (66 lines)diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 014ca01602..ab92cec4e4 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -4112,6 +4112,57 @@ (define-public go-github-com-technoweenie-multipartstreamer
 without reading the entire content into memory.")
     (license license:expat)))
 
+(define-public go-github-com-gabriel-vasile-mimetype
+  (package
+    (name "go-github-com-gabriel-vasile-mimetype")
+    (version "1.4.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/gabriel-vasile/mimetype")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "11swnjczhrza0xi8q2wlk056nnbcghm44vqs52zfv6rwqvy6imhj"))))
+    (build-system go-build-system)
+    (arguments
+     (list
+      #:go go-1.20
+      #:import-path "github.com/gabriel-vasile/mimetype"
+      #:phases #~(modify-phases %standard-phases
+                   (add-before 'check 'add-supported-mimes-md
+                     (lambda* (#:key import-path #:allow-other-keys)
+                       ;; This file needs to be available for writing during the
+                       ;; tests otherwise they will fail.
+                       (let ((file (format #f "src/~a/supported_mimes.md"
+                                           import-path)))
+                         (invoke "touch" file)
+                         (chmod file #o644)))))))
+    (propagated-inputs (list go-golang-org-x-net))
+    (home-page "https://github.com/gabriel-vasile/mimetype")
+    (synopsis "Golang library for media type and file extension detection")
+    (description
+     "A Golang package that uses magic number signatures to detect the MIME type of a
+file.
+
+Main features:
+@itemize
+@item Fast and precise MIME type and file extension detection.
+@item Supports
+@url{https://github.com/gabriel-vasile/mimetype/blob/master/supported_mimes.md,
+many MIME types}.
+@item Allows to
+@url{https://pkg.go.dev/github.com/gabriel-vasile/mimetype#example-package-Extend,
+extend} with other file formats.
+@item Common file formats are prioritized.
+@item
+@url{https://pkg.go.dev/github.com/gabriel-vasile/mimetype#example-package-TextVsBinary,
+Differentiation between text and binary files}.
+@item Safe for concurrent usage.
+@end itemize")
+    (license license:expat)))
+
 (define-public go-github-com-tevino-abool
   (let ((commit
           "3c25f2fe7cd0ef3eabefce1d90efd69a65d35b12")

base-commit: abeffc82379c4f9bd2e6226ea27453b22cb4e0c8
-- 
2.41.0

Thanks,
- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

Sharlatan Hellseher wrote on 5 Feb 16:51 +0100

[PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.

Recipients:(address . 68617-done@debbugs.gnu.org)

Message-ID:87a5oex630.fsf@gmail.com

Hi,

Modification applied

- package placed in golang-xyz.scm, as golang.scm in a process of split into logical modules,

see https://lists.gnu.org/archive/html/guix-devel/2024-01/msg00113.html

- [description]: Append "This package provides a"

Pushed as 317d9840d371469daa23d13ac7c62477ed347b54 to master.

Thanks,

Oleg

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 68617@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date