[PATCH] gnu: Remove leftover patch files.

  • Done
  • quality assurance status badge
Details
4 participants
  • Julien Lepiller
  • Leo Famulari
  • Ludovic Courtès
  • zimoun
Owner
unassigned
Submitted by
Leo Famulari
Severity
normal
L
L
Leo Famulari wrote on 7 Feb 2022 05:20
(address . guix-patches@gnu.org)
34d7ac478fe7d852862e75e176f0297e139658b2.1644207641.git.leo@famulari.name
These patches aren't used anywhere in Guix and we forgot to remove them.

* gnu/packages/patches/bash-reproducible-linux-pgrp-pipe.patch,
gnu/packages/patches/ghc-monad-par-fix-tests.patch,
gnu/packages/patches/glibc-CVE-2018-11236.patch,
gnu/packages/patches/glibc-CVE-2018-11237.patch,
gnu/packages/patches/glibc-hurd-magic-pid.patch,
gnu/packages/patches/grocsvs-dont-use-admiral.patch,
gnu/packages/patches/hydra-disable-darcs-test.patch,
gnu/packages/patches/inkscape-poppler-0.76.patch,
gnu/packages/patches/libvirt-create-machine-cgroup.patch,
gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch,
gnu/packages/patches/marble-qt-add-qt-headers.patch,
gnu/packages/patches/maven-enforcer-api-fix-old-dependencies.patch,
gnu/packages/patches/mescc-tools-boot.patch,
gnu/packages/patches/nettle-3.5-CVE-2021-3580-pt1.patch,
gnu/packages/patches/nettle-3.5-CVE-2021-3580-pt2.patch,
gnu/packages/patches/nettle-3.5-check-_pkcs1_sec_decrypt-msg-len.patch,
gnu/packages/patches/ocaml-Add-a-.file-directive.patch,
gnu/packages/patches/ocaml-CVE-2015-8869.patch,
gnu/packages/patches/ocaml-bitstring-fix-configure.patch,
gnu/packages/patches/ocaml-enable-ocamldoc-reproducibility.patch,
gnu/packages/patches/openbabel-fix-crash-on-nwchem-output.patch,
gnu/packages/patches/openjdk-14-builtins.patch,
gnu/packages/patches/openssl-c-rehash-in.patch,
gnu/packages/patches/openssl-runpath.patch,
gnu/packages/patches/passwordsafe-meson-remove-extra-argument.patch,
gnu/packages/patches/patchutils-test-perms.patch,
gnu/packages/patches/python-CVE-2018-14647.patch,
gnu/packages/patches/python-CVE-2020-26116.patch,
gnu/packages/patches/python-axolotl-AES-fix.patch,
gnu/packages/patches/python-babel-fix-parse-future-test.patch,
gnu/packages/patches/python-matplotlib-run-under-wayland-gtk3.patch,
gnu/packages/patches/python-pytest-asyncio-python-3.8.patch,
gnu/packages/patches/python2-larch-coverage-4.0a6-compatibility.patch,
gnu/packages/patches/qt4-ldflags.patch,
gnu/packages/patches/rust-coresimd-doctest.patch,
gnu/packages/patches/streamlink-update-test.patch,
gnu/packages/patches/tcc-boot-0.9.27.patch,
gnu/packages/patches/vtk-8-fix-freetypetools-build-failure.patch: Delete files.
* gnu/local.mk (dist_patch_DATA): Remove them.
---
gnu/local.mk | 38 ---
.../bash-reproducible-linux-pgrp-pipe.patch | 34 ---
.../patches/ghc-monad-par-fix-tests.patch | 45 ---
.../patches/glibc-CVE-2018-11236.patch | 149 ----------
.../patches/glibc-CVE-2018-11237.patch | 55 ----
.../patches/glibc-hurd-magic-pid.patch | 190 ------------
.../patches/grocsvs-dont-use-admiral.patch | 69 -----
.../patches/hydra-disable-darcs-test.patch | 25 --
.../patches/inkscape-poppler-0.76.patch | 36 ---
.../libvirt-create-machine-cgroup.patch | 48 ---
...nux-libre-arm64-generic-pinebook-lcd.patch | 40 ---
.../patches/marble-qt-add-qt-headers.patch | 189 ------------
...en-enforcer-api-fix-old-dependencies.patch | 177 -----------
gnu/packages/patches/mescc-tools-boot.patch | 222 --------------
.../nettle-3.5-CVE-2021-3580-pt1.patch | 276 ------------------
.../nettle-3.5-CVE-2021-3580-pt2.patch | 163 -----------
...3.5-check-_pkcs1_sec_decrypt-msg-len.patch | 78 -----
.../patches/ocaml-Add-a-.file-directive.patch | 96 ------
.../patches/ocaml-CVE-2015-8869.patch | 72 -----
.../ocaml-bitstring-fix-configure.patch | 53 ----
...caml-enable-ocamldoc-reproducibility.patch | 149 ----------
...openbabel-fix-crash-on-nwchem-output.patch | 34 ---
.../patches/openjdk-14-builtins.patch | 11 -
.../patches/openssl-c-rehash-in.patch | 17 --
gnu/packages/patches/openssl-runpath.patch | 15 -
...wordsafe-meson-remove-extra-argument.patch | 20 --
.../patches/patchutils-test-perms.patch | 14 -
.../patches/python-CVE-2018-14647.patch | 61 ----
.../patches/python-CVE-2020-26116.patch | 47 ---
.../patches/python-axolotl-AES-fix.patch | 24 --
.../python-babel-fix-parse-future-test.patch | 68 -----
...on-matplotlib-run-under-wayland-gtk3.patch | 31 --
.../python-pytest-asyncio-python-3.8.patch | 238 ---------------
...2-larch-coverage-4.0a6-compatibility.patch | 29 --
gnu/packages/patches/qt4-ldflags.patch | 18 --
.../patches/rust-coresimd-doctest.patch | 21 --
.../patches/streamlink-update-test.patch | 70 -----
gnu/packages/patches/tcc-boot-0.9.27.patch | 26 --
...tk-8-fix-freetypetools-build-failure.patch | 36 ---
39 files changed, 2984 deletions(-)
delete mode 100644 gnu/packages/patches/bash-reproducible-linux-pgrp-pipe.patch
delete mode 100644 gnu/packages/patches/ghc-monad-par-fix-tests.patch
delete mode 100644 gnu/packages/patches/glibc-CVE-2018-11236.patch
delete mode 100644 gnu/packages/patches/glibc-CVE-2018-11237.patch
delete mode 100644 gnu/packages/patches/glibc-hurd-magic-pid.patch
delete mode 100644 gnu/packages/patches/grocsvs-dont-use-admiral.patch
delete mode 100644 gnu/packages/patches/hydra-disable-darcs-test.patch
delete mode 100644 gnu/packages/patches/inkscape-poppler-0.76.patch
delete mode 100644 gnu/packages/patches/libvirt-create-machine-cgroup.patch
delete mode 100644 gnu/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch
delete mode 100644 gnu/packages/patches/marble-qt-add-qt-headers.patch
delete mode 100644 gnu/packages/patches/maven-enforcer-api-fix-old-dependencies.patch
delete mode 100644 gnu/packages/patches/mescc-tools-boot.patch
delete mode 100644 gnu/packages/patches/nettle-3.5-CVE-2021-3580-pt1.patch
delete mode 100644 gnu/packages/patches/nettle-3.5-CVE-2021-3580-pt2.patch
delete mode 100644 gnu/packages/patches/nettle-3.5-check-_pkcs1_sec_decrypt-msg-len.patch
delete mode 100644 gnu/packages/patches/ocaml-Add-a-.file-directive.patch
delete mode 100644 gnu/packages/patches/ocaml-CVE-2015-8869.patch
delete mode 100644 gnu/packages/patches/ocaml-bitstring-fix-configure.patch
delete mode 100644 gnu/packages/patches/ocaml-enable-ocamldoc-reproducibility.patch
delete mode 100644 gnu/packages/patches/openbabel-fix-crash-on-nwchem-output.patch
delete mode 100644 gnu/packages/patches/openjdk-14-builtins.patch
delete mode 100644 gnu/packages/patches/openssl-c-rehash-in.patch
delete mode 100644 gnu/packages/patches/openssl-runpath.patch
delete mode 100644 gnu/packages/patches/passwordsafe-meson-remove-extra-argument.patch
delete mode 100644 gnu/packages/patches/patchutils-test-perms.patch
delete mode 100644 gnu/packages/patches/python-CVE-2018-14647.patch
delete mode 100644 gnu/packages/patches/python-CVE-2020-26116.patch
delete mode 100644 gnu/packages/patches/python-axolotl-AES-fix.patch
delete mode 100644 gnu/packages/patches/python-babel-fix-parse-future-test.patch
delete mode 100644 gnu/packages/patches/python-matplotlib-run-under-wayland-gtk3.patch
delete mode 100644 gnu/packages/patches/python-pytest-asyncio-python-3.8.patch
delete mode 100644 gnu/packages/patches/python2-larch-coverage-4.0a6-compatibility.patch
delete mode 100644 gnu/packages/patches/qt4-ldflags.patch
delete mode 100644 gnu/packages/patches/rust-coresimd-doctest.patch
delete mode 100644 gnu/packages/patches/streamlink-update-test.patch
delete mode 100644 gnu/packages/patches/tcc-boot-0.9.27.patch
delete mode 100644 gnu/packages/patches/vtk-8-fix-freetypetools-build-failure.patch

Toggle diff (222 lines)
diff --git a/gnu/local.mk b/gnu/local.mk
index 533cb42080..1bd0dce34f 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -883,7 +883,6 @@ dist_patch_DATA = \
%D%/packages/patches/awesome-4.3-fno-common.patch \
%D%/packages/patches/aws-c-auth-install-private-headers.patch \
%D%/packages/patches/azr3.patch \
- %D%/packages/patches/bash-reproducible-linux-pgrp-pipe.patch \
%D%/packages/patches/bash-completion-directories.patch \
%D%/packages/patches/bash-linux-pgrp-pipe.patch \
%D%/packages/patches/bastet-change-source-of-unordered_set.patch \
@@ -1143,7 +1142,6 @@ dist_patch_DATA = \
%D%/packages/patches/ghc-8.0-fall-back-to-madv_dontneed.patch \
%D%/packages/patches/ghc-testsuite-dlopen-pie.patch \
%D%/packages/patches/ghc-language-haskell-extract-ghc-8.10.patch \
- %D%/packages/patches/ghc-monad-par-fix-tests.patch \
%D%/packages/patches/ghostscript-no-header-id.patch \
%D%/packages/patches/ghostscript-no-header-uuid.patch \
%D%/packages/patches/ghostscript-no-header-creationdate.patch \
@@ -1154,8 +1152,6 @@ dist_patch_DATA = \
%D%/packages/patches/glib-networking-gnutls-binding.patch \
%D%/packages/patches/glib-networking-32-bit-time.patch \
%D%/packages/patches/glib-skip-failing-test.patch \
- %D%/packages/patches/glibc-CVE-2018-11236.patch \
- %D%/packages/patches/glibc-CVE-2018-11237.patch \
%D%/packages/patches/glibc-CVE-2019-7309.patch \
%D%/packages/patches/glibc-CVE-2019-9169.patch \
%D%/packages/patches/glibc-CVE-2019-19126.patch \
@@ -1174,7 +1170,6 @@ dist_patch_DATA = \
%D%/packages/patches/glibc-hurd-clock_t_centiseconds.patch \
%D%/packages/patches/glibc-hurd-gettyent.patch \
%D%/packages/patches/glibc-hurd-mach-print.patch \
- %D%/packages/patches/glibc-hurd-magic-pid.patch \
%D%/packages/patches/glibc-hurd-signal-sa-siginfo.patch \
%D%/packages/patches/glibc-ldd-powerpc.patch \
%D%/packages/patches/glibc-ldd-x86_64.patch \
@@ -1219,7 +1214,6 @@ dist_patch_DATA = \
%D%/packages/patches/grantlee-merge-theme-dirs.patch \
%D%/packages/patches/grep-timing-sensitive-test.patch \
%D%/packages/patches/grfcodec-gcc-compat.patch \
- %D%/packages/patches/grocsvs-dont-use-admiral.patch \
%D%/packages/patches/gromacs-tinyxml2.patch \
%D%/packages/patches/groovy-add-exceptionutilsgenerator.patch \
%D%/packages/patches/grub-efi-fat-serial-number.patch \
@@ -1279,7 +1273,6 @@ dist_patch_DATA = \
%D%/packages/patches/hueplusplus-mbedtls.patch \
%D%/packages/patches/hurd-cross.patch \
%D%/packages/patches/hurd-xattr.patch \
- %D%/packages/patches/hydra-disable-darcs-test.patch \
%D%/packages/patches/i7z-gcc-10.patch \
%D%/packages/patches/icecat-makeicecat.patch \
%D%/packages/patches/icecat-avoid-bundled-libraries.patch \
@@ -1297,7 +1290,6 @@ dist_patch_DATA = \
%D%/packages/patches/imagemagick-ReadDCMImage-fix.patch \
%D%/packages/patches/imagemagick-ReadDCMPixels-fix.patch \
%D%/packages/patches/imagemagick-WriteTHUMBNAILImage-fix.patch \
- %D%/packages/patches/inkscape-poppler-0.76.patch \
%D%/packages/patches/instead-use-games-path.patch \
%D%/packages/patches/intel-xed-fix-nondeterminism.patch \
%D%/packages/patches/intltool-perl-compatibility.patch \
@@ -1342,7 +1334,6 @@ dist_patch_DATA = \
%D%/packages/patches/libffi-float128-powerpc64le.patch \
%D%/packages/patches/librime-fix-build-with-gcc10.patch \
%D%/packages/patches/libvirt-add-install-prefix.patch \
- %D%/packages/patches/libvirt-create-machine-cgroup.patch \
%D%/packages/patches/libziparchive-add-includes.patch \
%D%/packages/patches/localed-xorg-keyboard.patch \
%D%/packages/patches/kdiagram-Fix-missing-link-libraries.patch \
@@ -1446,7 +1437,6 @@ dist_patch_DATA = \
%D%/packages/patches/linbox-fix-pkgconfig.patch \
%D%/packages/patches/linphone-desktop-without-sdk.patch \
%D%/packages/patches/linux-libre-support-for-Pinebook-Pro.patch \
- %D%/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch \
%D%/packages/patches/linux-pam-no-setfsuid.patch \
%D%/packages/patches/linuxdcpp-openssl-1.1.patch \
%D%/packages/patches/lirc-localstatedir.patch \
@@ -1476,13 +1466,11 @@ dist_patch_DATA = \
%D%/packages/patches/lvm2-static-link.patch \
%D%/packages/patches/mailutils-variable-lookup.patch \
%D%/packages/patches/make-impure-dirs.patch \
- %D%/packages/patches/marble-qt-add-qt-headers.patch \
%D%/packages/patches/mars-install.patch \
%D%/packages/patches/mars-sfml-2.3.patch \
%D%/packages/patches/mathjax-disable-webpack.patch \
%D%/packages/patches/mathjax-no-a11y.patch \
%D%/packages/patches/maxima-defsystem-mkdir.patch \
- %D%/packages/patches/maven-enforcer-api-fix-old-dependencies.patch \
%D%/packages/patches/maven-generate-component-xml.patch \
%D%/packages/patches/maven-generate-javax-inject-named.patch \
%D%/packages/patches/mcrypt-CVE-2012-4409.patch \
@@ -1494,7 +1482,6 @@ dist_patch_DATA = \
%D%/packages/patches/mercurial-hg-extension-path.patch \
%D%/packages/patches/mesa-opencl-all-targets.patch \
%D%/packages/patches/mesa-skip-tests.patch \
- %D%/packages/patches/mescc-tools-boot.patch \
%D%/packages/patches/meson-allow-dirs-outside-of-prefix.patch \
%D%/packages/patches/mhash-keygen-test-segfault.patch \
%D%/packages/patches/minetest-add-MINETEST_MOD_PATH.patch \
@@ -1540,9 +1527,6 @@ dist_patch_DATA = \
%D%/packages/patches/netsurf-system-utf8proc.patch \
%D%/packages/patches/netsurf-y2038-tests.patch \
%D%/packages/patches/netsurf-longer-test-timeout.patch \
- %D%/packages/patches/nettle-3.5-check-_pkcs1_sec_decrypt-msg-len.patch \
- %D%/packages/patches/nettle-3.5-CVE-2021-3580-pt1.patch \
- %D%/packages/patches/nettle-3.5-CVE-2021-3580-pt2.patch \
%D%/packages/patches/nix-dont-build-html-doc.diff \
%D%/packages/patches/nfs4-acl-tools-0.3.7-fixpaths.patch \
%D%/packages/patches/ngircd-handle-zombies.patch \
@@ -1561,10 +1545,6 @@ dist_patch_DATA = \
%D%/packages/patches/nvi-db4.patch \
%D%/packages/patches/nyacc-binary-literals.patch \
%D%/packages/patches/obs-modules-location.patch \
- %D%/packages/patches/ocaml-bitstring-fix-configure.patch \
- %D%/packages/patches/ocaml-CVE-2015-8869.patch \
- %D%/packages/patches/ocaml-Add-a-.file-directive.patch \
- %D%/packages/patches/ocaml-enable-ocamldoc-reproducibility.patch \
%D%/packages/patches/ocaml-dose3-add-unix-dependency.patch \
%D%/packages/patches/ocaml-dose3-Fix-for-ocaml-4.06.patch \
%D%/packages/patches/ocaml-dose3-dont-make-printconf.patch \
@@ -1577,20 +1557,16 @@ dist_patch_DATA = \
%D%/packages/patches/onnx-use-system-googletest.patch \
%D%/packages/patches/onnx-shared-libraries.patch \
%D%/packages/patches/onnx-skip-model-downloads.patch \
- %D%/packages/patches/openbabel-fix-crash-on-nwchem-output.patch \
%D%/packages/patches/opencascade-oce-glibc-2.26.patch \
%D%/packages/patches/openfoam-4.1-cleanup.patch \
%D%/packages/patches/openjdk-10-idlj-reproducibility.patch \
- %D%/packages/patches/openjdk-14-builtins.patch \
%D%/packages/patches/openmpi-mtl-priorities.patch \
%D%/packages/patches/openssh-hurd.patch \
%D%/packages/patches/openresolv-restartcmd-guix.patch \
%D%/packages/patches/openrgb-unbundle-hueplusplus.patch \
%D%/packages/patches/opensles-add-license-file.patch \
- %D%/packages/patches/openssl-runpath.patch \
%D%/packages/patches/openssl-1.1-c-rehash-in.patch \
%D%/packages/patches/openssl-3.0-c-rehash-in.patch \
- %D%/packages/patches/openssl-c-rehash-in.patch \
%D%/packages/patches/open-zwave-hidapi.patch \
%D%/packages/patches/orpheus-cast-errors-and-includes.patch \
%D%/packages/patches/osip-CVE-2017-7853.patch \
@@ -1601,7 +1577,6 @@ dist_patch_DATA = \
%D%/packages/patches/p7zip-remove-unused-code.patch \
%D%/packages/patches/pam-krb5-CVE-2020-10595.patch \
%D%/packages/patches/pango-skip-libthai-test.patch \
- %D%/packages/patches/passwordsafe-meson-remove-extra-argument.patch \
%D%/packages/patches/password-store-tree-compat.patch \
%D%/packages/patches/pciutils-hurd-configure.patch \
%D%/packages/patches/pciutils-hurd-fix.patch \
@@ -1627,7 +1602,6 @@ dist_patch_DATA = \
%D%/packages/patches/strace-readlink-tests.patch \
%D%/packages/patches/sunxi-tools-remove-sys-io.patch \
%D%/packages/patches/p11-kit-hurd.patch \
- %D%/packages/patches/patchutils-test-perms.patch \
%D%/packages/patches/patch-hurd-path-max.patch \
%D%/packages/patches/perl-autosplit-default-time.patch \
%D%/packages/patches/perl-finance-quote-unuse-mozilla-ca.patch \
@@ -1694,14 +1668,9 @@ dist_patch_DATA = \
%D%/packages/patches/python-3-fix-tests.patch \
%D%/packages/patches/python-3-hurd-configure.patch \
%D%/packages/patches/python-3-no-static-lib.patch \
- %D%/packages/patches/python-CVE-2018-14647.patch \
- %D%/packages/patches/python-CVE-2020-26116.patch \
%D%/packages/patches/python-aionotify-0.2.0-py3.8.patch \
%D%/packages/patches/python-argcomplete-1.11.1-fish31.patch \
- %D%/packages/patches/python-axolotl-AES-fix.patch \
- %D%/packages/patches/python-babel-fix-parse-future-test.patch \
%D%/packages/patches/python-cross-compile.patch \
- %D%/packages/patches/python2-larch-coverage-4.0a6-compatibility.patch \
%D%/packages/patches/python-configobj-setuptools.patch \
%D%/packages/patches/python-docopt-pytest6-compat.patch \
%D%/packages/patches/python-execnet-read-only-fix.patch \
@@ -1717,7 +1686,6 @@ dist_patch_DATA = \
%D%/packages/patches/python-flint-includes.patch \
%D%/packages/patches/python-libxml2-utf8.patch \
%D%/packages/patches/python-magic-python-bytecode.patch \
- %D%/packages/patches/python-matplotlib-run-under-wayland-gtk3.patch \
%D%/packages/patches/python-memcached-syntax-warnings.patch \
%D%/packages/patches/python-mox3-python3.6-compat.patch \
%D%/packages/patches/python-typing-inspect-fix.patch \
@@ -1730,7 +1698,6 @@ dist_patch_DATA = \
%D%/packages/patches/python-pyan3-fix-positional-arguments.patch \
%D%/packages/patches/python2-pygobject-2-deprecation.patch \
%D%/packages/patches/python-pygpgme-fix-pinentry-tests.patch \
- %D%/packages/patches/python-pytest-asyncio-python-3.8.patch \
%D%/packages/patches/python-pytorch-runpath.patch \
%D%/packages/patches/python-pytorch-system-libraries.patch \
%D%/packages/patches/python-robotframework-source-date-epoch.patch \
@@ -1748,7 +1715,6 @@ dist_patch_DATA = \
%D%/packages/patches/qemu-fix-agent-paths.patch \
%D%/packages/patches/qpdfview-qt515-compat.patch \
%D%/packages/patches/qrcodegen-cpp-make-install.patch \
- %D%/packages/patches/qt4-ldflags.patch \
%D%/packages/patches/qtbase-absolute-runpath.patch \
%D%/packages/patches/qtbase-moc-ignore-gcc-macro.patch \
%D%/packages/patches/qtbase-use-TZDIR.patch \
@@ -1794,7 +1760,6 @@ dist_patch_DATA = \
%D%/packages/patches/ruby-sanitize-system-libxml.patch \
%D%/packages/patches/rustc-1.39.0-src.patch \
%D%/packages/patches/rust-adblock-ignore-live-tests.patch \
- %D%/packages/patches/rust-coresimd-doctest.patch \
%D%/packages/patches/i3status-rust-enable-unstable-features.patch \
%D%/packages/patches/rust-ndarray-remove-blas-src-dep.patch \
%D%/packages/patches/rust-ndarray-0.13-remove-blas-src.patch \
@@ -1840,7 +1805,6 @@ dist_patch_DATA = \
%D%/packages/patches/spice-vdagent-glib-2.68.patch \
%D%/packages/patches/sssd-fix-samba.patch \
%D%/packages/patches/sssd-system-directories.patch \
- %D%/packages/patches/streamlink-update-test.patch \
%D%/packages/patches/steghide-fixes.patch \
%D%/packages/patches/suitesparse-mongoose-cmake.patch \
%D%/packages/patches/superlu-dist-awpm-grid.patch \
@@ -1861,7 +1825,6 @@ dist_patch_DATA = \
%D%/packages/patches/tar-remove-wholesparse-check.patch \
%D%/packages/patches/tar-skip-unreliable-tests.patch \
%D%/packages/patches/tbb-fix-test-on-aarch64.patch \
- %D%/packages/patches/tcc-boot-0.9.27.patch \
%D%/packages/patches/tclxml-3.2-install.patch \
%D%/packages/patches/tcsh-fix-autotest.patch \
%D%/packages/patches/teensy-loader-cli-help.patch \
@@ -1957,7 +1920,6 @@ dist_patch_DATA = \
%D%/packages
This message was truncated. Download the full message here.
J
J
Julien Lepiller wrote on 8 Feb 2022 12:06
(name . Leo Famulari)(address . leo@famulari.name)(address . 53837@debbugs.gnu.org)
20220208120655.4e10f5bb@tachikoma.lepiller.eu
Le Sun, 6 Feb 2022 23:20:42 -0500,
Leo Famulari <leo@famulari.name> a écrit :

Toggle quote (4 lines)
> These patches aren't used anywhere in Guix and we forgot to remove
> them.
>

Haven't checked the files, but I trust you've only removed unused
files. In that case, LGTM :)
L
L
Leo Famulari wrote on 8 Feb 2022 18:11
(name . Julien Lepiller)(address . julien@lepiller.eu)(address . 53837@debbugs.gnu.org)
YgKkVYTcpsKg+qDu@jasmine.lan
On Tue, Feb 08, 2022 at 12:06:55PM +0100, Julien Lepiller wrote:
Toggle quote (10 lines)
> Le Sun, 6 Feb 2022 23:20:42 -0500,
> Leo Famulari <leo@famulari.name> a �crit :
>
> > These patches aren't used anywhere in Guix and we forgot to remove
> > them.
> >
>
> Haven't checked the files, but I trust you've only removed unused
> files. In that case, LGTM :)

I'm hoping somebody will double-check for me :)
L
L
Ludovic Courtès wrote on 9 Feb 2022 11:48
Re: bug#53837: [PATCH] gnu: Remove leftover patch files.
(name . Leo Famulari)(address . leo@famulari.name)
87zgn071tm.fsf_-_@gnu.org
Hi!

Leo Famulari <leo@famulari.name> skribis:

Toggle quote (2 lines)
> I'm hoping somebody will double-check for me :)

Perhaps you can share the script that you used? That way we can review
the script rather than its output. :-)

Thanks,
Ludo’.
L
L
Leo Famulari wrote on 9 Feb 2022 17:45
(name . Ludovic Courtès)(address . ludo@gnu.org)
YgPvnyZ1GiLql608@jasmine.lan
On Wed, Feb 09, 2022 at 11:48:37AM +0100, Ludovic Court�s wrote:
Toggle quote (3 lines)
> Perhaps you can share the script that you used? That way we can review
> the script rather than its output. :-)

Sure, I did this:

`find gnu/packages/patches | while read patch; do git grep ${patch##gnu/packages/patches/} gnu/packages >/dev/null || echo "${patch##gnu/packages/patches/} is leftover?"; done`

I figure it could cause a problem if a patch file was used somewhere
besides 'gnu/packages', or if the patch file name was "constructed".
L
L
Ludovic Courtès wrote on 10 Feb 2022 21:55
(name . Leo Famulari)(address . leo@famulari.name)
87bkze4f2a.fsf@gnu.org
Hi,

Leo Famulari <leo@famulari.name> skribis:

Toggle quote (8 lines)
> On Wed, Feb 09, 2022 at 11:48:37AM +0100, Ludovic Courtès wrote:
>> Perhaps you can share the script that you used? That way we can review
>> the script rather than its output. :-)
>
> Sure, I did this:
>
> `find gnu/packages/patches | while read patch; do git grep ${patch##gnu/packages/patches/} gnu/packages >/dev/null || echo "${patch##gnu/packages/patches/} is leftover?"; done`

Looks reasonable to me.

Toggle quote (3 lines)
> I figure it could cause a problem if a patch file was used somewhere
> besides 'gnu/packages', or if the patch file name was "constructed".

We don’t have to worry about third-party channels. As for constructed
file names, I don’t think there are any.

To be on the safe side, you can run “make as-derivation” before pushing.
Of course that will only catch serious issues, but if other issues come
up (unlikely), we’ll follow up.

Thanks,
Ludo’.
Z
Z
zimoun wrote on 23 Feb 2022 15:18
Re: [bug#53837] [PATCH] gnu: Remove leftover patch files.
(name . Ludovic Courtès)(address . ludo@gnu.org)
CAJ3okZ3JerPT3gD45twVCzoH=fF0rVyC5=st4wzmtysTic6EfA@mail.gmail.com
Hi,

On Thu, 10 Feb 2022 at 21:56, Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (4 lines)
> To be on the safe side, you can run “make as-derivation” before pushing.
> Of course that will only catch serious issues, but if other issues come
> up (unlikely), we’ll follow up.

For some rare cases, "make as-derivation" does not catch some errors;
so when I want to be 100% sure, instead I run:

./pre-inst-env guix pull -p /tmp/new --url=$(pwd)

specifying the branch if different from master. Or something along
this line. However, then it is possible that the authentication
mechanism needs to be restored. :-)


Cheers,
simon
L
L
Leo Famulari wrote on 23 Feb 2022 15:56
(name . zimoun)(address . zimon.toutoune@gmail.com)
YhZLM94+dSzcHIDG@jasmine.lan
On Wed, Feb 23, 2022 at 03:18:34PM +0100, zimoun wrote:
Toggle quote (17 lines)
> Hi,
>
> On Thu, 10 Feb 2022 at 21:56, Ludovic Courtès <ludo@gnu.org> wrote:
>
> > To be on the safe side, you can run “make as-derivation” before pushing.
> > Of course that will only catch serious issues, but if other issues come
> > up (unlikely), we’ll follow up.
>
> For some rare cases, "make as-derivation" does not catch some errors;
> so when I want to be 100% sure, instead I run:
>
> ./pre-inst-env guix pull -p /tmp/new --url=$(pwd)
>
> specifying the branch if different from master. Or something along
> this line. However, then it is possible that the authentication
> mechanism needs to be restored. :-)

Good tips! I pushed this as d2bb4847b96e51b71126778bb16daa7674a6690c a
few days ago, but forgot to close this ticket.
Closed
?