[PATCHES] Stackage update to 18.10.

  • Done
  • quality assurance status badge
Details
5 participants
  • John Kehayias
  • Lars-Dominik Braun
  • Ludovic Courtès
  • Xinglu Chen
  • zimoun
Owner
unassigned
Submitted by
Lars-Dominik Braun
Severity
normal
L
L
Lars-Dominik Braun wrote on 27 Sep 2021 13:14
(address . guix-patches@gnu.org)
YVGneDu8dDQORdvM@noor.fritz.box
Hi everyone,

I just pushed to the wip-haskell branch (it’s based on master),
which now contains various changes to haskell-build-system as well
as an update to Stackage 18.10 or the latest Hackage package version
where applicable. CI is currently building the changes[1], but from
local building I know all but three packages using haskell-build-system
build. These are ngless, cabal-install and idris. I need your help to
fix them! There are also packages that cannot be updated via `guix
refresh` currently. They have been left mostly untouched.

I was also thinking about unconditionally adding
--allow-newer/--allow-older to haskell-build-system, so patching
.cabal-files is not necessary any more. Thoughs?

Let’s use this issue to track/review the changes and provide feedback
on them.

Thank you very much,
Lars

J
J
John Kehayias wrote on 27 Sep 2021 20:31
(name . Lars-Dominik Braun)(address . lars@6xq.net)
_5H-yYY3tTJQxN-Zu1L9g92gA7CnBHafryjpzjsvb4pGucUG5S1SIQrrABapL0F7FIAMkdfAX7XGjWU2JYU5wNtdDVTBPDk_sga-m5DmgA4=@protonmail.com
Hi Lars and everyone,

??????? Original Message ???????

On Monday, September 27th, 2021 at 7:14 AM, Lars-Dominik Braun wrote:

Toggle quote (19 lines)
> Hi everyone,
>
> I just pushed to the wip-haskell branch (it’s based on master),
> which now contains various changes to haskell-build-system as well
> as an update to Stackage 18.10 or the latest Hackage package version
> where applicable. CI is currently building the changes[1], but from
> local building I know all but three packages using haskell-build-system
> build. These are ngless, cabal-install and idris. I need your help to
> fix them! There are also packages that cannot be updated via `guix refresh`
> currently. They have been left mostly untouched.
>
> I was also thinking about unconditionally adding
> --allow-newer/--allow-older to haskell-build-system, so patching
> .cabal-files is not necessary any more. Thoughs?
>
> Let’s use this issue to track/review the changes and provide feedback
> on them.
>

Great work, thanks! I'll take a look at the package failures to see if there's anything I can do, though might be beyond my limited Haskell knowledge.

As for the --allow-newer/older, I don't have enough experience to know if that will cause any problems. I know you frequently see it to work around some dependency versions (e.g. cabal files not updated, not a problem in actual build done), but of course better to have the dependencies properly specified and available. But if it generally makes more things work with less work, I'm for it. We could disable it where needed, but since we sort of pin versions with Stackage we'd only have to check on updates, right?

Anyway, great work, looking forward to adding some more Haskell packages with the new Stackage.

John
L
L
Lars-Dominik Braun wrote on 29 Sep 2021 14:02
(name . John Kehayias)(address . john.kehayias@protonmail.com)
YVRV7Ga3KgFttyRR@noor.fritz.box
Hi,

Toggle quote (1 lines)
> Great work, thanks! I'll take a look at the package failures to see if there's anything I can do, though might be beyond my limited Haskell knowledge.
another one that is broken is ruby-pandoc-ruby, which causes ~10
dependents to fail.

Toggle quote (1 lines)
> As for the --allow-newer/older, I don't have enough experience to know if that will cause any problems.
It seems this option only works with cabal, but not plain
Setup.hs. Bummer.

Cheers,
Lars
X
X
Xinglu Chen wrote on 1 Oct 2021 19:24
877dewlktp.fsf@yoctocell.xyz
On Mon, Sep 27 2021, Lars-Dominik Braun wrote:

Toggle quote (18 lines)
> Hi everyone,
>
> I just pushed to the wip-haskell branch (it’s based on master),
> which now contains various changes to haskell-build-system as well
> as an update to Stackage 18.10 or the latest Hackage package version
> where applicable. CI is currently building the changes[1], but from
> local building I know all but three packages using haskell-build-system
> build. These are ngless, cabal-install and idris. I need your help to
> fix them! There are also packages that cannot be updated via `guix
> refresh` currently. They have been left mostly untouched.
>
> I was also thinking about unconditionally adding
> --allow-newer/--allow-older to haskell-build-system, so patching
> .cabal-files is not necessary any more. Thoughs?
>
> Let’s use this issue to track/review the changes and provide feedback
> on them.

Below is a list of questions/things-that-should-be-fixed that I found.

* What exacty does the TODO comment for ‘ghc-hsyaml’ mean? The
‘native-inputs’ comment should also be removed if tests aren’t
enabled. This applies to ‘ghc-stmonadtrans’ as well

* The ‘inputs’ comments for ‘ghc-silently’ should probably be removed.

I noticed that a lot of new packages have been auto-generated and added
as-is, without checking licenses and fixing descriptions. I have
attached a patch that fixes these (I hope I didn’t miss any packages).
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFXRFIVHHB1YmxpY0B5
b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5DgkP/iO5DoKPALrP1PbeGt2A0dWcs3uL
lIFJh+bicEE5DLA3mnlYdCqeXANPFgr5LiHx6eCTSOC6ey8MLHBMIqZm7BMCDfDS
D+Lbjaj2Jry52Wje9R1LApUjzb5u8L9T5W+v+Z+sGK1meVrcO5IU1Pec2W0i22Kl
6DWS8zTQr4HFen1QK04cBXzH0egyF8Aoh0daYgp5bhZsGss1uiPIROqb645rcZi6
eTBOgbao7Tum77sT0338UaAMiRx6XJ0rF1Y1AhQ4cMpnlBh3rr8q+VqMUsPdj21O
OlQmCxZYHfncwthoUSnbDzAAyhgEaSbteU5kfAlwayiUIgu1mS6hiQnciUxm2IbK
w1+20hTaR7I1fUbs2YBRe6XZzR5AFRG8xQDoKK5XGPmjTqoeXs/TixILtCQSp2uA
PBXvI0UZ/9pl7FYRnmw/6xNZs+V14VQ6kav3GJDqeoBBIktwCXzSeZcsNxaImk9t
w/B8ul02VxNuj0Uzjowxj/Sx6+GL0/RKH3dydsLzqFIBAUQOOVyNmJzK9pE3Cd+K
dglXuQ0g/VrgQ9U/oNyyVN7Yin+FdRBB6bbF7har6cd9QfN14lcHt9zmpGAMdKLl
3W6qaqMmAfnqAmZarPTdV9p+8dKdgvY2EcXGItB+uoaMrywaK3SQCsMZPVLm6sYL
8DHESDvvL+wJM00y
=zYzc
-----END PGP SIGNATURE-----

L
L
Lars-Dominik Braun wrote on 2 Oct 2021 11:45
(name . Xinglu Chen)(address . public@yoctocell.xyz)
YVgqJ27OsHjc4gdK@noor.fritz.box
Hi,

Toggle quote (3 lines)
> * What exacty does the TODO comment for ‘ghc-hsyaml’ mean? The
> ‘native-inputs’ comment should also be removed if tests aren’t
> enabled. This applies to ‘ghc-stmonadtrans’ as well
it means enabling tests/native-inputs creates a package dependency loop
somewhere in the graph. I’d keep the commented out native-inputs
though. Otherwise whoever wants to fix this has to add them again from
scratch. Unless there are other reasons to remove them?

Toggle quote (1 lines)
> * The ‘inputs’ comments for ‘ghc-silently’ should probably be removed.
You’re right, fixed.

Toggle quote (3 lines)
> I noticed that a lot of new packages have been auto-generated and added
> as-is, without checking licenses and fixing descriptions. I have
> attached a patch that fixes these (I hope I didn’t miss any packages).
Sorry, I ran out of time at the end and couldn’t fix them. I fixed
some brackets and pushed it, thank you for doing this tedious work.

Cheers,
Lars
X
X
Xinglu Chen wrote on 3 Oct 2021 13:35
(name . Lars-Dominik Braun)(address . lars@6xq.net)
87k0iumjcy.fsf@yoctocell.xyz
On Sat, Oct 02 2021, Lars-Dominik Braun wrote:

Toggle quote (10 lines)
> Hi,
>
>> * What exacty does the TODO comment for ‘ghc-hsyaml’ mean? The
>> ‘native-inputs’ comment should also be removed if tests aren’t
>> enabled. This applies to ‘ghc-stmonadtrans’ as well
> it means enabling tests/native-inputs creates a package dependency loop
> somewhere in the graph. I’d keep the commented out native-inputs
> though. Otherwise whoever wants to fix this has to add them again from
> scratch. Unless there are other reasons to remove them?

Ah, that makes sense.

Toggle quote (9 lines)
>> * The ‘inputs’ comments for ‘ghc-silently’ should probably be removed.
> You’re right, fixed.
>
>> I noticed that a lot of new packages have been auto-generated and added
>> as-is, without checking licenses and fixing descriptions. I have
>> attached a patch that fixes these (I hope I didn’t miss any packages).
> Sorry, I ran out of time at the end and couldn’t fix them. I fixed
> some brackets and pushed it, thank you for doing this tedious work.

You are welcome! :-)
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFZlX0VHHB1YmxpY0B5
b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5v94P/2oOH2NvEIsfFwcljbaX+kxKfBOp
P+MJh/KZBiWePP5xszDes5BhGwTr1wjcJ/VOPnpSLKa1PbtNbVQgBs28WrerQqW3
jjOvy28eIny9tZfQF0Nw7pPAWFR0f4fW2AwtUJh8GW5N6aWkGX2hhsa+uDwRLTf2
nk/OrwDic+7i/Uj4gdDw3TPGPBGE1Mxd18pwL9uBxo1IVi6YTgcuexKn+N6h33sk
s+HK+VqhZIj37vKl/UzH1QUL1zfjQX5FJnUTfVzV/kY7OMviD25gGi8WZws83sw2
9q3FbAs8OQh59aM7JwlpDGKhEreZIt+GPDglcl7QZvtTjQ6OWeqstfbeckghnE6H
UmYiL7YCK2t4RGY2r8g3ayZqNIYVWjo4jD8GsKGOvlbHqRUS0PakDcuKVq1wc1XR
z0ItlIdZ0SP/Ns8odMyVb/3F3Kn+XlAC/N5x8DE05kf4ZqIrWmU/s23ZkIRTCiUB
rRs4xKpDv0nRnSws2Zj7MbFU0b3WFbKGe4fALc5XfIYGsylKvinHdCfjrnkITzqh
mAhq2wJ3AmLd97udo9821MAHSn4/P6v0CkJhhUDRPbgzJs605aX+ztUHrkYf0XS5
MWosaX5nkJJ9Gd84KoBo99Fq9mP5O2a9v22ou4tilXoeIjI/KBYbfqpTI1WgzlPb
bKmo+BPochC1Dun3
=85ja
-----END PGP SIGNATURE-----

Z
Z
zimoun wrote on 4 Oct 2021 09:27
86r1d1dzbd.fsf@gmail.com
Hi,

On Mon, 27 Sep 2021 at 13:14, Lars-Dominik Braun <lars@6xq.net> wrote:

Toggle quote (9 lines)
> I just pushed to the wip-haskell branch (it’s based on master),
> which now contains various changes to haskell-build-system as well
> as an update to Stackage 18.10 or the latest Hackage package version
> where applicable. CI is currently building the changes[1], but from
> local building I know all but three packages using haskell-build-system
> build. These are ngless, cabal-install and idris. I need your help to
> fix them! There are also packages that cannot be updated via `guix
> refresh` currently. They have been left mostly untouched.

Thanks for working on that. :-)


Toggle quote (4 lines)
> I was also thinking about unconditionally adding
> --allow-newer/--allow-older to haskell-build-system, so patching
> .cabal-files is not necessary any more. Thoughs?

What do you mean?

Cheers,
simon
L
L
Lars-Dominik Braun wrote on 8 Oct 2021 09:28
Re: [PATCHES] Stackage update to 18.10.
(address . 50843-done@debbugs.gnu.org)
YV/zBkpBA9qHDUPK@noor.fritz.box
Hi everyone,

I merged the branch wip-haskell into master as
fe56213027d9828c61fa06211458a23f32431e0b and following.

Let’s hope we can follow Stackage more closely in the future.

Cheers,
Lars
Closed
X
X
Xinglu Chen wrote on 8 Oct 2021 15:53
Re: bug#50843: [PATCHES] Stackage update to 18.10.
87bl3zmxmb.fsf@yoctocell.xyz
On Fri, Oct 08 2021, Lars-Dominik Braun wrote:

Toggle quote (7 lines)
> Hi everyone,
>
> I merged the branch wip-haskell into master as
> fe56213027d9828c61fa06211458a23f32431e0b and following.
>
> Let’s hope we can follow Stackage more closely in the future.

Great! Thank you for the work! \o/
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFgTUwVHHB1YmxpY0B5
b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5bvIP/iuLlTMuC7VZnfPz0RNxKVMw67NI
N+WqILjACbomDPwmjB6orlMQZleN+qC44KXpFxXeyaAy10d+0w/Zs4WTN7kOK7H5
PXRb/kOdS44QAq2ekwOAOqH+FQrh4HaVW6WV1VaTmApYjeDgT7NXsV0HgDTunbj3
ZRwKrlNHACnmFg81pJ6oQYokpxVoBv4nZ7pgKvMAnA05uosqU5ubl6BegmhG3932
HQGbeQAMTwim6sVZgb0VoKycwwCAH5xnxWrCd9dFf+zHJVYXCK7S4fCYFpjmsDq1
onr2BFsV9GFo5N5ivlQv/7ODDsaeqJB0KzzzYiFV8S4HHNeODRvT0ADsOEyooaOb
q9xIbJyBkKF7d83X1poZ5P2Lpuof2A+tWqY43TQ0UWM0Eg9yMfcA7T2DF7aoTCzF
zUrRdSBiUHk69TqM5uF6kNP8BdAvdPcVhYqf/Mcv5ZCOi1OahUHQuSoBVmp5pDVO
19588fCaVfhAyTfaF+xRs1ix4IXjIk4hOEvA7Hc7ytWO6DZPM8nmlqbY5npuU0tE
z0IEMsu3u96wTCTQcCyahtMDmSGsU0zQJxnT8oY6kWp4Ot+7VoimjtmQU6MV7pJ0
M6D+dUVqt4aYD92n0DLYxHEPdH74WaMSP3/3m9K91tujS+Ic3uB+rkJq7wnatMoY
548bK6sQuljSiKKH
=lmGH
-----END PGP SIGNATURE-----

Closed
J
J
John Kehayias wrote on 8 Oct 2021 16:23
(name . Xinglu Chen)(address . public@yoctocell.xyz)
eQ0ahBY_7KGmFnpgcg_bARiKLhONW8GsBdFXZu5ED-nHZPNS7u48eIEAj-dlC0k8rH7-ux18ZWT4lZEtsPHfipqfUS88UW1LF-z5avsEzB4=@protonmail.com
Yes, great work, thank you!
Closed
L
L
Ludovic Courtès wrote on 9 Oct 2021 00:47
871r4v3zhj.fsf_-_@gnu.org
Hi,

Toggle quote (3 lines)
> I merged the branch wip-haskell into master as
> fe56213027d9828c61fa06211458a23f32431e0b and following.

Yay, congrats! \o/

Ludo’.
?