Update sbcl

  • Done
  • quality assurance status badge
Details
2 participants
  • Charles
  • Guillaume Le Vaillant
Owner
unassigned
Submitted by
Charles
Severity
normal
C
C
Charles wrote on 27 Sep 2021 07:51
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
Z-2xLZ6o5fxTIJvKOam2LuyZLUb8zqv6DLlgNsLf-mK_MzG0sQtcXSk5mqsdu81ehF3V8T_80txQMEHP5ivKprtjCL_zM5bl3n6Xg836ep8=@protonmail.com
Empty Message
Attachment: file
From 738370cd57bdb5874378797811f87dd7dafbab78 Mon Sep 17 00:00:00 2001
From: Charles <charles.b.jackson@protonmail.com>
Date: Mon, 27 Sep 2021 00:43:17 -0500
Subject: [PATCH] gnu: sbcl: Update to 2.1.8.

* gnu/packages/lisp.scm (sbcl): Update to 2.1.8.
---
gnu/packages/lisp.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 7eb8f54d49..c924880ac9 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -404,14 +404,14 @@ an interpreter, a compiler, a debugger, and much more.")
(define-public sbcl
(package
(name "sbcl")
- (version "2.1.6")
+ (version "2.1.8")
(source
(origin
(method url-fetch)
(uri (string-append "mirror://sourceforge/sbcl/sbcl/" version "/sbcl-"
version "-source.tar.bz2"))
(sha256
- (base32 "1vydq6mmssla2vn0plpsrm50n3b42a464zxw72j6qihas9fhq8cb"))))
+ (base32 "0ijmw8adyf6fgaq4ixdj9v5lfg3cs9wyxhb96wxhfld0rjpppsm3"))))
(build-system gnu-build-system)
(outputs '("out" "doc"))
(native-inputs
--
2.32.0
G
G
Guillaume Le Vaillant wrote on 27 Sep 2021 14:32
(name . Charles)(address . charles.b.jackson@protonmail.com)
87tui6gpay.fsf@kitej
Hi,

Some time ago when Pierre Neidhardt tried to update SBCL to 2.1.7, some
packages failed to compile (because of changes in the internals of SBCL
I think). See commits b07581d6e24bf5fa4676bcebaba75315bbbb01e6 and
7c6ace67bb8ef421965e3f1cc1a02caf54c813f5.

Did you try building all the sbcl-* packages with SBCL 2.1.8 to check if
everything works fine?
If some packages are failing, we will have to update them as well
(upstreams probably have commits or PRs to fix compatibility with newer
SBCL versions).
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYVG85Q8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j+gQAD/QD+zajheseY/zpm9zbBszB4WINz8nDjQLKi6
XHhGYtsA/RH/MiKIqJWU0a/PulW94/75NW2lq0zCh3oLZAO7EV27
=1SSL
-----END PGP SIGNATURE-----

C
C
Charles wrote on 27 Sep 2021 21:45
(name . Guillaume Le Vaillant)(address . glv@posteo.net)
6MX54YemJ-AGcuLSj62jQBOdU2WxXszXgHBDPRulsoX2FoxzEbRYkUh51n6r7uj-8UIGHqi_btoQ6NOiRamWkM0zevhOLA36pvM3-s7-PRU=@protonmail.com
I built all sbcl-* packages, I used this snippet to build them; let me know if there is a better way.

./pre-inst-env guix build $(./pre-inst-env guix search "^name: sbcl-" | awk '{ print $2 }' | tr '\n' ' ')

sbcl-burgled-batteries3 fails to build. It also fails on sbcl 2.1.6. Perhaps people are not really using the sbcl version of this package and just using the ecl version as it builds fine. I'm not sure how the build system works for cl- packages, but apparently it uses sbcl too.

Same story with sbcl-png.

These are the only two offenders; all other packages built fine.
??????? Original Message ???????

On Monday, September 27th, 2021 at 7:32 AM, Guillaume Le Vaillant <glv@posteo.net> wrote:

Toggle quote (19 lines)
> Hi,
>
> Some time ago when Pierre Neidhardt tried to update SBCL to 2.1.7, some
>
> packages failed to compile (because of changes in the internals of SBCL
>
> I think). See commits b07581d6e24bf5fa4676bcebaba75315bbbb01e6 and
>
> 7c6ace67bb8ef421965e3f1cc1a02caf54c813f5.
>
> Did you try building all the sbcl-* packages with SBCL 2.1.8 to check if
>
> everything works fine?
>
> If some packages are failing, we will have to update them as well
>
> (upstreams probably have commits or PRs to fix compatibility with newer
>
> SBCL versions).
C
C
Charles wrote on 28 Sep 2021 03:54
(name . Guillaume Le Vaillant)(address . glv@posteo.net)
vaQraBFdK4lxqu13rgth9Tzi89iEpjqBZX0vTObzlYNRC0MMF0RpsLBfREu_F5jd_tSeW56fGPm7IEsbPVJKgNzxGgRPv9bPgogTBmYIkKY=@protonmail.com
I knotice that sbcl 2.1.9 came out, so these patches are to go straight to 2.1.9. I needed to update sbcl-esrap with no further problems. Same issues with sbcl-burgled-batteries3 and sbcl-png though for sbcl-png, I noticed a github pull request (https://github.com/ljosa/cl-png/pull/6)with a fix.
From 32be9a1aa3a3a9eb505653cd647f2fa46ccfa1dd Mon Sep 17 00:00:00 2001
From: Charles <charles.b.jackson@protonmail.com>
Date: Mon, 27 Sep 2021 20:41:06 -0500
Subject: [PATCH 1/2] gnu: cl-esrap: Update to 0.18-2.866f28f.

* gnu/packages/lisp-xyz.scm (sbcl-esrap): Update to 0.18-2.866f28f.
---
gnu/packages/lisp-xyz.scm | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

Toggle diff (35 lines)
diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 7f7a7e9e92..11955c7dee 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -1813,8 +1813,8 @@ that of Eos has not. Thus, Eos is now deprecated in favor of FiveAM.")
(sbcl-package->ecl-package sbcl-eos))
(define-public sbcl-esrap
- (let ((commit "da6b24fb18bdb8e7e177bcf2820cdaf0b560deb6")
- (revision "1"))
+ (let ((commit "866f28fa7a2c1d3fb6d0d0423850d1f9d955750f")
+ (revision "2"))
(package
(name "sbcl-esrap")
(version (git-version "0.18" revision commit))
@@ -1825,13 +1825,15 @@ that of Eos has not. Thus, Eos is now deprecated in favor of FiveAM.")
(url "https://github.com/scymtym/esrap")
(commit commit)))
(sha256
- (base32 "12vf3bxwzf8icnf6rw1xalvm7493cfbb46r2vlhc09s59djkf39q"))
+ (base32 "19rb3dmpw3csqqagmrf80dpk5d2qn0l7fpfmxx5zwdnjk367kbwg"))
(file-name (git-file-name "esrap" version))))
(build-system asdf-build-system/sbcl)
(native-inputs
`(("fiveam" ,sbcl-fiveam)))
(inputs
- `(("alexandria" ,sbcl-alexandria)))
+ `(("alexandria" ,sbcl-alexandria)
+ ("trivial-with-current-source-form"
+ ,sbcl-trivial-with-current-source-form)))
(synopsis "Common Lisp packrat parser")
(description
"This is a packrat parser for Common Lisp.
--
2.32.0
From 3187e04b445742218d97afae4b8475166d61574a Mon Sep 17 00:00:00 2001
From: Charles <charles.b.jackson@protonmail.com>
Date: Mon, 27 Sep 2021 20:44:17 -0500
Subject: [PATCH 2/2] gnu: sbcl: Update to 2.1.9.

* gnu/packages/lisp.scm (sbcl): Update to 2.1.9.
---
gnu/packages/lisp.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (23 lines)
diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index 7eb8f54d49..9fd2cbab31 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -404,14 +404,14 @@ an interpreter, a compiler, a debugger, and much more.")
(define-public sbcl
(package
(name "sbcl")
- (version "2.1.6")
+ (version "2.1.9")
(source
(origin
(method url-fetch)
(uri (string-append "mirror://sourceforge/sbcl/sbcl/" version "/sbcl-"
version "-source.tar.bz2"))
(sha256
- (base32 "1vydq6mmssla2vn0plpsrm50n3b42a464zxw72j6qihas9fhq8cb"))))
+ (base32 "189gjqzdz10xh3ybiy4ch1r98bsmkcb4hpnrmggd4y2g5kqnyx4y"))))
(build-system gnu-build-system)
(outputs '("out" "doc"))
(native-inputs
--
2.32.0
G
G
Guillaume Le Vaillant wrote on 28 Sep 2021 11:47
(name . Charles)(address . charles.b.jackson@protonmail.com)
87sfxp10zq.fsf@kitej
Charles <charles.b.jackson@protonmail.com> skribis:

Toggle quote (5 lines)
> I knotice that sbcl 2.1.9 came out, so these patches are to go straight to
> 2.1.9. I needed to update sbcl-esrap with no further problems. Same issues with
> sbcl-burgled-batteries3 and sbcl-png though for sbcl-png, I noticed a github
> pull request (https://github.com/ljosa/cl-png/pull/6) with a fix.

Patches pushed as 9bf9dd79ef907a7faab012f1c60c09e0819e179f and
following. Thanks.

I added patches to fix sbcl-png and sbcl-burgled-batteries3, and I check
that everything depending on SBCL builds fine with:

Toggle snippet (2 lines)
./pre-inst-env guix build $(./pre-inst-env guix refresh -l sbcl | cut -d ':' -f 2-)
Closed
?