[PATCH] gnu: python-wtforms: Update to 2.3.3.

Hi Guix,

This is related to 47260.

Attached is a patch for an upgrade to python-wtforms 2.3.3.

Tests are currently disabled in the attached patch.

I added a when form in the code for when we are ready to enable the tests.

I'm getting the following error when I try to run the tests with tox:

error: [Errno 13] Permission denied: 'WTForms-2.3.3/setup.cfg'

Should I be using make-file-writable on the above or is this a different issue?

I have not been able to successfully run all the tests without using tox manually.

See the comment I placed in the patch with a link to the github issue that I opened upstream.

Help and/or advice with testing this is much appreciated.

What is the consensus for using tox with guix?

I see only one other package in the guix source tree that is currently invoking tox and that package is broken: python-funcparserlib.

python-hy is also broken (it depends on python-funcparserlib and fails because of it)

I think Tobias is currently working on those.

all the best,

jgart

Hi,

[...]

Tox is an environment manager. As such, it is redundant in Guix. Tox is

not a hard requirement for tests in any project.

You can inspect the tox.ini file that is shipped in projects. This is

the tox.ini from wtforms, in the 2.3.3 tag: [1]. Note that the test

command that tox will run is:

After running these commands in the custom check phase, I could

succesfully run the tests. I also added python-sqlalchemy and python-

dateutil to native-inputs.

Note that it requires django<1.7 which we don't have, but it's

optional. It seems that the testing command will change again in

version 3 to a standard pytest call and the legacy dependencies will be

removed [2] (also see tox.ini in the master branch).

funcparserlib is broken because version 0.3.6 is compatible with only

up to Python 3.5 (it was released in 2013). There should be a 1.0.0

release this year [3] and it doesn't seem that 0.3.6 can be fixed from

our side.

It does not depend on tox either. Once 1.0.0 is released and packaged,

tox can be removed and it should run without replacing the check phase

(it uses unittest). Tox is still there because that package is

currently stagnating.

Vinicius

[1] https://github.com/wtforms/wtforms/blob/2.3.3/tox.ini

[2] https://github.com/wtforms/wtforms/commit/c49ecfb7e76f919eafb5c6a11c3b795c4e613757

[3] https://github.com/vlasovskikh/funcparserlib/issues/65

Hi Jgart,

Vinicius's approach his makes sense to me - we only need to test wtforms on the version of Python in Guix, not all possible versions the library supports. Would you be able to proceed with calling the tests as Vinicius describes?

This is the last dependency we need to package MediaGoblin! Very exciting!

Regards,

Ben

[phases](remove-django-test): Remove phase.

(check): Replace with custom phase.

[native-inputs]: Remove unzip. Add python-babel, python-coverage,

python-dateutil, python-pep8 and python-sqlalchemy.

[propagated-inputs]: Add python-markupsafe.

---

gnu/packages/python-web.scm | 30 +++++++++++++++++-------------

1 file changed, 17 insertions(+), 13 deletions(-)

[phases](remove-django-test): Remove phase.

(check): Replace with custom phase.

[native-inputs]: Remove unzip. Add python-coverage, python-dateutil,

python-pep8 and python-sqlalchemy.

[propagated-inputs]: Add python-babel, python-email-validaor and

python-markupsafe.

---

gnu/packages/python-web.scm | 31 ++++++++++++++++++-------------

1 file changed, 18 insertions(+), 13 deletions(-)

Pushed to master as 87ec1ae95c..73f68c1a45.