[PATCH 1/3] gnu: music: python-abjad: Abjad Improvements.

Hi Guix,

Below are some improvements to the python-abjad package that was merged the other day.

I changed the name to abjad, moved some inputs into their correct place, and improved its description.

best regards,

jgart

On Fri, 2021-04-16 at 04:57 +0000, jgart via Guix-patches via wrote:

Please move 'lilypond' from propagated-inputs to 'inputs', if sanely possible!

This avoids polluting the profile with packages the user did not

explicitely request. Of course, abjad still somehow has to find

lilypond, so you might need to replace "lilypond" with

(string-append (assoc-ref inputs "lilypond") "/bin/lilypond")

somewhere in python-abjad's source code. You can use substitute*

for that.

Greetings,

Maxime.

Hi Maxime,

Thank you for the review! I attached a new patch set.

I reverted to Bonface's original idea of having lilypond only as a native input in the package definition.

I prefer this solution in order to solve the problem since it follows upstream's instructions of installing lilypond separately (https://abjad.github.io/first_steps/linux.html),doesn't pollute a guix user's profile with lilypond as you mentioned, and seems a bit cleaner since I don't have to touch the python sources in order to make them find the lilypond input.

If the user wants to produce a pdf then they can just include lilypond in their profile.

What do you think?

best regards,

jgart

ps

This caused me to have to add lilypond as a native-input to abjad-ext-rmakers (47816), abjad-ext-nauert (47817), and abjad-ext-ipython (47818) since those where building successfully before because they had abjad as a propagated input and abjad had lilypond as a propagated input. The above mentioned packages require lilypond for the tests.

April 16, 2021 6:12 AM, "Maxime Devos" <maximedevos@telenet.be> wrote:

jgart schreef op vr 16-04-2021 om 17:59 [+0000]:

If you do that, make sure "abjad" does not retain a reference to lilypond,

as otherwise when cross-compiling, "abjad" will use a lilypond built for the

incorrect architecture. You can use #:disallowed-references ,lilypond for this.

(TODO: there should be a #:disallowed-refences/native variant. But

#:disallowed-references will suffice for now.)

I'm currently occupied with some other things, so I can't review your revised

patches yet.

Greetings,

Maxime.

Hi Maxime,

I tried your suggestion but it fails with the following exception:

Backtrace:

...

In guix/build-system/python.scm:

162:0 3 (python-build _ _ _ #:tests? _ #:test-target _ # _ # _ # …)

In ice-9/boot-9.scm:

1669:16 2 (raise-exception _ #:continuable? _)

1669:16 1 (raise-exception _ #:continuable? _)

1669:16 0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1669:16: In procedure raise-exception:

Unrecognized keyword: #:disallowed-references

It looks like python-build-system might not support #:disallowed-references.

Is that correct?

all the best,

jgart

ps

I did a quick search for it with ripgrep and it seems like only gnu, meson, and glib-or-gtk support it currently:

rg "\#:disallowed-references" -t lisp | rg build-system

guix/build-system/meson.scm: #:disallowed-references

guix/build-system/gnu.scm: #:disallowed-references

guix/build-system/gnu.scm: #:disallowed-references

guix/build-system/glib-or-gtk.scm: #:disallowed-references

April 17, 2021 5:12 AM, "Maxime Devos" <maximedevos@telenet.be> wrote:

I accidentally forgot to keep 47815@debbugs.gnu.org in To:.

Sorry for the long delay! I made a couple of changes:

I added python-abjad as a deprecated package, so it won't break for

anyone who already has it installed.

I sorted python-ply alphabetically when moving it to propagated-inputs.

I also moved lilypond to inputs and removed the now unnecessary

'patch-source phase.

Thanks! Patches pushed.

--

Efraim Flashner <efraim@flashner.co.il> ????? ?????

GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351

Confidentiality cannot be guaranteed on emails sent or received unencrypted