[PATCH] gnu: python-mechanicalsoup: Update to 1.0.0

  • Done
  • quality assurance status badge
Details
3 participants
  • Efraim Flashner
  • Ekaitz Zarraga
  • Maxime Devos
Owner
unassigned
Submitted by
Ekaitz Zarraga
Severity
normal
E
E
Ekaitz Zarraga wrote on 12 Apr 2021 12:22
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
ptMBKfXwfNLNcFIGfDJgxphHqOg4v94QyYnVCsDNClNEGSxdMvPIzRLkStmHc55UUrjJNW4Vsq0lOQuIxDapKBONxHTvDL6lpNhyuhIyMSE=@elenq.tech
From 3fe85d531c56e025868eb90def1b491a9fa32a60 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Mon, 12 Apr 2021 12:15:44 +0200
Subject: [PATCH] gnu: python-mechanicalsoup: Update to 1.0.0

* gnu/packages/python-web.scm (python-mechanicalsoup): Update to
1.0.0.
(python-machanicalsoup): Enable tests
---
gnu/packages/python-web.scm | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)

Toggle diff (52 lines)
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index c79fa1bfc4..e842112e97 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -40,6 +40,7 @@
;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
;;; Copyright © 2020 Konrad Hinsen <konrad.hinsen@fastmail.net>
;;; Copyright © 2020 Giacomo Leidi <goodoldpaul@autistici.org>
+;;; Copyright © 2021 Ekaitz Zarraga <ekaitz@elenq.tech>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -795,29 +796,27 @@ object graph to and from JSON.")
(define-public python-mechanicalsoup
(package
(name "python-mechanicalsoup")
- (version "0.11.0")
+ (version "1.0.0")
(source
(origin
(method url-fetch)
(uri (pypi-uri "MechanicalSoup" version))
(sha256
- (base32 "0k59wwk75q7nz6i6gynvzhagy02ql0bv7py3qqcwgjw7607yq4i7"))))
+ (base32 "01sddjxy3rznh63hnl5lbv1hhk6xyiviwmkiw4x7v4ap35fb3lrp"))))
(build-system python-build-system)
- (arguments
- ;; TODO: Enable tests when python-flake8@3.5 hits master.
- `(#:tests? #f))
(propagated-inputs
`(("python-beautifulsoup4" ,python-beautifulsoup4)
("python-lxml" ,python-lxml)
("python-requests" ,python-requests)
("python-six" ,python-six)))
- ;; (native-inputs
- ;; ;; For tests.
- ;; `(("python-pytest-flake8" ,python-pytest-flake8)
- ;; ("python-pytest-httpbin" ,python-pytest-httpbin)
- ;; ("python-pytest-mock" ,python-pytest-mock)
- ;; ("python-pytest-runner" ,python-pytest-runner)
- ;; ("python-requests-mock" ,python-requests-mock)))
+ (native-inputs
+ ;; For tests.
+ `(("python-pytest-flake8" ,python-pytest-flake8)
+ ("python-pytest-httpbin" ,python-pytest-httpbin)
+ ("python-pytest-cov" ,python-pytest-cov)
+ ("python-pytest-mock" ,python-pytest-mock)
+ ("python-pytest-runner" ,python-pytest-runner)
+ ("python-requests-mock" ,python-requests-mock)))
(home-page "https://mechanicalsoup.readthedocs.io/")
(synopsis "Python library for automating website interaction")
(description
--
2.31.0
M
M
Maxime Devos wrote on 12 Apr 2021 17:04
82082dfc9263f52c690e83c4ff17d67cd5b91a52.camel@telenet.be
On Mon, 2021-04-12 at 10:22 +0000, Ekaitz Zarraga wrote:
Toggle quote (8 lines)
> From 3fe85d531c56e025868eb90def1b491a9fa32a60 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Mon, 12 Apr 2021 12:15:44 +0200
> Subject: [PATCH] gnu: python-mechanicalsoup: Update to 1.0.0
>
> * gnu/packages/python-web.scm (python-mechanicalsoup): Update to
> 1.0.0.
> (python-machanicalsoup): Enable tests
Nitpick: a period after ‘Enable tests’.

Unlike in "ChangeLog" files, the changelog entry in commit messages
are not indented. These tabs can be removed.

Toggle quote (34 lines)
> ---
> gnu/packages/python-web.scm | 23 +++++++++++------------
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index c79fa1bfc4..e842112e97 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -40,6 +40,7 @@
> ;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
> ;;; Copyright © 2020 Konrad Hinsen <konrad.hinsen@fastmail.net>
> ;;; Copyright © 2020 Giacomo Leidi <goodoldpaul@autistici.org>
> +;;; Copyright © 2021 Ekaitz Zarraga <ekaitz@elenq.tech>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -795,29 +796,27 @@ object graph to and from JSON.")
> (define-public python-mechanicalsoup
> (package
> (name "python-mechanicalsoup")
> - (version "0.11.0")
> + (version "1.0.0")
> (source
> (origin
> (method url-fetch)
> (uri (pypi-uri "MechanicalSoup" version))
> (sha256
> - (base32 "0k59wwk75q7nz6i6gynvzhagy02ql0bv7py3qqcwgjw7607yq4i7"))))
> + (base32 "01sddjxy3rznh63hnl5lbv1hhk6xyiviwmkiw4x7v4ap35fb3lrp"))))
> (build-system python-build-system)
> - (arguments
> - ;; TODO: Enable tests when python-flake8@3.5 hits master.
> - `(#:tests? #f))

Nice!

Warning: I haven't tried to build this. But from a cursory look, the patch LGTM!
This package has one depending package: hangups@0.4.13. Does that package still
build?

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYHRhaRccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7twdAP9me6qG3zGyuXWCU16FFWNmzBlv
ILSta2FC9m0XnYk4PAEAh7CLEPbkqXHAjXDo1+o+UNKafF/G7H3d9+dw5jNq9gk=
=Zq4O
-----END PGP SIGNATURE-----


E
E
Efraim Flashner wrote on 12 Apr 2021 14:17
(name . Ekaitz Zarraga)(address . ekaitz@elenq.tech)(address . 47722-done@debbugs.gnu.org)
YHQ6cpjFIHdbAmvX@3900XT
Thanks. I adjusted the indentation and fixed hangups so it doesn't break
with the newer version.

Patch pushed!

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmB0OnIACgkQQarn3Mo9
g1GibxAAvjPLidZEXWxMNLwQUR64quVzkti36oMirTwnf6TcyuVm6dc0LBzQJorc
lTgQwYsFVAsP7zeeVuYpDG0CXYOXF/eia0jmfCjIJr1DPYim2I6CkuesA/TdF3fn
BoG91kXNnApIJvjQm3FnaBKUqQXP3TYtwuraHKYinig6i8dd7117MftC8ZPr9t2Y
gETSdIvfpR0V4PGhlQ0fdBAFzs62M75w9vclJKuHQ/xOzDhgCyEPpOwhfpTLhE+N
+u69Cu99uTXAv+Jikk4R/Gb7E1ubgHQHrqrHlNR4Ktl4waMMyO+kgKRKQoGpAbUT
HaKOWJKNGvK1lC2VflmmOv+FTJf/0KhIx3izSqAI0F2vVqdZ4TFlXR9pbB/Zi+Z3
2jFxQmRw9DaLhSodN2QslVrb8fWmk1NDtkOXSuBWN/1OYms3xA2k1CfGTrqrpa5B
G6OjB2pqpCKdQda99u+OHGiwrI0XOmvJ7gQJeMU/jJ6WdUA1nuu2kAgQznMnQIYz
ZGckiklBcqckOCO4TgWumrOM4wa66lsQ0oGcOrIF+k58XBhhIy2hzFREJE1Lt5ce
IGfKGToCUU1JAyHau7l9TXwWmfZ5nVPpMbFzDUyiEpTDvGBURCi9Jvcf5i/uZhd2
3AQcwjYqR+JZZ432J1TKK61QTLhrzk3kU6TsJhOaqgcRop5pYK0=
=Y7Ut
-----END PGP SIGNATURE-----


Closed
?