sqlite package is vulnerable to CVE-2020-11655, CVE-2020-11656, CVE-2020-13434, CVE-2020-13435, CVE-2020-13630, CVE-2020-13631, CVE-2020-13632, CVE-2020-15358 and CVE-2020-9327

Léo Le Bouter wrote on 18 Mar 12:42 +0100

Recipients:(address . bug-guix@gnu.org)

Message-ID:0381641839f5d0e71cbb496b95b9947a2a2c2799.camel@zaclys.net

According tohttps://www.sqlite.org/versionnumbers.htmlmajor versions of sqlite remain ABI and file format backwardscompatible.
It means we could graft without trouble, 3.32.3 fixes all CVEs, however3.32 introduces a test failure in Python 3.8.2 which is an errorneoustest testing internal sqlite implementation detail (but grafting wontactually re-run this test suite).
See: https://bugs.python.org/issue40784
Otherwise I am still trying to run GNU Guix's own test suite on thisbut it turns out unnecessarily complicated, see https://issues.guix.gnu.org/47230for suggestions on improving thatprocess.
Attached WIP patch.
Thank you!
Léo

From b0f9566e9ff9a5f409a3fd4293c048ec58bc770d Mon Sep 17 00:00:00 2001From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= <lle-bout@zaclys.net>Date: Thu, 18 Mar 2021 07:09:10 +0100Subject: [PATCH] gnu: sqlite: Update to 3.32.3 [security fixes].
* gnu/packages/sqlite.scm (sqlite/fixed): New variable.(sqlite)[replacement]: Graft.--- gnu/packages/sqlite.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)

Toggle diff (41 lines)diff --git a/gnu/packages/sqlite.scm b/gnu/packages/sqlite.scmindex eeb77749d8..cc378b359a 100644--- a/gnu/packages/sqlite.scm+++ b/gnu/packages/sqlite.scm@@ -65,6 +65,7 @@             (sha256              (base32               "1bj936svd8i5g25xd1bj52hj4zca01fgl3sqkj86z9q5pkz4wa32"))))+   (replacement sqlite/fixed)    (build-system gnu-build-system)    (inputs `(("readline" ,readline)))    (native-inputs (if (hurd-target?)@@ -122,6 +123,26 @@ widely deployed SQL database engine in the world.  The source code for SQLite is in the public domain.")    (license license:public-domain))) +(define-public sqlite/fixed+  (package/inherit sqlite+    (version "3.32.3")+    (source (origin+              (method url-fetch)+              (uri (let ((numeric-version+                          (match (string-split version #\.)+                            ((first-digit other-digits ...)+                             (string-append first-digit+                                            (string-pad-right+                                             (string-concatenate+                                              (map (cut string-pad <> 2 #\0)+                                                   other-digits))+                                             6 #\0))))))+                     (string-append "https://sqlite.org/2020/sqlite-autoconf-"+                                    numeric-version ".tar.gz")))+              (sha256+               (base32+                "0rlbaq177gcgk5dswd3akbhv2nvvzljrbhgy18hklbhw7h90f5d3"))))))+ ;; Column metadata support was added to the regular 'sqlite' package with ;; commit fad5b1a6d8d9c36bea5785ae4fbc1beb37e644d7. (define-public sqlite-with-column-metadata-- 2.31.0

Léo Le Bouter wrote on 19 Mar 11:30 +0100

Recipients:(address . control@debbugs.gnu.org)

Message-ID:e09ecd15bacb52d3c8441c1f6f8cb42329efc496.camel@zaclys.net

tags 47231 + securityquit

Léo Le Bouter wrote on 24 Mar 00:37 +0100

Recipients:(address . 47231@debbugs.gnu.org)

Message-ID:e38a431d1fe6bd5b2a79746b04497cc3fec49c59.camel@zaclys.net

One more:
CVE-2021-20227	23.03.21 18:15A flaw was found in SQLite's SELECT query functionality (src/select.c).This flaw allows an attacker who is capable of running SQL querieslocally on the SQLite database to cause a denial of service or possiblecode execution by triggering a use-after-free. The highest threat fromthis vulnerability is to system availability.

Léo Le Bouter wrote on 24 Mar 23:54 +0100

Recipients:(address . 47231@debbugs.gnu.org)

Message-ID:b8543b82478ccf61691186795f331f6ff9679862.camel@zaclys.net

I could test the graft with GNU Guix's test suite by manually replacingthe sqlite input with sqlite/fixed like so:

Toggle diff (22 lines)

diff --git a/gnu/packages/package-management.scmb/gnu/packages/package-management.scmindex 888f54322d..70f5c2dad3 100644--- a/gnu/packages/package-management.scm+++ b/gnu/packages/package-management.scm@@ -389,7 +389,7 @@ $(prefix)/etc/init.d\n"))) (inputs `(("bzip2" ,bzip2) ("gzip" ,gzip)- ("sqlite" ,sqlite)+ ("sqlite" ,sqlite/fixed) ("libgcrypt" ,libgcrypt) ("guile" ,guile-3.0-latest)
It worked fine.
Is that enough of a test to graft in master?
Let me know and I will push.
Léo

Tobias Geerinckx-Rice wrote on 25 Mar 12:27 +0100

Recipients:

Message-ID:87y2ebh3rz.fsf@nckx

Thanks!
I'm currently rebuilding IceCat with this change as an extra precaution, but that shouldn't take long. If that doesn't cause problems this LGTM for master.
Ludo', do you think the Guix test described here is a good one?
Kind regards,
T G-R

Tobias Geerinckx-Rice wrote on 25 Mar 16:56 +0100

Recipients:

Message-ID:87lfabgrcf.fsf@nckx

Tobias Geerinckx-Rice via Bug reports for GNU Guix writes:

Toggle quote (4 lines)

> I'm currently rebuilding IceCat with this change as an extra> precaution, but that shouldn't take long. If that doesn't cause > problems this LGTM for master.

OK, it worked, old IceCat writes new SQlite files.
Kind regards,
T G-R

Mark H Weaver wrote on 26 Mar 02:23 +0100

Recipients:

Message-ID:878s6ar9ko.fsf@netris.org

Léo Le Bouter via Bug reports for GNU Guix <bug-guix@gnu.org> writes:

Toggle quote (30 lines)> From b0f9566e9ff9a5f409a3fd4293c048ec58bc770d Mon Sep 17 00:00:00 2001> From: =?UTF-8?q?L=C3=A9o=20Le=20Bouter?= <lle-bout@zaclys.net>> Date: Thu, 18 Mar 2021 07:09:10 +0100> Subject: [PATCH] gnu: sqlite: Update to 3.32.3 [security fixes].>> * gnu/packages/sqlite.scm (sqlite/fixed): New variable.> (sqlite)[replacement]: Graft.> --->  gnu/packages/sqlite.scm | 21 +++++++++++++++++++++>  1 file changed, 21 insertions(+)>> diff --git a/gnu/packages/sqlite.scm b/gnu/packages/sqlite.scm> index eeb77749d8..cc378b359a 100644> --- a/gnu/packages/sqlite.scm> +++ b/gnu/packages/sqlite.scm> @@ -65,6 +65,7 @@>              (sha256>               (base32>                "1bj936svd8i5g25xd1bj52hj4zca01fgl3sqkj86z9q5pkz4wa32"))))> +   (replacement sqlite/fixed)>     (build-system gnu-build-system)>     (inputs `(("readline" ,readline)))>     (native-inputs (if (hurd-target?)> @@ -122,6 +123,26 @@ widely deployed SQL database engine in the world.  The source code for SQLite>  is in the public domain.")>     (license license:public-domain)))>  > +(define-public sqlite/fixed> +  (package/inherit sqlite

Just a reminder that, just as with 'mysql/fixed', 'sqlite/fixed' should*not* use 'package/inherit', since the package you're defining is thereplacement for the package you're inheriting from.
Otherwise, it looks good to me!
Thanks, Mark

Léo Le Bouter wrote on 26 Mar 02:36 +0100

Recipients:

Message-ID:318a4b5eed01580d377cc8199a4bfb0db30b5eeb.camel@zaclys.net

On Thu, 2021-03-25 at 21:23 -0400, Mark H Weaver wrote:

Toggle quote (11 lines)> > Just a reminder that, just as with 'mysql/fixed', 'sqlite/fixed'> should> *not* use 'package/inherit', since the package you're defining is the> replacement for the package you're inheriting from.> > Otherwise, it looks good to me!> >      Thanks,>        Mark

Adapted, wasnt sure what package/inherit was for exactly.
Tobias Geerinckx-Rice via Bug reports for GNU Guix writes:

Toggle quote (10 lines)> > I'm currently rebuilding IceCat with this change as an extra> > precaution, but that shouldn't take long.  If that doesn't cause > > problems this LGTM for master.> > OK, it worked, old IceCat writes new SQlite files.> > Kind regards,> > T G-R

Thank you both for the review!
Pushed as 6e7ba45357078b31a369b23f8a9f38302dfcbb10!

Closed

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date