[PATCH] guix import: Fixing detection of Fortran files.

DoneSubmitted by Mădălin Ionel Patrașcu.
Details
2 participants
  • Mădălin Ionel Patrașcu
  • Ricardo Wurmus
Owner
unassigned
Severity
normal
M
M
Mădălin Ionel Patrașcu wrote on 23 Feb 12:00 +0100
(address . guix-patches@gnu.org)
20210223110021.10765-1-madalinionel.patrascu@mdc-berlin.de
This fixes a bug whereby Guix importer considers files like .f.*being Fortran's files.
(find-files dir "\\.f(90|95)?")
would consider a lot of files with an extension starting with fbeing a Fortran file. The right way is to consider only filesending with .f90 or .f95.
*guix/import/cran.scm: changing pattern of the detection forFortran's files to .f(90|95)$.
Co-authored-by: Ricardo Wurmus <rekado@elephly.net>--- guix/import/cran.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Toggle diff (15 lines)diff --git a/guix/import/cran.scm b/guix/import/cran.scmindex e8caf080fd..dbc858cb84 100644--- a/guix/import/cran.scm+++ b/guix/import/cran.scm@@ -361,7 +361,7 @@ empty list when the FIELD cannot be found." (define (directory-needs-fortran? dir) "Check if the directory DIR contains Fortran source files."- (match (find-files dir "\\.f(90|95)?")+ (match (find-files dir "\\.f(90|95)$") (() #f) (_ #t))) -- 2.30.1
R
R
Ricardo Wurmus wrote 18 hours ago
(name . Mădălin IonelPatrașcu)(address . madalinionel.patrascu@mdc-berlin.de)(address . 46715-done@debbugs.gnu.org)
8735xebl6l.fsf@elephly.net
Hi Mădălin,
Thanks! I applied this with a few changes in the commit message.(Commit 35814292b6.)
-- Ricardo
Closed
?