[PATCH] gnu: mumble: Update to 1.3.4.

OpenSubmitted by jgart.
Details
2 participants
  • jgart
  • Leo Prikler
Owner
unassigned
Severity
normal
J
(address . guix-patches@gnu.org)
039c316d735faa0a21cdacd1a28296cf@dismail.de
Hi Guix,
Raghav Gururajan and I updated mumble to 1.3.4. The patch is attached.
Thank you,
jgart
libremiami.orgsearch.libremiami.org
L
L
Leo Prikler wrote on 22 Feb 17:18 +0100
88fad40b7a501a43517bce0d85509fb271a2026f.camel@student.tugraz.at
Hi jgart and all the others listening from LibreMiami,
Am Montag, den 22.02.2021, 00:59 +0000 schrieb jgart:
Toggle quote (2 lines)> Co-author: jgart <jgart@dismail.de>> Co-author: Raghav Gururajan <rg@raghavgururajan.name>
IIRC, the correct tag would be Co-authored-by.
Toggle quote (1 lines)> * gnu/packages/telephony.scm (mumble): Update to 1.3.4.
This is not enough of a ChangeLog for the changes made here.
Toggle quote (44 lines)> - `(#:tests? #f ; no "check" target> + `(#:tests? #f ; no "check" target
> - "no-oss" ; use pulse> - "no-alsa" ; use pulse> + "no-oss" ; use> pulse> + "no-alsa" ; use> pulse
> - (with-output-to-file "scripts/mumble-overlay"> - (lambda ()> - (format #t "#!~a~%" (which "bash"))> - (format #t "export LD_PRELOAD=\"~a> $LD_PRELOAD\"~%"> - (string-append (assoc-ref outputs "out")> - "/lib/mumble/libmumble.so.1> "))> - (format #t "exec \"${@}\"")))> - #t))> + (with-output-to-file "scripts/mumble-overlay"> + (lambda ()> + (format #t "#!~a~%" (which "bash"))> + (format #t "export LD_PRELOAD=\"~a $LD_PRELOAD\"~%"> + (string-append (assoc-ref outputs "out")> + "/lib/mumble/libmumble.so.1"> ))> + (format #t "exec \"${@}\"")))> + #t))
> - (replace 'install ; install phase does not exist> + (replace 'install ; install phase does not> exist
> - ("mesa" ,mesa) ; avoid bundled> + ("mesa" ,mesa) ; avoid bundled> ("openssl" ,openssl)> - ("opus" ,opus) ; avoid bundled> + ("opus" ,opus) ; avoid bundled
> - ("speex" ,speex) ; avoid bundled> - ("speexdsp" ,speexdsp))) ; avoid bundled> + ("speex" ,speex) ; avoid bundled> + ("speexdsp" ,speexdsp))) ; avoid bundled
These lines appear to be noise, some of them definitely are.
Toggle quote (8 lines)> - `(("pkg-config" ,pkg-config)> - ("python" ,python)> - ("qttools" ,qttools)))> + `(("perl" ,perl)> + ("pkg-config" ,pkg-config)> + ("python" ,python-wrapper)> + ("qttools" ,qttools)> + ("ruby" ,ruby)))
Are perl and ruby really required? If so, what for?
Regards,Leo
L
L
Leo Prikler wrote on 22 Feb 20:28 +0100
78b3b851db5f4b2057ef8216697138744822fb2b.camel@student.tugraz.at
Hi jgart,
Am Montag, den 22.02.2021, 19:09 +0000 schrieb jgart:
Toggle quote (11 lines)> Hi Leo,> > > IIRC, the correct tag would be Co-authored-by.> > I attached the updated patch with your suggestions.> > > These lines appear to be noise, some of them definitely are.> > Raghav thinks these might have been introduced by indent.el> > How would you suggest to remove them?
You can select the lines you actually wish to commit through `gitcommit -p` or use any other tool to do the trick (e.g. Magit or gitg). indent.el is a bit of a hammer. If you don't actively edit code, thathas wrong indentation, it's wiser to just indent your portions withEmacs.
Toggle quote (3 lines)> > Are perl and ruby really required? If so, what for?> > They are for the 'patch-shebangs phase.
And why do you care about those shebangs? Are any of those programspatched by that phase run at any point during build?
Regards,Leo
J
2cc84bcd0e2e150ceab659ad818bbb57@dismail.de
Hi Leo,
Toggle quote (2 lines)> IIRC, the correct tag would be Co-authored-by.
I attached the updated patch with your suggestions.
Toggle quote (2 lines)> These lines appear to be noise, some of them definitely are.
Raghav thinks these might have been introduced by indent.el
How would you suggest to remove them?
Toggle quote (2 lines)> Are perl and ruby really required? If so, what for?
They are for the 'patch-shebangs phase.
Thank you for taking the time to review these patches,
jgart
libremiami.orgsearch.libremiami.org



February 22, 2021 11:18 AM, "Leo Prikler" <leo.prikler@student.tugraz.at> wrote:
Toggle quote (71 lines)> Hi jgart and all the others listening from LibreMiami,> > Am Montag, den 22.02.2021, 00:59 +0000 schrieb jgart:> >> Co-author: jgart <jgart@dismail.de>>> Co-author: Raghav Gururajan <rg@raghavgururajan.name>> > >> * gnu/packages/telephony.scm (mumble): Update to 1.3.4.> > This is not enough of a ChangeLog for the changes made here.> >> - `(#:tests? #f ; no "check" target>> + `(#:tests? #f ; no "check" target>> >> - "no-oss" ; use pulse>> - "no-alsa" ; use pulse>> + "no-oss" ; use>> pulse>> + "no-alsa" ; use>> pulse>> >> - (with-output-to-file "scripts/mumble-overlay">> - (lambda ()>> - (format #t "#!~a~%" (which "bash"))>> - (format #t "export LD_PRELOAD=\"~a>> $LD_PRELOAD\"~%">> - (string-append (assoc-ref outputs "out")>> - "/lib/mumble/libmumble.so.1>> "))>> - (format #t "exec \"${@}\"")))>> - #t))>> + (with-output-to-file "scripts/mumble-overlay">> + (lambda ()>> + (format #t "#!~a~%" (which "bash"))>> + (format #t "export LD_PRELOAD=\"~a $LD_PRELOAD\"~%">> + (string-append (assoc-ref outputs "out")>> + "/lib/mumble/libmumble.so.1">> ))>> + (format #t "exec \"${@}\"")))>> + #t))>> >> - (replace 'install ; install phase does not exist>> + (replace 'install ; install phase does not>> exist>> >> - ("mesa" ,mesa) ; avoid bundled>> + ("mesa" ,mesa) ; avoid bundled>> ("openssl" ,openssl)>> - ("opus" ,opus) ; avoid bundled>> + ("opus" ,opus) ; avoid bundled>> >> - ("speex" ,speex) ; avoid bundled>> - ("speexdsp" ,speexdsp))) ; avoid bundled>> + ("speex" ,speex) ; avoid bundled>> + ("speexdsp" ,speexdsp))) ; avoid bundled> > These lines appear to be noise, some of them definitely are.> >> - `(("pkg-config" ,pkg-config)>> - ("python" ,python)>> - ("qttools" ,qttools)))>> + `(("perl" ,perl)>> + ("pkg-config" ,pkg-config)>> + ("python" ,python-wrapper)>> + ("qttools" ,qttools)>> + ("ruby" ,ruby)))> > > Regards,> Leo
?