gnu: cvassistant: Change build-system.

  • Done
  • quality assurance status badge
Details
3 participants
  • ???
  • Ludovic Courtès
  • Raghav Gururajan
Owner
unassigned
Submitted by
Raghav Gururajan
Severity
normal
R
R
Raghav Gururajan wrote on 11 Feb 2021 12:00
(address . guix-patches@gnu.org)
234730e1-e1bb-f95a-bbf6-5ec90957abad@raghavgururajan.name

From 5f7745b1bd3bc3617fcb0d1120c69616ce167d98 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <rg@raghavgururajan.name>
Date: Thu, 11 Feb 2021 05:57:59 -0500
Subject: [PATCH] gnu: cvassistant: Change build-system.

* gnu/packages/cvassistant.scm (cvassistant) [build-system]: Change from gnu to qt.
---
gnu/packages/cvassistant.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/cvassistant.scm b/gnu/packages/cvassistant.scm
index f57806d734..951f37e740 100644
--- a/gnu/packages/cvassistant.scm
+++ b/gnu/packages/cvassistant.scm
@@ -20,7 +20,7 @@
(define-module (gnu packages cvassistant)
#:use-module (guix packages)
#:use-module (guix download)
- #:use-module (guix build-system gnu)
+ #:use-module (guix build-system qt)
#:use-module ((guix licenses) #:prefix license:)
#:use-module (gnu packages qt)
#:use-module (gnu packages compression))
@@ -36,7 +36,7 @@
(sha256
(base32
"1y2680bazyiwm50gdhdd4982ckbjscrkbw2mngyk7yw708iadvr7"))))
- (build-system gnu-build-system)
+ (build-system qt-build-system)
(arguments
`(#:phases
(modify-phases %standard-phases
--
2.30.0
Attachment: OpenPGP_signature
?
?
??? wrote on 11 Feb 2021 12:36
(name . Raghav Gururajan)(address . rg@raghavgururajan.name)(address . 46437@debbugs.gnu.org)
OSZP286MB0664E66F4D0B4B9701A41BC7A38C9@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM
Raghav Gururajan <rg@raghavgururajan.name> writes:

Toggle quote (8 lines)
> Subject: [PATCH] gnu: cvassistant: Change build-system.
> [...]
> - (build-system gnu-build-system)
> + (build-system qt-build-system)
> (arguments
> `(#:phases
> (modify-phases %standard-phases

Hello, I think the only difference here is that 'qt-build-system' will
wrap the binary with 'QT_PLUGIN_PATH', but if a package only use
'qtbase' it works fine without 'QT_PLUGIN_PATH. So this patch (also you
need to disable tests when use qt-build-system) is not needed?

Thank you!
R
R
Raghav Gururajan wrote on 11 Feb 2021 12:37
(name . ???)(address . iyzsong@outlook.com)(address . 46437@debbugs.gnu.org)
499fce8e-ddce-2117-d605-b8093a54348d@raghavgururajan.name
Toggle quote (5 lines)
> Hello, I think the only difference here is that 'qt-build-system' will
> wrap the binary with 'QT_PLUGIN_PATH', but if a package only use
> 'qtbase' it works fine without 'QT_PLUGIN_PATH. So this patch (also you
> need to disable tests when use qt-build-system) is not needed?

Ah cool then, I will close it. :-)

Regards,
RG.
Attachment: OpenPGP_0x5F5816647F8BE551.asc
Attachment: OpenPGP_signature
L
L
Ludovic Courtès wrote on 17 Mar 2021 22:37
control message for bug #46437
(address . control@debbugs.gnu.org)
878s6lxy0q.fsf@gnu.org
tags 46437 fixed
close 46437
quit
?