[PATCH 0/1] gnu: guile-redis: Update to 2.0.0.

  • Done
  • quality assurance status badge
Details
3 participants
  • Efraim Flashner
  • Ludovic Courtès
  • BonfaceKilz
Owner
unassigned
Submitted by
BonfaceKilz
Severity
normal
Merged with
B
B
BonfaceKilz wrote on 18 Jan 2021 23:39
(address . guix-patches@gnu.org)
20210118223926.184363-1-me@bonfacemunyoki.com
Hi! Find attached an update to guile-redis that adds proper support for Redis
Pub/Sub.

BonfaceKilz (1):
gnu: guile-redis: Update to 2.0.0.

gnu/packages/guile-xyz.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

--
2.29.2
L
L
Ludovic Courtès wrote on 19 Jan 2021 15:59
control message for bug #45977
(address . control@debbugs.gnu.org)
878s8pht08.fsf@gnu.org
merge 45977 45976
quit
E
E
Efraim Flashner wrote on 19 Jan 2021 20:26
Re: [bug#45977] [PATCH 0/1] gnu: guile-redis: Update to 2.0.0.
(name . BonfaceKilz)(address . me@bonfacemunyoki.com)(address . 45977@debbugs.gnu.org)
YAcyViXJdogyaDvI@3900XT
On Tue, Jan 19, 2021 at 01:39:25AM +0300, BonfaceKilz wrote:
Toggle quote (10 lines)
> Hi! Find attached an update to guile-redis that adds proper support for Redis
> Pub/Sub.
>
> BonfaceKilz (1):
> gnu: guile-redis: Update to 2.0.0.
>
> gnu/packages/guile-xyz.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>

This update breaks guile2.0-redis. The configure script still checks for
2.0 so I'm not sure if that's intentional. Can you look into it?

Alternatively, I'm not seeing guile2.0-redis used by any packages in
guix, but I'm not sure about just dropping it.

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmAHMlUACgkQQarn3Mo9
g1GiLA//WGnxJ1C8SNqRNeHrgKIZyPFXE6eQDW4Bv889nPKAFTJvfKpG94+UkP+z
Nj7+2M6zozZMwMVdoFBGsj05JsuBG/isqkBFmWrlPPQ2LbZYmtOfJcR7Bpqn1KAh
aThRqz1H8ws0Tbn9J150TTxJllk9RkWPIutIveayBDoRGciRtVF0MOmxtOw17E2k
DDpEsLKimvKZJh3e71y5zhBNtp5mZ/LVhNrS63bqPcbXVs+ugER+xgKKp/O90Lht
Fty7b64Czkb8WoizGp8S5Jvn59zdE72tAvI/IXrlHLx6AN/w7nz9JOh4dMqnEh93
l1Wjmne+neW+uOy5KVGNXWCTWFMdzfMYZi8wOUGpWknGJ2Pzx8Ujrs5UJmbYCu3h
eqhTwh/ZPFRu6G6tPF0TVUJsl7aBNzVxNE/BtTYAD/TCIAKm1abTuyh8Yjm6BWvO
AK+EtODAtX7HSWJNE5JLOPuWNOU6d1L9J7QmFa2gq3BN817qY0jQCXJXiF3MmDIt
o2oPVBXdj8MyrW54ZEkBubuS7G2KUg5gI3udxawOk1S6hjUGRyjDryoQP8anRjak
M3wKPZknJ6YNgtRu2lP9fhzW7Bi8I5x3/5YWfDMgEhEnEM2FOjeCY6Dc7Qv7OgrR
+kfSokf/UUzzn2nnX0OaLgJGIw+z4Nt7IVjn65lLoQV1HzWzdeg=
=v9D/
-----END PGP SIGNATURE-----


B
B
Bonface Munyoki K. wrote on 20 Jan 2021 07:47
(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 45977@debbugs.gnu.org)
86eeigds07.fsf@bonfacemunyoki.com
Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (15 lines)
> On Tue, Jan 19, 2021 at 01:39:25AM +0300, BonfaceKilz wrote:
>> Hi! Find attached an update to guile-redis that adds proper support for Redis
>> Pub/Sub.
>>
>> BonfaceKilz (1):
>> gnu: guile-redis: Update to 2.0.0.
>>
>> gnu/packages/guile-xyz.scm | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>
> This update breaks guile2.0-redis. The configure script still checks for
> 2.0 so I'm not sure if that's intentional. Can you look into it?
>

Yep. Let me dig into it.

Toggle quote (3 lines)
> Alternatively, I'm not seeing guile2.0-redis used by any packages in
> guix, but I'm not sure about just dropping it.

Let's not drop it just yet...
--
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Humble GNU Emacs User / Bearer of scheme-y parens
Curator: https://upbookclub.com / Twitter: @BonfaceKilz
-----BEGIN PGP SIGNATURE-----

iQJKBAEBCAA0FiEE1PCesRAXfgPCji/h9buuHgOSJT8FAmAH0fwWHG1lQGJvbmZh
Y2VtdW55b2tpLmNvbQAKCRD1u64eA5IlP6/ED/0fO5qARo5kUCYDracRPBqN+hO4
EyVSD6gn5dcDT2dgZxNODXc6RTkjR8e9qBCaXeAXLA2Olb2MdAi3VL6RD9NZXl81
VnXxcPylk1yiAOFqdallxayGrUIIa6SWTiPkSB7rH5t9l7uKAT3tAYdy3DvzF7xH
NG+4Rvsr2tQcRJiseJfMoohjV1xVdV+q5vZ2iQ4m2m7xE3TLFuqgPjlLB4lJBCLU
ooyDla2bpHB2/eJf801/+rq+0B27TEI+ciEtej6OX2NxR8J2AafFokhgV8igiDr6
9ZbQrFwFyUGFTu+GoBm+UVzSX/ACbF/yiTggnLOeUrO271VOejp/qdUFM5oxR+Hz
zYj1fbjrqqTPNqadqHj9GbqV7tTtEWbEpRxgqM2g8SkkaiewWjaxbumrUdnBoZuY
t0FGIArCHT/ona1+GkHoshZpSh6rxOLMslVeG/1c82MSNNAkmIC2IpNw/SXbhO0V
ZiAUEnXdyxNh7mr4tc4wrYX9Fv0F4ZgVPFAHLYE7axfIGugxBLovx2Jh794AK1/Z
E0T2Ko22FB19Iocjx5+dhbMqmXeqr6qL7MbNXa928UxYgreHYF7riyiJZ6FB7nSB
BbhxPuscyP+/H5E/n5sQDSsSUc+iNS333tA4PcjTPEHWLqPmDSP6drpFSYHP7cz5
M9VEfnVfJtEWQLn3Yw==
=oM8b
-----END PGP SIGNATURE-----

B
B
BonfaceKilz wrote on 26 Jan 2021 11:42
[PATCH v2 0/2] gnu: guile-redis: Update to 2.0.0.
(address . 45977@debbugs.gnu.org)
20210126104233.21674-1-me@bonfacemunyoki.com
Hi! For this patch, I've downgraded guile2.0-redis back to 1.3.0. The problem
with with trying to build v2.0.0 on guile2.0 is that libs like (ice-9
textual-ports) were not yet present; but are used in v2.0 of
guile-redis. Here's what I have when I get into a guile2.0 repl:

#+begin_src
? guix git:(master) ? guix environment -C --ad-hoc guile@2.0.14 -- guile
The following derivation will be built:
/gnu/store/f6pxq82f7ifzxmlaba72x0mn9rqfdf8b-profile.drv
The following profile hooks will be built:
/gnu/store/3ghqadnzhddgcf8nljfzjrkyzvizn61m-manual-database.drv
/gnu/store/4p7wnbk6bh9g6q1wlb48zmf09rlnwdxl-info-dir.drv
/gnu/store/4q08ispks919baxrvp5g7wyipn1n98lc-fonts-dir.drv
/gnu/store/f15hk17knzla3wzhmfyx61lwih1g5mjq-ca-certificate-bundle.drv
building CA certificate bundle...
building fonts directory...
building directory of Info manuals...
building database for manual pages...
building profile with 1 package...
GNU Guile 2.0.14
Copyright (C) 1995-2016 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> ,use (ice-9 textual-ports)
While executing meta-command:
ERROR: no code for module (ice-9 textual-ports)
scheme@(guile-user)>
#+end_src

In this patch set, I've downgraded the guile2.0-redis version to 1.3.0.

BonfaceKilz (2):
gnu: guile-redis: Update to 2.0.0.
gnu: guile2.0-redis: Revert to 1.3.0.

gnu/packages/guile-xyz.scm | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)

--
2.29.2
B
B
BonfaceKilz wrote on 26 Jan 2021 11:42
[PATCH v2 1/2] gnu: guile-redis: Update to 2.0.0.
(address . 45977@debbugs.gnu.org)
20210126104233.21674-2-me@bonfacemunyoki.com
* gnu/packages/guile-xyz.scm (guile-redis): Update to 2.0.0.
---
gnu/packages/guile-xyz.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Toggle diff (32 lines)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index c2d853f006..ac260c804b 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -33,6 +33,7 @@
;;; Copyright © 2020 Mike Rosset <mike.rosset@gmail.com>
;;; Copyright © 2020 Leo Prikler <leo.prikler@student.tugraz.at>
;;; Copyright © 2020 pukkamustard <pukkamustard@posteo.net>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2430,7 +2431,7 @@ interface for reading articles in any format.")
(define-public guile-redis
(package
(name "guile-redis")
- (version "1.3.0")
+ (version "2.0.0")
(home-page "https://github.com/aconchillo/guile-redis")
(source (origin
(method git-fetch)
@@ -2440,7 +2441,7 @@ interface for reading articles in any format.")
(file-name (git-file-name name version))
(sha256
(base32
- "14izs8daxh7pb7vwpxi5g427qa31137jkaxrb1cy5rpjkwchy723"))))
+ "1zk2x37lw6ygf7rwy71svnsian8lj51axpxmm66ah7dazn69swlm"))))
(build-system gnu-build-system)
(native-inputs
`(("autoconf" ,autoconf)
--
2.29.2
B
B
BonfaceKilz wrote on 26 Jan 2021 11:42
[PATCH v2 2/2] gnu: guile2.0-redis: Revert to 1.3.0.
(address . 45977@debbugs.gnu.org)
20210126104233.21674-3-me@bonfacemunyoki.com
`(ice-9 textual-ports)` is not present in guile 2.0.x thereby breaking the
build.
---
gnu/packages/guile-xyz.scm | 10 ++++++++++
1 file changed, 10 insertions(+)

Toggle diff (24 lines)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index ac260c804b..55551d3b15 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -2464,7 +2464,17 @@ key-value cache and store.")
(define-public guile2.0-redis
(package
(inherit guile-redis)
+ (version "1.3.0")
(name "guile2.0-redis")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/aconchillo/guile-redis")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "14izs8daxh7pb7vwpxi5g427qa31137jkaxrb1cy5rpjkwchy723"))))
(native-inputs `(("guile" ,guile-2.0)
,@(alist-delete "guile"
(package-native-inputs guile-redis))))))
--
2.29.2
E
E
Efraim Flashner wrote on 27 Jan 2021 10:21
Re: [PATCH v2 0/2] gnu: guile-redis: Update to 2.0.0.
(name . BonfaceKilz)(address . me@bonfacemunyoki.com)(address . 45977-done@debbugs.gnu.org)
YBEwoYrSJ9ELVn2i@3900XT
On Tue, Jan 26, 2021 at 01:42:31PM +0300, BonfaceKilz wrote:
Toggle quote (5 lines)
> Hi! For this patch, I've downgraded guile2.0-redis back to 1.3.0. The problem
> with with trying to build v2.0.0 on guile2.0 is that libs like (ice-9
> textual-ports) were not yet present; but are used in v2.0 of
> guile-redis. Here's what I have when I get into a guile2.0 repl:

I dug into it a bit more and it looks like (redis utils) imports (ice-9
textual-imports) only for the put-string function. If I remove the
import then guile2.0-redis compiles just fine, but I wasn't sure if
there was a good test for it.

(ins)efraim@3900XT ~$ guix environment --ad-hoc guile@2.0 -- guile
;;; WARNING: loading compiled file /home/efraim/.guix-profile/lib/guile/3.0/site-ccache/ice-9/readline.go failed:
;;; ERROR: In procedure make_objcode_from_file: bad header on object file: "\x7fELF\x02\x01\x01?\x00\x00\x00\x00\x00\x00\x00\x00"
;;; WARNING: loading compiled file /run/current-system/profile/lib/guile/3.0/site-ccache/ice-9/readline.go failed:
;;; ERROR: In procedure make_objcode_from_file: bad header on object file: "\x7fELF\x02\x01\x01?\x00\x00\x00\x00\x00\x00\x00\x00"
Consider installing the 'guile-readline' package for
convenient interactive line editing and input history.

;;; WARNING: loading compiled file /home/efraim/.guix-profile/lib/guile/3.0/site-ccache/ice-9/colorized.go failed:
;;; ERROR: In procedure make_objcode_from_file: bad header on object file: "\x7fELF\x02\x01\x01?\x00\x00\x00\x00\x00\x00\x00\x00"
;;; WARNING: loading compiled file /run/current-system/profile/lib/guile/3.0/site-ccache/ice-9/colorized.go failed:
;;; ERROR: In procedure make_objcode_from_file: bad header on object file: "\x7fELF\x02\x01\x01?\x00\x00\x00\x00\x00\x00\x00\x00"
GNU Guile 2.0.14
Copyright (C) 1995-2016 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> (put-string "abcde" %current-output-port)
;;; <stdin>:1:0: warning: possibly unbound variable `put-string'
;;; <stdin>:1:0: warning: possibly unbound variable `%current-output-port'
<unnamed port>:1:0: In procedure #<procedure 7ff4222f48e0 at <current input>:1:0 ()>:
<unnamed port>:1:0: In procedure module-lookup: Unbound variable: put-string

Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue.
scheme@(guile-user) [1]> ,q
scheme@(guile-user)> (use-modules (rnrs io ports))
scheme@(guile-user)> (put-string "abcde" %current-output-port)
;;; <stdin>:4:0: warning: possibly unbound variable `%current-output-port'
<unnamed port>:4:12: In procedure #<procedure 7ff422266160 at <current input>:4:0 ()>:
<unnamed port>:4:12: In procedure module-lookup: Unbound variable: %current-output-port

Entering a new prompt. Type `,bt' for a backtrace or `,q' to continue.

Ignoring the errors about %current-output-port, in guile2.0 put-string
is in (rnrs io ports), so it looks like it's safe to substitute (ice-9
textual-ports) for (rnrs io ports) in guile2.0-redis. So I made that
change and dropped your second patch. If someone mentions that
guile2.0-redis@2.0.0 is broken we can revisit :)

Toggle quote (41 lines)
> #+begin_src
> ? guix git:(master) ? guix environment -C --ad-hoc guile@2.0.14 -- guile
> The following derivation will be built:
> /gnu/store/f6pxq82f7ifzxmlaba72x0mn9rqfdf8b-profile.drv
> The following profile hooks will be built:
> /gnu/store/3ghqadnzhddgcf8nljfzjrkyzvizn61m-manual-database.drv
> /gnu/store/4p7wnbk6bh9g6q1wlb48zmf09rlnwdxl-info-dir.drv
> /gnu/store/4q08ispks919baxrvp5g7wyipn1n98lc-fonts-dir.drv
> /gnu/store/f15hk17knzla3wzhmfyx61lwih1g5mjq-ca-certificate-bundle.drv
> building CA certificate bundle...
> building fonts directory...
> building directory of Info manuals...
> building database for manual pages...
> building profile with 1 package...
> GNU Guile 2.0.14
> Copyright (C) 1995-2016 Free Software Foundation, Inc.
>
> Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
> This program is free software, and you are welcome to redistribute it
> under certain conditions; type `,show c' for details.
>
> Enter `,help' for help.
> scheme@(guile-user)> ,use (ice-9 textual-ports)
> While executing meta-command:
> ERROR: no code for module (ice-9 textual-ports)
> scheme@(guile-user)>
> #+end_src
>
> In this patch set, I've downgraded the guile2.0-redis version to 1.3.0.
>
> BonfaceKilz (2):
> gnu: guile-redis: Update to 2.0.0.
> gnu: guile2.0-redis: Revert to 1.3.0.
>
> gnu/packages/guile-xyz.scm | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> --
> 2.29.2
>

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmARMKEACgkQQarn3Mo9
g1GO9Q//WBoA8VRDCdf1dzSHUFTGBLJimydegFT+Y37GhqjP2lHhALKDsNgiKGPR
JpUKoiPjbXCeVFSFTQRqm9rsdNr9f9xAHRj1pRAe7ykHVpnXytm5LXwBUoFQ2Hz8
tQqSsQEzZ4sOuF5YH/tqUMg865KDy6E8rpvit4EvqNd+IbZg+pvo+hC8ihNsKk8F
/IzgyAKaJ+ty6SD5yC3lCYYlpdzuHAZbH35p0msw+TYepq4dQlEaeCSyVekPjML/
HNlJ01W4/qSRvzu52X5PSsX17UmM0a7ka4Ft9ZDmADaT+DbOIuiL8MKqFuIFlyGf
McgHbks6OjFRsx7ewlb2A3BKrFb41xSksPvklj83N2NZbVGmXmQDzLjmsHyIVoJ1
kFkb9O1ZmP0fqms9yQhZbP0t4OuhMMzHwWW3jhRjgyJG6SwCdlLs/bWUsKmJWay5
9cBU7eYJO0zBWhAZ5GjHnHXuyvNp3DbeuLnQYug7kpYLc1ahLyfMMRl3zpJQzTU2
9KdzIol1ZeZiwIHIcjYcnMGnNWFh/7qpnOKzcvP/m4Hy2kOup8O3lMc4djED1lY/
yl3R9VIpEXgH1yabMHCZPUTkYhJRzZLfkSn8M6mJyjeHpXgDxg1Tsu8UmbKtTq3+
lo+BMQsWQuGa07uc5xaT5zJDrP38T+kbDDdTG7fjL+MNioTmJQE=
=u7Lh
-----END PGP SIGNATURE-----


Closed
B
B
Bonface Munyoki K. wrote on 27 Jan 2021 10:40
(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 45977-done@debbugs.gnu.org)
86wnvywwds.fsf@bonfacemunyoki.com
Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (14 lines)
> On Tue, Jan 26, 2021 at 01:42:31PM +0300, BonfaceKilz wrote:
>> Hi! For this patch, I've downgraded
>> guile2.0-redis back to 1.3.0. The problem
>> with with trying to build v2.0.0 on guile2.0 is
>> that libs like (ice-9
>> textual-ports) were not yet present; but are used in v2.0 of
>> guile-redis. Here's what I have when I get into a guile2.0 repl:
>
> I dug into it a bit more and it looks like (redis
> utils) imports (ice-9
> textual-imports) only for the put-string function. If I remove the
> import then guile2.0-redis compiles just fine, but I wasn't sure if
> there was a good test for it.

Thanks!

[...]

--
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Humble GNU Emacs User / Bearer of scheme-y parens
Curator: https://upbookclub.com / Twitter: @BonfaceKilz
-----BEGIN PGP SIGNATURE-----

iQJKBAEBCAA0FiEE1PCesRAXfgPCji/h9buuHgOSJT8FAmARNRQWHG1lQGJvbmZh
Y2VtdW55b2tpLmNvbQAKCRD1u64eA5IlP02EEACDxzbycFjZXiElZJRQ6YJqbINO
HwA/+UVaDK0OzsDYae4creyOYS6o6hhy3dm+fhlVNYwOUH7woSZnNJk8nWhSUjep
A8XP4Q/iyU7I5M5SAKzWM9xnLpkWdXKQrtux91xZfC2SBphmIyzm4LPBGLcJIQx4
pLya73Z+4jNyYub6FdPy0adDa53rYuL5UZfS7y5t82jIMHKxOkemjJkMO9vpYPBZ
RjqwbC4j3HJ4UT3KEy0gicPPJ1BxyA/4xZ0NCcQ7lqrDfQiQiYx8KGe+t9zezM53
n/vzTU+hoNEdM2hXAUlTh3A/swPCX+L9jKibC7OiS0PneAkQ+egdca9GU9KLiMG3
mnFxH/sK5mH4va3qOzJ5R2tTDAYm3RqJMbIfsjEmdCz9n0qojOCjhmaIl7DCMnxI
Z0bxzQdsEUZzQGRoUCatBKiQsLp++8L9NAkq12+VofYeTHn/8qY3VMIV6Gl+rd11
iwJVvZ3xd5QKqfG3Cbi7/Xj/JdJX8FWYbO6qQ3mSlkPvhJLQUNjOBFNrG0+jUFak
XUB0N5/dMeV7/2jjCCme01YvLfXx4s9v1BT2EORuG6NfAE9iawrBj7Hknl3Mhq6s
XiILJ7j4MQ3lMioRJaZDRFtcdEntlf/0AyyLXtHAvW3ylXa/ID+Z9YBaNd9JCeBV
OW07bA5iDR1JzJursA==
=awTw
-----END PGP SIGNATURE-----

Closed
?