[PATCH] gnu: Add skim.

  • Done
  • quality assurance status badge
Details
3 participants
  • Z572
  • John Soo
  • Nicolas Goaziou
Owner
unassigned
Submitted by
Z572
Severity
normal
Z
Z
Z572 wrote on 17 Dec 2020 14:10
(address . guix-patches@gnu.org)
tencent_BA1F90CE42B94789466DCEA64A6A5E56CB06@qq.com
From 73ff533214c54fe65ba7b7a20fd6c6bed302a52c Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Thu, 17 Dec 2020 21:00:52 +0800
Subject: [PATCH 1/6] gnu: Add rust-tuikit-0.4.

---
gnu/packages/crates-io.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)

Toggle diff (48 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index f42816d47d..57751cc772 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -12,6 +12,7 @@
;;; Copyright © 2020 André Batista <nandre@riseup.net>
;;; Copyright © 2020 Arun Isaac <arunisaac@systemreboot.net>
;;; Copyright © 2020 Antoine Côté <antoine.cote@posteo.net>
+;;; Copyright © 2020 Zheng Junjie <873216071@qq.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -35889,3 +35890,33 @@ formatters with per-field documentation generated for each structure.
(description
"Generate Rust register maps (`struct`s) from SVD files")
(license (list license:expat license:asl2.0))))
+
+(define-public rust-tuikit-0.4
+ (package
+ (name "rust-tuikit")
+ (version "0.4.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "tuikit" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "01x99x184k3p3knbzvr263has5rhpgkv81ijiqa8aqm1fl2azzfz"))))
+ (build-system cargo-build-system)
+ (arguments
+ `(#:skip-build?
+ #t
+ #:cargo-inputs
+ (("rust-bitflags" ,rust-bitflags-1)
+ ("rust-lazy-static" ,rust-lazy-static-1)
+ ("rust-log" ,rust-log-0.4)
+ ("rust-nix" ,rust-nix-0.14)
+ ("rust-term" ,rust-term-0.6)
+ ("rust-unicode-width" ,rust-unicode-width-0.1))))
+ (home-page "https://github.com/lotabout/tuikit")
+ (synopsis "Toolkit for writing TUI applications")
+ (description
+ "Toolkit for writing TUI applications")
+ (license license:expat)))
--
2.29.2
From 404cc212db56de26f81d3a30f9426a1b5c224236 Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Thu, 17 Dec 2020 21:01:15 +0800
Subject: [PATCH 2/6] gnu: Add rust-timer-0.2.

---
gnu/packages/crates-io.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

Toggle diff (36 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 57751cc772..b9cb436935 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -35920,3 +35920,29 @@ formatters with per-field documentation generated for each structure.
(description
"Toolkit for writing TUI applications")
(license license:expat)))
+
+(define-public rust-timer-0.2
+ (package
+ (name "rust-timer")
+ (version "0.2.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "timer" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0srhqyp7fr91d1i43aqs7wc6yn1i3kdkh1pm05bicdw961v23m1i"))))
+ (build-system cargo-build-system)
+ (arguments
+ `(#:skip-build?
+ #t
+ #:cargo-inputs
+ (("rust-chrono" ,rust-chrono-0.4))))
+ (home-page "https://github.com/Yoric/timer.rs")
+ (synopsis
+ "A simple timer. Use it to schedule execution of closures after a delay or at a given timestamp.")
+ (description
+ "This package provides a simple timer. Use it to schedule execution of closures after a delay or at a given timestamp.")
+ (license license:mpl2.0)))
--
2.29.2
From 251e1e0c8c753ccd7d9c05c1699b8f37fa694969 Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Thu, 17 Dec 2020 21:02:22 +0800
Subject: [PATCH 3/6] gnu: Add rust-fuzzy-matcher-0.3

---
gnu/packages/crates-io.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)

Toggle diff (35 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index b9cb436935..dc7d38530b 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -35946,3 +35946,28 @@ formatters with per-field documentation generated for each structure.
(description
"This package provides a simple timer. Use it to schedule execution of closures after a delay or at a given timestamp.")
(license license:mpl2.0)))
+
+(define-public rust-fuzzy-matcher-0.3
+ (package
+ (name "rust-fuzzy-matcher")
+ (version "0.3.7")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "fuzzy-matcher" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "153csv8rsk2vxagb68kpmiknvdd3bzqj03x805khckck28rllqal"))))
+ (build-system cargo-build-system)
+ (arguments
+ `(#:skip-build?
+ #t
+ #:cargo-inputs
+ (("rust-thread-local" ,rust-thread-local-1.0))))
+ (home-page
+ "https://github.com/lotabout/fuzzy-matcher")
+ (synopsis "Fuzzy Matching Library")
+ (description "Fuzzy Matching Library")
+ (license license:expat)))
--
2.29.2
From 6320df9034b5dda9e5c75f077ceebdb444a5518f Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Thu, 17 Dec 2020 21:02:58 +0800
Subject: [PATCH 4/6] gnu: Add rust-defer-drop-1.

---
gnu/packages/crates-io.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

Toggle diff (38 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index dc7d38530b..aa91f7c1aa 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -35971,3 +35971,31 @@ formatters with per-field documentation generated for each structure.
(synopsis "Fuzzy Matching Library")
(description "Fuzzy Matching Library")
(license license:expat)))
+
+(define-public rust-defer-drop-1
+ (package
+ (name "rust-defer-drop")
+ (version "1.0.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "defer-drop" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1d3pmmn5k2ir3yv8z8fnv4jprs5aijkz5pbdyl8x8kp18m90bbhq"))))
+ (build-system cargo-build-system)
+ (arguments
+ `(#:skip-build?
+ #t
+ #:cargo-inputs
+ (("rust-crossbeam-channel"
+ ,rust-crossbeam-channel-0.4)
+ ("rust-once-cell" ,rust-once-cell-1))))
+ (home-page "")
+ (synopsis
+ "Defer dropping large types to a background thread")
+ (description
+ "Defer dropping large types to a background thread")
+ (license license:mpl2.0)))
--
2.29.2
From b6df1554b77913dba0990beea7d9141f896f0e82 Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Thu, 17 Dec 2020 21:03:18 +0800
Subject: [PATCH 5/6] gnu: Add rust-beef-0.4.

---
gnu/packages/crates-io.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

Toggle diff (34 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index aa91f7c1aa..95d274e79a 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -35999,3 +35999,27 @@ formatters with per-field documentation generated for each structure.
(description
"Defer dropping large types to a background thread")
(license license:mpl2.0)))
+
+(define-public rust-beef-0.4
+ (package
+ (name "rust-beef")
+ (version "0.4.4")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "beef" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0hva1rmbx2a54q4ncs8i5lbr26669wyvnya1sh3x22r0cxm64jj7"))))
+ (build-system cargo-build-system)
+ (arguments
+ `(#:skip-build?
+ #t
+ #:cargo-inputs
+ (("rust-serde" ,rust-serde-1))))
+ (home-page "")
+ (synopsis "More compact Cow")
+ (description "More compact Cow")
+ (license (list license:expat license:asl2.0))))
--
2.29.2
From 42d30ecae2a16f6dfdd65f99e1eb936520811827 Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Thu, 17 Dec 2020 21:03:39 +0800
Subject: [PATCH 6/6] gnu: Add skim.

---
gnu/packages/rust-apps.scm | 42 ++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)

Toggle diff (62 lines)
diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm
index c3d1d3bb26..a5228b1576 100644
--- a/gnu/packages/rust-apps.scm
+++ b/gnu/packages/rust-apps.scm
@@ -7,6 +7,7 @@
;;; Copyright © 2020 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2020 Gabriel Arazas <foo.dogsquared@gmail.com>
;;; Copyright © 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
+;;; Copyright © 2020 Zheng Junjie <873216071@qq.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -401,6 +402,47 @@ gitignore rules.")
(base32
"13jzbmjz1bmmfr0i80hw6ar484mgabx3hbpb2ynhk0ddqi0yr58m"))))))
+(define-public skim
+ (package
+ (name "skim")
+ (version "0.9.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "skim" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0qir6m4cpd63bnp0lqq4si1ccgd6rbv4m1662v771fkyynrdrj0s"))))
+ (build-system cargo-build-system)
+ (arguments
+ `(#:cargo-inputs
+ (("rust-beef" ,rust-beef-0.4)
+ ("rust-bitflags" ,rust-bitflags-1)
+ ("rust-chrono" ,rust-chrono-0.4)
+ ("rust-clap" ,rust-clap-2)
+ ("rust-crossbeam" ,rust-crossbeam-0.7)
+ ("rust-defer-drop" ,rust-defer-drop-1)
+ ("rust-derive-builder" ,rust-derive-builder-0.9)
+ ("rust-env-logger" ,rust-env-logger-0.6)
+ ("rust-fuzzy-matcher" ,rust-fuzzy-matcher-0.3)
+ ("rust-lazy-static" ,rust-lazy-static-1)
+ ("rust-log" ,rust-log-0.4)
+ ("rust-nix" ,rust-nix-0.14)
+ ("rust-rayon" ,rust-rayon-1)
+ ("rust-regex" ,rust-regex-1)
+ ("rust-shlex" ,rust-shlex-0.1)
+ ("rust-time" ,rust-time-0.1)
+ ("rust-timer" ,rust-timer-0.2)
+ ("rust-tuikit" ,rust-tuikit-0.4)
+ ("rust-unicode-width" ,rust-unicode-width-0.1)
+ ("rust-vte" ,rust-vte-0.3))))
+ (home-page "https://github.com/lotabout/skim")
+ (synopsis "Fuzzy Finder in rust!")
+ (description "Fuzzy Finder in rust!")
+ (license license:expat)))
+
(define-public tokei
(package
(name "tokei")
--
2.29.2
J
J
John Soo wrote on 24 Jan 2021 19:46
(name . Z572)(address . 873216071@qq.com)(address . 45293@debbugs.gnu.org)
877do2w4uo.fsf@asu.edu
Hello,

I made some patches for skim also. Yours look good but there are some
extras not installed. In particular the manpages, vim plugins and shell
completions are missing. Can you add something like the following to the
#:phases part of the arguments?

(modify-phases %standard-phases
(add-after 'install 'install-extras
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
(bin (string-append out "/bin"))
(share (string-append out "/share"))
(man (string-append out "/share/man"))
(vimfiles (string-append share "/vim/vimfiles/plugin"))
(bash-completion (string-append share "/bash-completions/completions"))
(zsh-site (string-append share "/zsh/site-functions"))
(fish-vendor (string-append share "/fish/vendor-completions.d")))
;; Binaries
(for-each
(lambda (binary) (install-file binary bin))
(find-files "bin"))
(mkdir-p share)
;; Manpages
(copy-recursively "man" man)
;; Vim plugins
(mkdir-p vimfiles)
(copy-recursively "plugin" vimfiles)
;; Completions
(mkdir-p bash-completion)
(copy-file
"shell/completion.bash"
(string-append bash-completion "/skim"))
(copy-file
"shell/key-bindings.bash"
(string-append bash-completion "/skim-bindings"))
(mkdir-p zsh-site)
(copy-file
"shell/completion.zsh"
(string-append zsh-site "/_skim"))
(copy-file
"shell/key-bindings.zsh"
(string-append zsh-site "/_skim-bindings"))
(mkdir-p fish-vendor)
(copy-file
"shell/key-bindings.fish"
(string-append fish-vendor "/skim-bindings.fish"))))))

Thanks!

John
Z
Z
Z572 wrote on 25 Jan 2021 10:21
(name . John Soo)(address . jsoo1@asu.edu)(address . 45293@debbugs.gnu.org)
tencent_3865B5FEA9E9A094AB94B8D45A6C8EA55A0A@qq.com
This is new patch.
From 0cdaab0fcdadd8603641e5d28120e91462323cee Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Mon, 25 Jan 2021 13:21:12 +0800
Subject: [PATCH 1/4] gnu: Add rust-tuikit-0.4.

---
gnu/packages/crates-io.scm | 35 +++++++++++++++++++++++++++++++----
1 file changed, 31 insertions(+), 4 deletions(-)

Toggle diff (78 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 36f0b98112..39b3fb5189 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -12,6 +12,7 @@
;;; Copyright © 2020 André Batista <nandre@riseup.net>
;;; Copyright © 2020 Arun Isaac <arunisaac@systemreboot.net>
;;; Copyright © 2020 Antoine Côté <antoine.cote@posteo.net>
+;;; Copyright @ 2021 Zheng Junjie <873216071@qq.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -38719,10 +38720,10 @@ extension for the Trust-DNS client to use rustls for TLS.")
"Test harness for ui tests of compiler diagnostics.")
(license (list license:expat license:asl2.0))))
-(define-public rust-tuikit-0.2
+(define-public rust-tuikit-0.4
(package
(name "rust-tuikit")
- (version "0.2.9")
+ (version "0.4.3")
(source
(origin
(method url-fetch)
@@ -38731,7 +38732,7 @@ extension for the Trust-DNS client to use rustls for TLS.")
(string-append name "-" version ".tar.gz"))
(sha256
(base32
- "19f3jp12kqcx7aaykxbaj1j17zahd4drv049agpxaminr63w2sw4"))))
+ "1hf6pgclb2lj08jzb45q0mpjq2a9zw27h7kwyi5cibjz5skd054b"))))
(build-system cargo-build-system)
(arguments
`(#:tests? #f ; tests fail in the build environment.
@@ -38740,7 +38741,7 @@ extension for the Trust-DNS client to use rustls for TLS.")
("rust-lazy-static" ,rust-lazy-static-1)
("rust-log" ,rust-log-0.4)
("rust-nix" ,rust-nix-0.14)
- ("rust-term" ,rust-term-0.5)
+ ("rust-term" ,rust-term-0.6)
("rust-unicode-width" ,rust-unicode-width-0.1))
#:cargo-development-inputs
(("rust-env-logger" ,rust-env-logger-0.6))))
@@ -38750,6 +38751,32 @@ extension for the Trust-DNS client to use rustls for TLS.")
"This package provides a toolkit for writing TUI applications in Rust.")
(license license:expat)))
+(define-public rust-tuikit-0.2
+ (package
+ (inherit rust-tuikit-0.4)
+ (name "rust-tuikit")
+ (version "0.2.9")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "tuikit" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "19f3jp12kqcx7aaykxbaj1j17zahd4drv049agpxaminr63w2sw4"))))
+ (arguments
+ `(#:tests? #f ; tests fail in the build environment.
+ #:cargo-inputs
+ (("rust-bitflags" ,rust-bitflags-1)
+ ("rust-lazy-static" ,rust-lazy-static-1)
+ ("rust-log" ,rust-log-0.4)
+ ("rust-nix" ,rust-nix-0.14)
+ ("rust-term" ,rust-term-0.5)
+ ("rust-unicode-width" ,rust-unicode-width-0.1))
+ #:cargo-development-inputs
+ (("rust-env-logger" ,rust-env-logger-0.6))))))
+
(define-public rust-typeable-0.1
(package
(name "rust-typeable")
--
2.30.0
From f7b63404e89889ab2f9a59fc1786744091949812 Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Mon, 25 Jan 2021 13:34:04 +0800
Subject: [PATCH 2/4] gnu: Add rust-defer-drop-1.

---
gnu/packages/crates-io.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

Toggle diff (40 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 39b3fb5189..1357f52c19 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -8815,6 +8815,33 @@ sizes. Big-endian order is used. WARNING: Block must be aligned!")
"Decimal floating point arithmetic for Rust.")
(license license:asl2.0)))
+(define-public rust-defer-drop-1
+ (package
+ (name "rust-defer-drop")
+ (version "1.0.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "defer-drop" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "1d3pmmn5k2ir3yv8z8fnv4jprs5aijkz5pbdyl8x8kp18m90bbhq"))))
+ (build-system cargo-build-system)
+ (arguments
+ `(#:skip-build? #t
+ #:cargo-inputs
+ (("rust-crossbeam-channel"
+ ,rust-crossbeam-channel-0.4)
+ ("rust-once-cell" ,rust-once-cell-1))))
+ (home-page "https://github.com/Lucretiel/defer-drop")
+ (synopsis
+ "Defer dropping large types to a background thread")
+ (description
+ "This package provides a defer dropping large types to a background thread.")
+ (license license:mpl2.0)))
+
(define-public rust-deflate-0.8
(package
(name "rust-deflate")
--
2.30.0
From 3f85f899095a7664b778942f588c0622715c2db4 Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Mon, 25 Jan 2021 13:53:37 +0800
Subject: [PATCH 3/4] gnu: Add rust-beef-0.4.

---
gnu/packages/crates-io.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)

Toggle diff (36 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 1357f52c19..02ba3c1ecb 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -3034,6 +3034,29 @@ c6e7d37. However, this package works only up to 128 bytes.")
(description "This library provides for encoding and decoding any base.")
(license license:expat)))
+(define-public rust-beef-0.4
+ (package
+ (name "rust-beef")
+ (version "0.4.4")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (crate-uri "beef" version))
+ (file-name
+ (string-append name "-" version ".tar.gz"))
+ (sha256
+ (base32
+ "0hva1rmbx2a54q4ncs8i5lbr26669wyvnya1sh3x22r0cxm64jj7"))))
+ (build-system cargo-build-system)
+ (arguments
+ `(#:skip-build? #t
+ #:cargo-inputs
+ (("rust-serde" ,rust-serde-1))))
+ (home-page "https://github.com/maciejhirsz/beef")
+ (synopsis "More compact Cow")
+ (description "This package provides a More compact Cow.")
+ (license (list license:expat license:asl2.0))))
+
(define-public rust-bencher-0.1
(package
(name "rust-bencher")
--
2.30.0
Attachment: 0004-gnu-Add-rust-skim-0.9.patch
J
J
John Soo wrote on 25 Jan 2021 16:10
(name . Z572)(address . 873216071@qq.com)(name . 45293)(address . 45293@debbugs.gnu.org)
d39fc0a7-d6c7-47b2-8887-18ce1aaae56e@Johns-iPhone
Ah! Looks good! One last thing I think you should do is move rust-skim to rust-apps.scm and rename to just skim. You may also want to deprecate the versions called rust-skim.

Thanks again!

John
Attachment: file
Z
Z
Z572 wrote on 25 Jan 2021 17:15
(name . John Soo)(address . jsoo1@asu.edu)(address . 45293@debbugs.gnu.org)
tencent_D7E3AC86BF3F9D94F2969283DAA7CDAFD407@qq.com
Attachment: 0001-gnu-Move-rust-skim-to-rust-apps.patch
From dbf352b787db782786f433a7cc26760cc283e42c Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071@qq.com>
Date: Tue, 26 Jan 2021 00:03:55 +0800
Subject: [PATCH 2/2] gnu: Rename rust-skim to skim.

---
gnu/packages/crates-io.scm | 7 +++++--
gnu/packages/rust-apps.scm | 8 ++++----
2 files changed, 9 insertions(+), 6 deletions(-)

Toggle diff (58 lines)
diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 05d00f5ce6..32d889d11b 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -29874,11 +29874,11 @@ sub-processes using a fork-like interface.")
("rust-memchr" ,rust-memchr-2)
("rust-nix" ,rust-nix-0.18)
("rust-scopeguard" ,rust-scopeguard-1)
- ("rust-skim" ,rust-skim-0.7)
("rust-unicode-segmentation" ,rust-unicode-segmentation-1)
("rust-unicode-width" ,rust-unicode-width-0.1)
("rust-utf8parse" ,rust-utf8parse-0.2)
- ("rust-winapi" ,rust-winapi-0.3))
+ ("rust-winapi" ,rust-winapi-0.3)
+ ("skim" ,skim-0.7))
#:cargo-development-inputs
(("rust-assert-matches" ,rust-assert-matches-1.3)
("rust-doc-comment" ,rust-doc-comment-0.3)
@@ -32726,6 +32726,9 @@ variants in pure Rust.")
"Test your Rust markdown documentation via Cargo.")
(license (list license:expat license:asl2.0))))
+(define-public rust-skim-0.7
+ (deprecated-package "rust-skim-0.7" skim-0.7))
+
(define-public rust-slab-0.4
(package
(name "rust-slab")
diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm
index 24430120ca..f2ab4a0c44 100644
--- a/gnu/packages/rust-apps.scm
+++ b/gnu/packages/rust-apps.scm
@@ -503,9 +503,9 @@ gitignore rules.")
(base32
"13jzbmjz1bmmfr0i80hw6ar484mgabx3hbpb2ynhk0ddqi0yr58m"))))))
-(define-public rust-skim-0.9
+(define-public skim
(package
- (name "rust-skim")
+ (name "skim")
(version "0.9.3")
(source
(origin
@@ -587,9 +587,9 @@ gitignore rules.")
(description "This package provides a fuzzy finder in Rust.")
(license license:expat)))
-(define-public rust-skim-0.7
+(define-public skim-0.7
(package
- (inherit rust-skim-0.9)
+ (inherit skim)
(name "rust-skim")
(version "0.7.0")
(source
--
2.30.0
J
J
John Soo wrote on 25 Jan 2021 17:20
(name . Z572)(address . 873216071@qq.com)(name . 45293)(address . 45293@debbugs.gnu.org)
587ff7d5-f7ba-4865-bdc9-72e742ece70c@Johns-iPhone
Can you rename rust-skim to skim (both variable name and package name) please? I think ideally you should also remove the old rust-skim versions from crates-io.scm if no other packages depend on it. Can also you also squash the commit doing the move and rename into the commit adding skim please?

Thanks!

John
Attachment: file
Z
Z
Z572 wrote on 25 Jan 2021 18:08
(name . John Soo)(address . jsoo1@asu.edu)(address . 45293@debbugs.gnu.org)
tencent_0200D58E6D4AA44E6409FFA1E9289553950A@qq.com
rust-rustyline-6 need skim-0.7
Attachment: 0001-gnu-Add-skim.patch
J
J
John Soo wrote on 29 Jan 2021 17:35
(name . Z572)(address . 873216071@qq.com)
87v9bfituk.fsf@asu.edu
Looks good! I don't have commit access, but this should be ready to go
when someone looks at it. I have cc'd Nicolò to see if they can merge
this.
N
N
Nicolas Goaziou wrote on 5 Feb 2021 22:23
Re: [bug#45293] [PATCH] gnu: Add skim.
(name . John Soo)(address . jsoo1@asu.edu)
87tuqqw6n1.fsf@nicolasgoaziou.fr
Hello,

John Soo <jsoo1@asu.edu> writes:

Toggle quote (4 lines)
> Looks good! I don't have commit access, but this should be ready to go
> when someone looks at it. I have cc'd Nicolò to see if they can merge
> this.

I improved the commit messages and pushed. Thanks to Zheng Junjie for
the patches and to you for the review.

Regards,
--
Nicolas Goaziou
Closed
?