Dino

  • Done
  • quality assurance status badge
Details
2 participants
  • Leo Famulari
  • Raghav Gururajan
Owner
unassigned
Submitted by
Raghav Gururajan
Severity
normal
R
R
Raghav Gururajan wrote on 21 Nov 2020 19:40
(address . guix-patches@gnu.org)
ee0fa96d-8b1a-f11c-ebcf-7c54bc1698f8@raghavgururajan.name
Hello Guix!

Please find the attached patch-set.

Regards,
RG.
From 55aa0d8d546fe2b67651042461bb23145c3a1393 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:13:49 -0500
Subject: [PATCH 1/4] gnu: dino: Make some cosmetic changes.

* gnu/packages/messaging.scm (dino): Make some cosmetic changes.
---
gnu/packages/messaging.scm | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

Toggle diff (61 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9a2034f253..b60922e809 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -932,19 +932,19 @@ Encryption to Gajim.")
(package
(name "dino")
(version "0.2.0")
- (outputs '("out" "debug"))
(source
(origin
(method url-fetch)
- (uri (string-append "https://github.com/dino/dino/releases/download/v"
- version "/dino-" version ".tar.gz"))
+ (uri
+ (string-append "https://github.com/dino/dino/releases/download/v"
+ version "/dino-" version ".tar.gz"))
(sha256
- (base32
- "0iigh7bkil6prf02dqcl6lmd89jxz685h8lqr3ni4x39zkcransn"))))
+ (base32 "0iigh7bkil6prf02dqcl6lmd89jxz685h8lqr3ni4x39zkcransn"))))
(build-system cmake-build-system)
+ (outputs '("out" "debug"))
(arguments
`(#:tests? #f
- #:parallel-build? #f ; not supported
+ #:parallel-build? #f ; not supported
#:modules ((guix build cmake-build-system)
((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
(guix build utils))
@@ -955,6 +955,11 @@ Encryption to Gajim.")
(modify-phases %standard-phases
(add-after 'install 'glib-or-gtk-wrap
(assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("glib" ,glib "bin")
+ ("vala" ,vala)
+ ("gettext" ,gettext-minimal)))
(inputs
`(("libgee" ,libgee)
("libsignal-protocol-c" ,libsignal-protocol-c)
@@ -966,15 +971,10 @@ Encryption to Gajim.")
("gtk+" ,gtk+)
("glib-networking" ,glib-networking)
("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
- (native-inputs
- `(("pkg-config" ,pkg-config)
- ("glib" ,glib "bin")
- ("vala" ,vala)
- ("gettext" ,gettext-minimal)))
- (home-page "https://dino.im")
(synopsis "Graphical Jabber (XMPP) client")
(description "Dino is a Jabber (XMPP) client which aims to fit well into
a graphical desktop environment like GNOME.")
+ (home-page "https://dino.im")
(license license:gpl3+)))
(define-public prosody
--
2.29.2
From f4bbc73b45b431917e4f9021777c1141d754ac1a Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:17:52 -0500
Subject: [PATCH 2/4] gnu: dino: Update synopsis and description.

* gnu/packages/messaging.scm (dino) [synopsis]: Modify.
[description]: Modify.
---
gnu/packages/messaging.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index b60922e809..0cfc380643 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -971,9 +971,10 @@ Encryption to Gajim.")
("gtk+" ,gtk+)
("glib-networking" ,glib-networking)
("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
- (synopsis "Graphical Jabber (XMPP) client")
- (description "Dino is a Jabber (XMPP) client which aims to fit well into
-a graphical desktop environment like GNOME.")
+ (synopsis "Mordern Jabber/XMPP Client using GTK+/Vala")
+ (description "Dino is a modern chat client for the desktop. It focuses on
+providing a clean and reliable Jabber/XMPP experience while having your privacy
+in mind.")
(home-page "https://dino.im")
(license license:gpl3+)))
--
2.29.2
From f17d03f041f9e6790347d6446ac5109e7d00f4fc Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:24:34 -0500
Subject: [PATCH 3/4] gnu: dino: Re-arrange inputs in alphabetical order.

* gnu/packages/messaging.scm (dino) [native-inputs]: Re-order.
[inputs]: Re-order.
---
gnu/packages/messaging.scm | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

Toggle diff (38 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 0cfc380643..15848a9511 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -956,21 +956,21 @@ Encryption to Gajim.")
(add-after 'install 'glib-or-gtk-wrap
(assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
(native-inputs
- `(("pkg-config" ,pkg-config)
+ `(("gettext" ,gettext-minimal)
("glib" ,glib "bin")
- ("vala" ,vala)
- ("gettext" ,gettext-minimal)))
+ ("pkg-config" ,pkg-config)
+ ("vala" ,vala)))
(inputs
- `(("libgee" ,libgee)
- ("libsignal-protocol-c" ,libsignal-protocol-c)
+ `(("glib-networking" ,glib-networking)
+ ("gpgme" ,gpgme)
+ ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+ ("gtk+" ,gtk+)
+ ("libgee" ,libgee)
("libgcrypt" ,libgcrypt)
+ ("libsignal-protocol-c" ,libsignal-protocol-c)
("libsoup" ,libsoup)
("qrencode" ,qrencode)
- ("sqlite" ,sqlite)
- ("gpgme" ,gpgme)
- ("gtk+" ,gtk+)
- ("glib-networking" ,glib-networking)
- ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+ ("sqlite" ,sqlite)))
(synopsis "Mordern Jabber/XMPP Client using GTK+/Vala")
(description "Dino is a modern chat client for the desktop. It focuses on
providing a clean and reliable Jabber/XMPP experience while having your privacy
--
2.29.2
From 4c07e4fc6704eed0632ca11b12aa50f246a41b3d Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:26:44 -0500
Subject: [PATCH 4/4] gnu: dino: Add some inputs.

* gnu/packages/messaging.scm (dino) [native-inputs]: Add gtk+:bin.
[inputs]: Add glib.

These inputs are referenced by the package, but were used indirectly
via propagation from other inputs. Now they are just directly added.
---
gnu/packages/messaging.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 15848a9511..a04a078b52 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -958,10 +958,12 @@ Encryption to Gajim.")
(native-inputs
`(("gettext" ,gettext-minimal)
("glib" ,glib "bin")
+ ("gtk+:bin" ,gtk+ "bin")
("pkg-config" ,pkg-config)
("vala" ,vala)))
(inputs
- `(("glib-networking" ,glib-networking)
+ `(("glib" ,glib)
+ ("glib-networking" ,glib-networking)
("gpgme" ,gpgme)
("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
("gtk+" ,gtk+)
--
2.29.2
Attachment: OpenPGP_signature
R
R
Raghav Gururajan wrote on 22 Nov 2020 02:08
Dino (v2)
(address . 44781@debbugs.gnu.org)
59a7cae5-1d17-0072-e4fb-a56411087989@raghavgururajan.name
@Leo

Please find the revised patch-set.

Regards,
RG.
From 55aa0d8d546fe2b67651042461bb23145c3a1393 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:13:49 -0500
Subject: [PATCH 1/5] gnu: dino: Make some cosmetic changes.

* gnu/packages/messaging.scm (dino): Make some cosmetic changes.
---
gnu/packages/messaging.scm | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

Toggle diff (61 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9a2034f253..b60922e809 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -932,19 +932,19 @@ Encryption to Gajim.")
(package
(name "dino")
(version "0.2.0")
- (outputs '("out" "debug"))
(source
(origin
(method url-fetch)
- (uri (string-append "https://github.com/dino/dino/releases/download/v"
- version "/dino-" version ".tar.gz"))
+ (uri
+ (string-append "https://github.com/dino/dino/releases/download/v"
+ version "/dino-" version ".tar.gz"))
(sha256
- (base32
- "0iigh7bkil6prf02dqcl6lmd89jxz685h8lqr3ni4x39zkcransn"))))
+ (base32 "0iigh7bkil6prf02dqcl6lmd89jxz685h8lqr3ni4x39zkcransn"))))
(build-system cmake-build-system)
+ (outputs '("out" "debug"))
(arguments
`(#:tests? #f
- #:parallel-build? #f ; not supported
+ #:parallel-build? #f ; not supported
#:modules ((guix build cmake-build-system)
((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
(guix build utils))
@@ -955,6 +955,11 @@ Encryption to Gajim.")
(modify-phases %standard-phases
(add-after 'install 'glib-or-gtk-wrap
(assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("glib" ,glib "bin")
+ ("vala" ,vala)
+ ("gettext" ,gettext-minimal)))
(inputs
`(("libgee" ,libgee)
("libsignal-protocol-c" ,libsignal-protocol-c)
@@ -966,15 +971,10 @@ Encryption to Gajim.")
("gtk+" ,gtk+)
("glib-networking" ,glib-networking)
("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
- (native-inputs
- `(("pkg-config" ,pkg-config)
- ("glib" ,glib "bin")
- ("vala" ,vala)
- ("gettext" ,gettext-minimal)))
- (home-page "https://dino.im")
(synopsis "Graphical Jabber (XMPP) client")
(description "Dino is a Jabber (XMPP) client which aims to fit well into
a graphical desktop environment like GNOME.")
+ (home-page "https://dino.im")
(license license:gpl3+)))
(define-public prosody
--
2.29.2
From dc388b2e22992ef6b5300913e477d9a917fcb7d1 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 13:17:52 -0500
Subject: [PATCH 2/5] gnu: dino: Update synopsis and description.

* gnu/packages/messaging.scm (dino) [synopsis]: Modify.
[description]: Modify.
---
gnu/packages/messaging.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index b60922e809..9a7372c500 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -971,9 +971,10 @@ Encryption to Gajim.")
("gtk+" ,gtk+)
("glib-networking" ,glib-networking)
("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
- (synopsis "Graphical Jabber (XMPP) client")
- (description "Dino is a Jabber (XMPP) client which aims to fit well into
-a graphical desktop environment like GNOME.")
+ (synopsis "Jabber/XMPP Client using GTK+/Vala")
+ (description "Dino is a chat client for the desktop. It focuses on providing
+a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
+default.")
(home-page "https://dino.im")
(license license:gpl3+)))
--
2.29.2
From 66a0b8895adce93856ca425fd14a4d4f3101c848 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 20:01:53 -0500
Subject: [PATCH 3/5] gnu: dino: Re-arrange inputs in alphabetical order.

* gnu/packages/messaging.scm (dino) [native-inputs]: Re-order.
[inputs]: Re-order.
---
gnu/packages/messaging.scm | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

Toggle diff (38 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9a7372c500..f5151558b1 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -956,21 +956,21 @@ Encryption to Gajim.")
(add-after 'install 'glib-or-gtk-wrap
(assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
(native-inputs
- `(("pkg-config" ,pkg-config)
+ `(("gettext" ,gettext-minimal)
("glib" ,glib "bin")
- ("vala" ,vala)
- ("gettext" ,gettext-minimal)))
+ ("pkg-config" ,pkg-config)
+ ("vala" ,vala)))
(inputs
- `(("libgee" ,libgee)
- ("libsignal-protocol-c" ,libsignal-protocol-c)
+ `(("glib-networking" ,glib-networking)
+ ("gpgme" ,gpgme)
+ ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+ ("gtk+" ,gtk+)
("libgcrypt" ,libgcrypt)
+ ("libgee" ,libgee)
+ ("libsignal-protocol-c" ,libsignal-protocol-c)
("libsoup" ,libsoup)
("qrencode" ,qrencode)
- ("sqlite" ,sqlite)
- ("gpgme" ,gpgme)
- ("gtk+" ,gtk+)
- ("glib-networking" ,glib-networking)
- ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+ ("sqlite" ,sqlite)))
(synopsis "Jabber/XMPP Client using GTK+/Vala")
(description "Dino is a chat client for the desktop. It focuses on providing
a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
--
2.29.2
From e6f23e6b44c2de48452b7615a1b04d75e8c3b260 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 20:04:06 -0500
Subject: [PATCH 4/5] gnu: dino: Add some inputs.

* gnu/packages/messaging.scm (dino) [native-inputs]: Add gtk+:bin.
[inputs]: Add glib.
---
gnu/packages/messaging.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index f5151558b1..cf83f8edf7 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -958,10 +958,12 @@ Encryption to Gajim.")
(native-inputs
`(("gettext" ,gettext-minimal)
("glib" ,glib "bin")
+ ("gtk+:bin" ,gtk+ "bin")
("pkg-config" ,pkg-config)
("vala" ,vala)))
(inputs
- `(("glib-networking" ,glib-networking)
+ `(("glib" ,glib)
+ ("glib-networking" ,glib-networking)
("gpgme" ,gpgme)
("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
("gtk+" ,gtk+)
--
2.29.2
From b30740a072e88cf9c7bd9cf68e0b6310024cefc9 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 21 Nov 2020 20:05:36 -0500
Subject: [PATCH 5/5] gnu: dino: Correct glib native-input name.

* gnu/packages/messaging.scm (dino) [native-inputs]: Rename glib to
glib:bin.
---
gnu/packages/messaging.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index cf83f8edf7..42e5688bef 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -957,7 +957,7 @@ Encryption to Gajim.")
(assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
(native-inputs
`(("gettext" ,gettext-minimal)
- ("glib" ,glib "bin")
+ ("glib:bin" ,glib "bin")
("gtk+:bin" ,gtk+ "bin")
("pkg-config" ,pkg-config)
("vala" ,vala)))
--
2.29.2
Attachment: OpenPGP_signature
L
L
Leo Famulari wrote on 22 Nov 2020 02:18
(name . Raghav Gururajan)(address . rg@raghavgururajan.name)(address . 44781@debbugs.gnu.org)
20201122011831.GA28202@jasmine.lan
On Sat, Nov 21, 2020 at 08:08:29PM -0500, Raghav Gururajan wrote:
Toggle quote (4 lines)
> @Leo
>
> Please find the revised patch-set.

Thanks! Pushed as eeee65076e3199c778b177e06de3aae7696dbb9f
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl+5vGcACgkQJkb6MLrK
fwh5mxAAgZvPtjSWCHLZkKXtHYoeHVICVsUc1xArQ0OApMmjWxYVYz/1fpzL52OU
bP5U/33LAWMzXE35XOav4Q0uy5HHWTVi2zAAA9v5BouBj2OcEpJUrSpA4ivGc9We
KmrY2gnytmekjKP7GD9P8rkavLKEYKo66bx1QHWrn37hkxy+PupJJYiFEzbeYGh+
FBWPFE3V9cK1nFClHkjAmBUhPY67GAJjYvSldz7vAxRMoMC5u9J53ocRGG5qC7Cv
BAMhbm2M8tuKAn4z535qh7PMNJV9hyVCJ8LHyuv/ibElDjtqkQmg8VdO3hGg7eEH
zGG0Nx6ToYJgbJ1yRX+eogOqxO2spRnP/L15DOR4snMr6G+cJ0agOMnB+f/IUHlJ
uYi7hTUEe/IKXjWJeqGt+YOqL9HtwCIvaOK7EgX3rW8qtKz0ISwOnrFFOGq8YfLP
8yJNv6/NQLa3+1IWqIiAWRP1eSQhwU39i6LykZH3wWt+LKe0GczEEeW7FHja+Piu
UKXpvCwvvOL6unUr2mqRSnf78x3YHlHatwTYwXz3wMGl5aOQHKRFe6Ouv527oekC
HxxcoJcY2CqcTK4Chtd9KfX9k+uYsgiruyi+RCm73puIb5FVbCf/H7oEIy0YYj+6
+IHtB9bY0r6KL16UR+3e+Cc7UzIkYveNZQWOtDpKTnWqABbsj8M=
=V7h8
-----END PGP SIGNATURE-----


L
L
Leo Famulari wrote on 22 Nov 2020 02:18
(no subject)
(address . control@debbugs.gnu.org)
20201122011847.GA28262@jasmine.lan
close 44781
?