* gnu/packages/animation.scm (gnash): New variable.* gnu/packages/patches/gnash-fix-giflib-version: New file.* gnu/local.mk (dist_patch_DATA): Add it.---I fixed some problems in the first patch. Resending a v2. Removed pangox patch, use pangox-compat input instead.Fixed year in the comment of last version.Removed a stray comment in version.Fixed jemalloc path.Added python-wrapper to native-inputs. gnu/local.mk | 2 + gnu/packages/animation.scm | 98 ++++++++++++++++++- .../patches/gnash-fix-giflib-version.patch | 13 +++ 3 files changed, 112 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/gnash-fix-giflib-version.patch
Toggle quote (7 lines)> * gnu/packages/animation.scm (gnash): New variable.> * gnu/packages/patches/gnash-fix-giflib-version: New file.> * gnu/local.mk (dist_patch_DATA): Add it.> ---> Corrected typo in the description> Added data about the patch in patch file
Hi! I've gone ahead and pushed this patch for gnash to master asc76d0201f7cc639f51dbf259779d86dad62417cd. The only thing I changed was moving the package up off the bottom of thefile. I'll send another email about lightspark. Thanks, Chris
Toggle quote (4 lines)> * gnu/packages/animation.scm (lightspark): New variable.> ---> Rebased on the previous commit
Thanks for the patch, the main thing I noticed with this is that there'ssome bundled code, at least I spotted pugixml included in the lightsparkcode, and Guix already has a package for pugixml. If possible, lightspark should be built with pugixml from Guix.
(name . Christopher Baines)(address . email@example.com)(address . firstname.lastname@example.org)
Christopher Baines writes:
Toggle quote (13 lines)> Vinicius Monego <email@example.com> writes:>>> * gnu/packages/animation.scm (lightspark): New variable.>> --->> Rebased on the previous commit>> Thanks for the patch, the main thing I noticed with this is that there's> some bundled code, at least I spotted pugixml included in the lightspark> code, and Guix already has a package for pugixml.>> If possible, lightspark should be built with pugixml from Guix.>
Hello, Sorry for the late response. I noticed that jxrlib is also in Guix, andtried to unbundle both jxrlib and pugixml unsuccesfully. In the case of jxrlib, JXRGlue fails to include JXRMeta: #include <JXRMeta.h> ^~~~~~~~~~~ IIUC the include syntax is jxrlib/JXRMeta.h. It also fails in the Debianpackage from where Guix pulls from. In the case of pugixml the build fails with undefined references. I alsofound this comment in the changelog: * switch to internal xml parsing (based on pugixml) which implies that the bundled pugixml is a fork and not a snapshot.