Fix dockerd requires file-system-/sys/fs/cgroup/blkio

  • Done
  • quality assurance status badge
Details
3 participants
  • Danny Milosavljevic
  • Oleg Pykhalov
  • Marius Bakke
Owner
unassigned
Submitted by
Oleg Pykhalov
Severity
normal
O
O
Oleg Pykhalov wrote on 18 Nov 2020 07:00
(name . guix-patches)(address . guix-patches@gnu.org)
871rgrkxvh.fsf@gmail.com
Hello,

According to Git bisect, the 977eb5d0 commit breaks docker-service-type
with the following error during “guix system build” or “guix system
reconfigure”:

guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service


The following patch fixes this.
From dcc259c3a33a470eee761f4deadf9149f0a65c55 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Wed, 18 Nov 2020 08:57:05 +0300
Subject: [PATCH] Fix file-system->shepherd-service-name.

This commit follow 977eb5d023cfdf8e336f1896480eea9cef5c04e9, which breaks
docker-service-type with error:

guix system: error: service 'dockerd' requires
'file-system-/sys/fs/cgroup/blkio', which is not provided by any service

* gnu/services/base.scm (file-system->shepherd-service-name): Add '/' to
valid characters.
---
gnu/services/base.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 712b3a018f..6fc966e268 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -288,7 +288,7 @@ FILE-SYSTEM."
(define valid-characters
;; Valid store characters; see 'checkStoreName' in the daemon.
(string->char-set
- "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?="))
+ "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz+-._?=/"))
(define mount-point
(string-map (lambda (chr)
--
2.29.2
Oleg.
-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl+0uIIUHGdvLndpZ3Vz
dEBnbWFpbC5jb20ACgkQFn+OpQAa+pwmiA/9EuC0HrrsAP0VjnlVdVoi335c38qt
lQyWcpKoCVBPNvB9+AAmDfRKCVt60VyUi0E2RWPwJx+U1NY5aVE9M9FQRjf9V+iQ
v+ek2ZTmql24Ex7OTdSrbTXBszlup9fOs/E1D6VsAWnmBulnn6xbUbXv8ldYGFSR
95snHtKatF15eZVu325s0iq8EF1uTiwV3cfRdI/8sedryI7sbHFQhhhyTYqTgBqj
qrJLZst5Lci8usuaZcMm5V4YPcKy+W4y5S6itAMOcx16ac7BgRXDQLVTUm8ud9/m
sQyI2x4VbzIfp9gSasM14W5KvsOFIe2S4lZiLh/2LmCGxBjdYgFSb5dhXz+kANYk
TNG184J9g6k7Zgo5ilVnwclSB6P8fDfsQJ4tRxQqLbru9fbQEoGSDGb7cjvFTxq0
1U5tqhKMWIsajFYvDz+8KdK11KoyJcs5AVyBQCHK5wbQ2pZoMaMGm4i1nEa02X5F
V6NPqk/78qy0Q9sG8SIMj2hq7ByQabuEY2ka2MTcZeOWjJ0gz1i6IWLajCMu1RpU
gH9659yssxI5zGUp1s87smV9WH3ySeLfkhvojYaL74Tyu1JvDsPzo7wYDdMEravX
F11qQs/PumRbEsuPCdAz12BdwTK0vmBbFrdJD7DCJz3dGjSrFs1O4zO7ks1jfI9i
EzXO95snWA8LvE8=
=YyF8
-----END PGP SIGNATURE-----

D
D
Danny Milosavljevic wrote on 18 Nov 2020 17:26
(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 44718@debbugs.gnu.org)
20201118172624.15ea4f86@scratchpost.org
Hi,

On Wed, 18 Nov 2020 09:00:34 +0300
Oleg Pykhalov <go.wigust@gmail.com> wrote:

Toggle quote (6 lines)
> According to Git bisect, the 977eb5d0 commit breaks docker-service-type
> with the following error during “guix system build” or “guix system
> reconfigure”:
>
> guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service

I can confirm this bug.

However, I cannot say one way or another where the patch is the right fix.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+1SzEACgkQ5xo1VCww
uqXj9gf9Ea55MTUjbvsnL/copxGJTpMKpJ4UNgTzpijEe3PbOmYGTZRzM/LIJkPG
42ICff7gKoLGzXe1gLY3kX5b+StNfIfRY5Seet5zNGBi0dxWyKzZcnx65PBFUgYH
ifGbC5r6aR/BrTCCfxg75vHbbKjo1bKh3fvUePbqPYX+03cZsu9REwh0gw+nvzsa
XU1OBAOkSEimMRr2Ql+gQ4x6mo1Lp0wk/VaUFMgAF8FnzY8f/ly8wjWmI2CK/xrZ
CITHDENwB2f9MuRxe+1SKu5fp4L9985+QoL7xYae/q2qtwrIrcV54fQw9oXRBhdr
YQxBp48aQNksVqTQDA8/HwXc+p2yIQ==
=CUZp
-----END PGP SIGNATURE-----


M
M
Marius Bakke wrote on 18 Nov 2020 22:26
(address . 44718@debbugs.gnu.org)
87pn4abbld.fsf@gnu.org
Danny Milosavljevic <dannym@scratchpost.org> skriver:

Toggle quote (15 lines)
> Hi,
>
> On Wed, 18 Nov 2020 09:00:34 +0300
> Oleg Pykhalov <go.wigust@gmail.com> wrote:
>
>> According to Git bisect, the 977eb5d0 commit breaks docker-service-type
>> with the following error during “guix system build” or “guix system
>> reconfigure”:
>>
>> guix system: error: service 'dockerd' requires 'file-system-/sys/fs/cgroup/blkio', which is not provided by any service
>
> I can confirm this bug.
>
> However, I cannot say one way or another where the patch is the right fix.

I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
can you confirm?
-----BEGIN PGP SIGNATURE-----

iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+1kY4PHG1hcml1c0Bn
bnUub3JnAAoJEKKgbfKjOlT6HBcIALNsclEvIYsVKiyRru5jVqBs1jKBp6pMecYL
2B2ZgkKlf7EKWixs5c1SOHuEwL2e1HgvXcv0ZQh+OxDzl1wxAB55nNkBmHQ0SMcc
lo0HlbCrl4ssGTRNlcsYdEyP3BwcosvkSt8qpy3JQT9qv61syXPTs8CvfHqFjo1S
lqJ6ab7Pz6jnnP1pbFz5H7I7QbaI3x/zZipurMNYFYmDAOcjwh8PtTT7pzVCkvYO
TaUur7mfs85vRCfpPIpTUezuyAjOvDIKV9UFq+v3Mx5UzzC64Se5AM1HTLyOF18i
SNyaLWUY9zwCefrD+T8gr6+WD+jmEOKv3NW3VZsUYJgQhCn2bmE=
=8as6
-----END PGP SIGNATURE-----

D
D
Danny Milosavljevic wrote on 19 Nov 2020 01:26
(name . Marius Bakke)(address . marius@gnu.org)
20201119012634.60b3a689@scratchpost.org
Hi,

On Wed, 18 Nov 2020 22:26:38 +0100
Marius Bakke <marius@gnu.org> wrote:

Toggle quote (3 lines)
> I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
> can you confirm?

Yes, it is indeed fixed for me.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+1u7oACgkQ5xo1VCww
uqWq3Qf+NtmdhtQYL8Zl6Xi4AmjwBADKOA3D4Jz/5afT3UVYGgSqV+nqaGCJDbao
TAm88cOYvlv+dVHfmYvsQJDaHYnaKsYa+BUBHqOjHMlrpzufe7qGpIW/qUclWFm3
098+CKKxxa1G6ugIenKJaE1km7bdffH5CrTNJaf+iPNpBasBV3w125yUPC9RRY7c
pX4rrGCb5lHDlw5EYC8IHq/h+Pm9xRkBAmvqDUDb/OjOcFzWGqPF8KrqKeFhjTeG
3NT3lxM08iX7K2vMFRuBUDVwdLNg3XpCY5RwIxMJBAsxUKu9Kw7uruB+mRExwBqH
vLsYkQ2dZD6NDjWYZn93PLhv5DGnMg==
=S753
-----END PGP SIGNATURE-----


O
O
Oleg Pykhalov wrote on 20 Nov 2020 06:11
(address . 44718@debbugs.gnu.org)
875z60wr2e.fsf@gmail.com
Marius Bakke <marius@gnu.org> writes:

[…]

Toggle quote (3 lines)
> I suspect this was fixed by 37b98e8cca3244067071bc6e382b06861457a459,
> can you confirm?

Yes, closing the issue.
-----BEGIN PGP SIGNATURE-----

iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAl+3T/kUHGdvLndpZ3Vz
dEBnbWFpbC5jb20ACgkQFn+OpQAa+pw2ZQ/+KEh1mg7cvjf2bSFzApM4iXVMqn1n
WHRcYFa8lnhVJYfyVrFwbi47kVtLU2jdb1AP6GJ5HqORGOZyJUpWxKoLFVgawQkM
s2C+bdrkxMlkN0imI0v+hLB84/3euP7sck2eLqP6G8DjmD8Osumlkf4kSofJKr7c
IcPMb/oR+hR35APkR7BoMwN3mgI2AJn6ZusdhhH6duxmRmd40RT5Oq6/j0W8dPXe
WauH9KjJHx/Kb5iNbLuI6hhu9S4LtIEYUlnAp5f/QvsDC2jrvw4ZaG1WhCqWLJmO
pqL/23QgGM/skRCmtQM+uX/RJCStixEO0heuoJnXduKbz9e8N3iYH3extU/DfFjo
PLTRH79OuT39RFAPxPMftNR5NfH4RF+/ArwVzGm+F7xFTA16rvmke61yiQmSRk1c
2g6y/zUW9OG5VbMsxcZsDG0EFNJWDz2Ri085E5LURqb1IiarMYyude3njUUAb25e
85sEuSA07iIiohTkaEZ888+tvVd5ZtcoO9MWRXqdF2bRtGU/WzpHg73BeXx8hI63
AS2saoRb37dXQbpkQRZOhXNKZPgnfh6liAtKaSjAudon2cq+avhyrGd5/KuIYo0k
kv8vw9wz1grE9ibKac9QN3zCGLFKKNS8J3884LSVtx09yA4R3qMDiUOfCT/SXHg5
cS3VmI5Rnf15TNE=
=ql22
-----END PGP SIGNATURE-----

O
O
Oleg Pykhalov wrote on 21 Nov 2020 15:35
control message for bug #44718
(address . control@debbugs.gnu.org)
87h7pipyl1.fsf@gmail.com
close 44718
quit
?