[PATCH] doc: Fix typo

  • Done
  • quality assurance status badge
Details
3 participants
  • Aniket Patil
  • Ludovic Courtès
  • zimoun
Owner
unassigned
Submitted by
Aniket Patil
Severity
normal
A
A
Aniket Patil wrote on 15 Oct 2020 09:47
(address . guix-patches@gnu.org)
CAF-xJguymOtnsh4x9DuBvJwZwAjwh286Box1wpFD9wknQzhUog@mail.gmail.com
*doc/guix.texi (section 7.5): Fix typo
---
doc/guix.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (16 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index ff33735c3a..ce569f6fbf 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -10105,7 +10105,7 @@ package expressions for all those packages that are
not yet in Guix.

When @option{--archive=bioconductor} is added, metadata is imported from
@uref{https://www.bioconductor.org/, Bioconductor}, a repository of R
-packages for for the analysis and comprehension of high-throughput
+packages for the analysis and comprehension of high-throughput
genomic data in bioinformatics.

Information is extracted from the @file{DESCRIPTION} file contained in the
--
2.28.0
Attachment: file
From 886079e699d1de55288aacb84095b65a9ef18927 Mon Sep 17 00:00:00 2001
From: Aniket Patil <aniket112.patil@gmail.com>
Date: Thu, 15 Oct 2020 08:56:43 +0530
Subject: [PATCH] doc: Fix typo

*doc/guix.texi (section 7.5): Fix typo
---
doc/guix.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index ff33735c3a..ce569f6fbf 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -10105,7 +10105,7 @@ package expressions for all those packages that are not yet in Guix.
When @option{--archive=bioconductor} is added, metadata is imported from
@uref{https://www.bioconductor.org/, Bioconductor}, a repository of R
-packages for for the analysis and comprehension of high-throughput
+packages for the analysis and comprehension of high-throughput
genomic data in bioinformatics.
Information is extracted from the @file{DESCRIPTION} file contained in the
--
2.28.0
Z
Z
zimoun wrote on 15 Oct 2020 15:09
86mu0n1vqh.fsf@gmail.com
Dear,

Thank you for your contribution. It is almost fine. Three things are
not “correct“.

1. The commit subject must end with a dot. Like:

doc: Fix typo.

2. Idem inside the commit message.
3. It is “star space path/to/file”, see below.


And last, about the message itself:

Toggle quote (2 lines)
> *doc/guix.texi (section 7.5): Fix typo

Usually, the section numbering does not appear. It does not make sense
since it is a moving target. Instead, it seems better to provide the
node name, e.g.,

* doc/guix.texi (Invoking guix import): Fix typo.


Does it make sense?


Now, you should send an updated patch. To do so, you should
‘interactively rebase’. Using Emacs and Magit , it looks like:

r i
edit C-c C-c
# do your tweaks
r r
W c C-m b origin/master C-m v 2 c
! git send-email --to= 44006@debbugs.gnu.org v2-0001-blabla.patch

How does it sound for you?


All the best,
simon
Z
Z
zimoun wrote on 15 Oct 2020 15:42
(name . Aniket Patil)(address . aniket112.patil@gmail.com)(address . 44006@debbugs.gnu.org)
86h7qv1u8j.fsf@gmail.com
On Thu, 15 Oct 2020 at 18:45, Aniket Patil <aniket112.patil@gmail.com> wrote:

Toggle quote (4 lines)
>>> 2. Idem inside the commit message.
>
> What does Idem means?

It is Latin locution for saying “the same as mentioned”. Sorry I
thought it was standard English (I am not native but French :-)).
A
A
Aniket Patil wrote on 15 Oct 2020 15:15
(name . zimoun)(address . zimon.toutoune@gmail.com)(address . 44006@debbugs.gnu.org)
CAF-xJguoZDLG8Tz0Cp1NaSkzNQ3Q+fUiNUENN3-d4u4m2f795w@mail.gmail.com
Thanks for the feedback sir!
But I didn’t get

Toggle quote (2 lines)
>> 2. Idem inside the commit message.

What does Idem means?

I will do new changes As well.


Aniket.


On Thu, 15 Oct 2020 at 6:39 PM, zimoun <zimon.toutoune@gmail.com> wrote:

Toggle quote (44 lines)
> Dear,
>
> Thank you for your contribution. It is almost fine. Three things are
> not “correct“.
>
> 1. The commit subject must end with a dot. Like:
>
> doc: Fix typo.
>
> 2. Idem inside the commit message.
> 3. It is “star space path/to/file”, see below.
>
>
> And last, about the message itself:
>
> > *doc/guix.texi (section 7.5): Fix typo
>
> Usually, the section numbering does not appear. It does not make sense
> since it is a moving target. Instead, it seems better to provide the
> node name, e.g.,
>
> * doc/guix.texi (Invoking guix import): Fix typo.
>
>
> Does it make sense?
>
>
> Now, you should send an updated patch. To do so, you should
> ‘interactively rebase’. Using Emacs and Magit , it looks like:
>
> r i
> edit C-c C-c
> # do your tweaks
> r r
> W c C-m b origin/master C-m v 2 c
> ! git send-email --to= 44006@debbugs.gnu.org v2-0001-blabla.patch
>
> How does it sound for you?
>
>
> All the best,
> simon
>
>
Attachment: file
A
A
Aniket Patil wrote on 15 Oct 2020 15:44
(name . zimoun)(address . zimon.toutoune@gmail.com)(address . 44006@debbugs.gnu.org)
CAF-xJgtjeBdv04+0PEKo-xMm6mq5ROfrQub7L__u32ki3CE0kg@mail.gmail.com
Thank you for the clarification sir.

Bonjour. :)

Aniket

On Thu, 15 Oct 2020 at 7:12 PM, zimoun <zimon.toutoune@gmail.com> wrote:

Toggle quote (10 lines)
> On Thu, 15 Oct 2020 at 18:45, Aniket Patil <aniket112.patil@gmail.com>
> wrote:
>
> >>> 2. Idem inside the commit message.
> >
> > What does Idem means?
>
> It is Latin locution for saying “the same as mentioned”. Sorry I
> thought it was standard English (I am not native but French :-)).
>
Attachment: file
A
A
Aniket Patil wrote on 16 Oct 2020 14:48
[PATCH v2] doc: Fix typo.
(address . 44006@debbugs.gnu.org)(name . Aniket Patil)(address . aniket112.patil@gmail.com)
20201016124822.62329-1-aniket112.patil@gmail.com
* doc/guix.texi (Invoking guix import): Fix typo.
---
doc/guix.texi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index ff33735c3a..ce569f6fbf 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -10105,7 +10105,7 @@ package expressions for all those packages that are not yet in Guix.
When @option{--archive=bioconductor} is added, metadata is imported from
@uref{https://www.bioconductor.org/, Bioconductor}, a repository of R
-packages for for the analysis and comprehension of high-throughput
+packages for the analysis and comprehension of high-throughput
genomic data in bioinformatics.
Information is extracted from the @file{DESCRIPTION} file contained in the
--
2.28.0
L
L
Ludovic Courtès wrote on 17 Oct 2020 22:34
(name . Aniket Patil)(address . aniket112.patil@gmail.com)(address . 44006-done@debbugs.gnu.org)
87lfg44mn5.fsf@gnu.org
Hi Aniket,

Aniket Patil <aniket112.patil@gmail.com> skribis:

Toggle quote (2 lines)
> * doc/guix.texi (Invoking guix import): Fix typo.

Applied, thanks!

Ludo’.
Closed
?