[PATCH] gnu: emacs-julia-mode: Update to 0.4.

  • Done
  • quality assurance status badge
Details
5 participants
  • Brett Gilio
  • Ludovic Courtès
  • Nicolas Goaziou
  • Tim Howes
  • zimoun
Owner
unassigned
Submitted by
Tim Howes
Severity
normal
T
T
Tim Howes wrote on 15 Oct 2020 09:33
[PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8ea90c7.
(address . guix-patches@gnu.org)
87wnzs3pvy.fsf@lavabit.com
Hello,

This patch updates emacs-julia-mode to the latest commit from

Thanks,
Tim
From 3271943c18c93317d89869d9882ae69e6a0677aa Mon Sep 17 00:00:00 2001
From: Tim Howes <timhowes@lavabit.com>
Date: Mon, 12 Oct 2020 23:12:29 -0700
Subject: [PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8ea90c7.

* gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4-0.8ea90c7.
---
gnu/packages/emacs-xyz.scm | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

Toggle diff (41 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0c49d72cc2..9508d1475e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -81,6 +81,7 @@
;;; Copyright © 2020 Niklas Eklund <niklas.eklund@posteo.net>
;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com>
;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org>
+;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -7731,13 +7732,12 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
(license license:gpl3+))))
(define-public emacs-julia-mode
- ;; XXX: Upstream version remained stuck at 0.3. See
- ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>.
- (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4")
- (revision "1"))
+ (let ((commit "8ea90c7927f6d87a291cfb0216f34dacf43c722e")
+ (version "0.4")
+ (revision "0"))
(package
(name "emacs-julia-mode")
- (version (string-append "0.3-" revision "." (string-take commit 8)))
+ (version (git-version version revision commit))
(source
(origin
(method git-fetch)
@@ -7747,7 +7747,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
(file-name (git-file-name name version))
(sha256
(base32
- "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0"))))
+ "1ymanbalx41xri5kiqs83a80a72yr9831if6cz2m24pg3g7rwr9c"))))
(build-system emacs-build-system)
(arguments
`(#:tests? #t
--
2.28.0
N
N
Nicolas Goaziou wrote on 16 Oct 2020 00:03
(name . Tim Howes via Guix-patches via)(address . guix-patches@gnu.org)
877drrb10g.fsf@nicolasgoaziou.fr
Hello,

Tim Howes via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (3 lines)
> This patch updates emacs-julia-mode to the latest commit from
> https://github.com/JuliaEditorSupport/julia-emacs

Thank you.

Is there any reason not to use regular 0.4 release from March? If so,
could you explain it in a comment?

Regards,
--
Nicolas Goaziou
T
T
Tim Howes wrote on 16 Oct 2020 08:36
Re: [bug#44003] [PATCH v2] gnu: emacs-julia-mode: Update to 0.4-0.8bfc709.
(address . 44003@debbugs.gnu.org)(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
87tuuuhe3e.fsf@lavabit.com
It seemed like the previous package definition used the latest commit,
but I guess that was because they had not yet put out a tagged release.


The tagged release from March should work fine. Should it keep the
revision and commit ID as part of the version?
From 6975b12dfe2478acf19a299be1942c68a40868ca Mon Sep 17 00:00:00 2001
From: Tim Howes <timhowes@lavabit.com>
Date: Thu, 15 Oct 2020 19:52:04 -0700
Subject: [PATCH v2] gnu: emacs-julia-mode: Update to 0.4-0.8bfc709.

* gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4-0.8bfc709.
---
gnu/packages/emacs-xyz.scm | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

Toggle diff (41 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3e61e3141..2392c48295 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -81,6 +81,7 @@
;;; Copyright © 2020 Niklas Eklund <niklas.eklund@posteo.net>
;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com>
;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org>
+;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -7786,13 +7787,12 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
(license license:gpl3+))))
(define-public emacs-julia-mode
- ;; XXX: Upstream version remained stuck at 0.3. See
- ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>.
- (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4")
- (revision "1"))
+ (let ((commit "8bfc709716a257521cb386f20b8932e83db930a9")
+ (version "0.4")
+ (revision "0"))
(package
(name "emacs-julia-mode")
- (version (string-append "0.3-" revision "." (string-take commit 8)))
+ (version (git-version version revision commit))
(source
(origin
(method git-fetch)
@@ -7802,7 +7802,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
(file-name (git-file-name name version))
(sha256
(base32
- "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0"))))
+ "1w131jb9mhvyjxa0p93iwfhzidgbcs6b8i6jg79yisqb9wchik99"))))
(build-system emacs-build-system)
(arguments
`(#:tests? #t
--
2.28.0
T
T
Tim Howes wrote on 16 Oct 2020 08:49
(address . control@debbugs.gnu.org)
874kmuis1c.fsf@lavabit.com
retitle 44003 [PATCH] gnu: emacs-julia-mode: Update to 0.4-0.8bfc709.
thanks
B
B
Brett Gilio wrote on 16 Oct 2020 21:32
(name . Tim Howes via Guix-patches via)(address . guix-patches@gnu.org)
87h7qu3r1z.fsf@debian
Tim Howes via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (5 lines)
>
> The tagged release from March should work fine. Should it keep the
> revision and commit ID as part of the version?
>

Using tagged releases is preferred. I would remove the commit
let-binding and go about it using version numbering.

--
Brett M. Gilio
brettg@gnu.org
E82A C026 95D6 FF02 43CA 1E5C F6C5 2DD1 BA27 CB87
T
T
Tim Howes wrote on 18 Oct 2020 00:28
Re: [bug#44003] [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.
(name . Brett Gilio)(address . brettg@gnu.org)
87ft6c1o8l.fsf@lavabit.com
Brett Gilio writes:

Toggle quote (3 lines)
> Using tagged releases is preferred. I would remove the commit
> let-binding and go about it using version numbering.

OK, sounds good. Here it is using just the version tag.

Thanks,
Tim
From 56fb736e24782937283eda7a3c4ea6b25c2d1014 Mon Sep 17 00:00:00 2001
From: Tim Howes <timhowes@lavabit.com>
Date: Thu, 15 Oct 2020 19:52:04 -0700
Subject: [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.

* gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4.
---
gnu/packages/emacs-xyz.scm | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)

Toggle diff (50 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3e61e3141..d2fb4aaadb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -81,6 +81,7 @@
;;; Copyright © 2020 Niklas Eklund <niklas.eklund@posteo.net>
;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com>
;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org>
+;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -7786,23 +7787,19 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
(license license:gpl3+))))
(define-public emacs-julia-mode
- ;; XXX: Upstream version remained stuck at 0.3. See
- ;; <https://github.com/JuliaEditorSupport/julia-emacs/issues/46>.
- (let ((commit "115d4dc8a07445301772da8376b232fa8c7168f4")
- (revision "1"))
(package
(name "emacs-julia-mode")
- (version (string-append "0.3-" revision "." (string-take commit 8)))
+ (version "0.4")
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/JuliaEditorSupport/julia-emacs")
- (commit commit)))
+ (commit version)))
(file-name (git-file-name name version))
(sha256
(base32
- "1is4dcv6blslpzbjcg8l2jpxi8xj96q4cm0nxjxsyswpm8bw8ki0"))))
+ "1w131jb9mhvyjxa0p93iwfhzidgbcs6b8i6jg79yisqb9wchik99"))))
(build-system emacs-build-system)
(arguments
`(#:tests? #t
@@ -7813,7 +7810,7 @@ E-Prime forbids the use of the \"to be\" form to strengthen your writing.")
(synopsis "Major mode for Julia")
(description "This Emacs package provides a mode for the Julia
programming language.")
- (license license:expat))))
+ (license license:expat)))
(define-public emacs-smex
(package
--
2.28.0
T
T
Tim Howes wrote on 18 Oct 2020 00:32
(address . control@debbugs.gnu.org)
87zh4k32n0.fsf@lavabit.com
retitle 44003 [PATCH] gnu: emacs-julia-mode: Update to 0.4.
thanks
Z
Z
zimoun wrote on 19 Oct 2020 15:42
Re: [bug#44003] [PATCH v2] gnu: emacs-julia-mode: Update to 0.4-0.8bfc709.
(name . Brett Gilio)(address . brettg@gnu.org)
CAJ3okZ28b0-cZyVUTQWhb_+rYdZz4RMKaK=xYgGSbG8GzKn21A@mail.gmail.com
Dear,

On Fri, 16 Oct 2020 at 21:33, Brett Gilio <brettg@gnu.org> wrote:

Toggle quote (3 lines)
> Using tagged releases is preferred. I would remove the commit
> let-binding and go about it using version numbering.

It is currently the convention and uniformity matters. :-)
But IMHO it is bad practise. Using commit hash enforces
content-addressed, which is obviously not the case with "tags". Tags
are fragile for upstream in-place replacement, for example. For
reference, [1] and BTW all the thread is worth to read. :-)


All the best,
simon
L
L
Ludovic Courtès wrote on 2 Nov 2020 14:46
Re: [bug#44003] [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.
(name . Tim Howes)(address . timhowes@lavabit.com)
875z6nna78.fsf@gnu.org
Hi Tim,

Tim Howes <timhowes@lavabit.com> skribis:

Toggle quote (7 lines)
>>From 56fb736e24782937283eda7a3c4ea6b25c2d1014 Mon Sep 17 00:00:00 2001
> From: Tim Howes <timhowes@lavabit.com>
> Date: Thu, 15 Oct 2020 19:52:04 -0700
> Subject: [PATCH v3] gnu: emacs-julia-mode: Update to 0.4.
>
> * gnu/packages/emacs-xyz.scm (emacs-julia-mode): Update to 0.4.

Applied, thanks! And sorry for the delay.

Ludo’.
Closed
?