[PATCH] linux-libre: Enable module compression.

OpenSubmitted by Mathieu Othacehe.
Details
3 participants
  • Ludovic Courtès
  • Mathieu Othacehe
  • Mathieu Othacehe
Owner
unassigned
Severity
normal
M
M
Mathieu Othacehe wrote 7 days ago
(address . guix-patches@gnu.org)(name . Mathieu Othacehe)(address . othacehe@gnu.org)
20200629142434.21308-1-othacehe@gnu.org
This commit enables GZIP compression for linux-libre kernel modules, reducingthe size of linux-libre by 63% (165MB). The initrd modules are keptuncompressed as the initrd is already compressed as a whole.
The linux-libre kernel also supports XZ compression, but as Guix does not haveany available bindings for now, and the compression time is far moresignificant, GZIP seems to be a better option.
* gnu/packages/aux-files/linux-libre/5.4-arm.conf: Enable GZ compression.* gnu/packages/aux-files/linux-libre/5.4-arm64.conf: Ditto.* gnu/packages/aux-files/linux-libre/5.4-i686.conf: Ditto.* gnu/packages/aux-files/linux-libre/5.4-x86_64.conf: Ditto.* gnu/build/linux-modules.scm (modinfo-section-contents): Use'call-with-gzip-input-port' to read from a module file using '.gz' extension,(strip-extension): new procedure,(dot-ko): adapt to support compression,(ensure-dot-ko): ditto,(file-name->module-name): ditto,(find-module-file): ditto,(load-linux-module*): ditto,(module-name->file-name/guess): ditto,(module-name-lookup): ditto,(write-module-name-database): ditto,(write-module-alias-database): ditto,(write-module-device-database): ditto.* gnu/system/linux-initrd.scm (flat-linux-module-directory): Make sure thatzlib bindings are available because they may be used in'write-module-device-database'. Also make sure that the initrd only containsuncompressed module files.---Hello,
I think the commit message pretty much describes this change. Just wanted toadd that it passes the loadable-kernel-modules-X tests.
Thanks,
Mathieu
gnu/build/linux-modules.scm | 102 ++++++++++++------ .../aux-files/linux-libre/5.4-arm.conf | 4 +- .../aux-files/linux-libre/5.4-arm64.conf | 4 +- .../aux-files/linux-libre/5.4-i686.conf | 4 +- .../aux-files/linux-libre/5.4-x86_64.conf | 4 +- gnu/system/linux-initrd.scm | 38 +++++-- 6 files changed, 111 insertions(+), 45 deletions(-)
Toggle diff (341 lines)diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scmindex aa1c7cfeae..7c6945a881 100644--- a/gnu/build/linux-modules.scm+++ b/gnu/build/linux-modules.scm@@ -21,6 +21,7 @@ (define-module (gnu build linux-modules) #:use-module (guix elf) #:use-module (guix glob)+ #:use-module (guix zlib) #:use-module (guix build syscalls) #:use-module ((guix build utils) #:select (find-files invoke)) #:use-module (guix build union)@@ -97,7 +98,16 @@ string list." (define (modinfo-section-contents file) "Return the contents of the '.modinfo' section of FILE as a list of key/value pairs.."- (let* ((bv (call-with-input-file file get-bytevector-all))+ (define (get-bytevector file)+ (cond+ ((string-contains file ".ko.gz")+ (call-with-input-file file+ (lambda (port)+ (call-with-gzip-input-port port get-bytevector-all))))+ (else+ (call-with-input-file file get-bytevector-all))))++ (let* ((bv (get-bytevector file)) (elf (parse-elf bv)) (section (elf-section-by-name elf ".modinfo")) (modinfo (section-contents elf section)))@@ -110,7 +120,7 @@ key/value pairs.." (define (module-formal-name file) "Return the module name of FILE as it appears in its info section. Usually the module name is the same as the base name of FILE, modulo hyphens and minus-the \".ko\" extension."+the \".ko[.gz|.xz]\" extension." (match (assq 'name (modinfo-section-contents file)) (('name . name) name) (#f #f)))@@ -171,14 +181,25 @@ modules that can be postloaded, of the soft dependencies of module FILE." (_ #f)) (modinfo-section-contents file)))) -(define dot-ko- (cut string-append <> ".ko"))--(define (ensure-dot-ko name)- "Return NAME with a '.ko' prefix appended, unless it already has it."- (if (string-suffix? ".ko" name)+(define (strip-extension filename)+ (let ((extension (string-index filename #\.)))+ (if extension+ (string-take filename extension)+ filename)))++(define (dot-ko name compression)+ (let ((suffix (match compression+ ('xz ".ko.xz")+ ('gzip ".ko.gz")+ (else ".ko"))))+ (string-append name suffix)))++(define (ensure-dot-ko name compression)+ "Return NAME with a '.ko[.gz|.xz]' suffix appended, unless it already has+it."+ (if (string-contains name ".ko") name- (dot-ko name)))+ (dot-ko name compression))) (define (normalize-module-name module) "Return the \"canonical\" name for MODULE, replacing hyphens with@@ -191,9 +212,9 @@ underscores." module)) (define (file-name->module-name file)- "Return the module name corresponding to FILE, stripping the trailing '.ko'-and normalizing it."- (normalize-module-name (basename file ".ko")))+ "Return the module name corresponding to FILE, stripping the trailing+'.ko[.gz|.xz]' and normalizing it."+ (normalize-module-name (strip-extension (basename file)))) (define (find-module-file directory module) "Lookup module NAME under DIRECTORY, and return its absolute file name.@@ -208,19 +229,19 @@ whereas file names often, but not always, use hyphens. Examples: ;; List of possible file names. XXX: It would of course be cleaner to ;; have a database that maps module names to file names and vice versa, ;; but everyone seems to be doing hacks like this one. Oh well!- (map ensure-dot-ko- (delete-duplicates- (list module- (normalize-module-name module)- (string-map (lambda (chr) ;converse of 'normalize-module-name'- (case chr- ((#\_) #\-)- (else chr)))- module)))))+ (delete-duplicates+ (list module+ (normalize-module-name module)+ (string-map (lambda (chr) ;converse of 'normalize-module-name'+ (case chr+ ((#\_) #\-)+ (else chr)))+ module)))) (match (find-files directory (lambda (file stat)- (member (basename file) names)))+ (member (strip-extension+ (basename file)) names))) ((file) file) (()@@ -290,8 +311,8 @@ not a file name." (recursive? #t) (lookup-module dot-ko) (black-list (module-black-list)))- "Load Linux module from FILE, the name of a '.ko' file; return true on-success, false otherwise. When RECURSIVE? is true, load its dependencies+ "Load Linux module from FILE, the name of a '.ko[.gz|.xz]' file; return true+on success, false otherwise. When RECURSIVE? is true, load its dependencies first (à la 'modprobe'.) The actual files containing modules depended on are obtained by calling LOOKUP-MODULE with the module name. Modules whose name appears in BLACK-LIST are not loaded."@@ -523,16 +544,27 @@ are required to access DEVICE." ;;; Module databases. ;;; -(define (module-name->file-name/guess directory name)+(define* (module-name->file-name/guess directory name+ #:key compression) "Guess the file name corresponding to NAME, a module name. That doesn't always work because sometimes underscores in NAME map to hyphens (e.g., \"input-leds.ko\"), sometimes not (e.g., \"mac_hid.ko\")."- (string-append directory "/" (ensure-dot-ko name)))+ (string-append directory "/" (ensure-dot-ko name compression))) (define (module-name-lookup directory) "Return a one argument procedure that takes a module name (e.g., \"input_leds\") and returns its absolute file name (e.g., \"/.../input-leds.ko\")."+ (define (guess-file-name name)+ (let ((names (list+ (module-name->file-name/guess directory name)+ (module-name->file-name/guess directory name+ #:compression 'xz)+ (module-name->file-name/guess directory name+ #:compression 'gzip))))+ (or (find file-exists? names)+ (first names))))+ (catch 'system-error (lambda () (define mapping@@ -541,23 +573,23 @@ always work because sometimes underscores in NAME map to hyphens (e.g., (lambda (name) (or (assoc-ref mapping name)- (module-name->file-name/guess directory name))))+ (guess-file-name name)))) (lambda args (if (= ENOENT (system-error-errno args))- (cut module-name->file-name/guess directory <>)+ (cut guess-file-name <>) (apply throw args))))) (define (write-module-name-database directory) "Write a database that maps \"module names\" as they appear in the relevant-ELF section of '.ko' files, to actual file names. This format is+ELF section of '.ko[.gz|.xz]' files, to actual file names. This format is Guix-specific. It aims to deal with inconsistent naming, in particular hyphens vs. underscores." (define mapping (map (lambda (file) (match (module-formal-name file)- (#f (cons (basename file ".ko") file))+ (#f (cons (strip-extension (basename file)) file)) (name (cons name file))))- (find-files directory "\\.ko$")))+ (find-files directory "\\.ko.*$"))) (call-with-output-file (string-append directory "/modules.name") (lambda (port)@@ -569,12 +601,12 @@ hyphens vs. underscores." (pretty-print mapping port)))) (define (write-module-alias-database directory)- "Traverse the '.ko' files in DIRECTORY and create the corresponding+ "Traverse the '.ko[.gz|.xz]' files in DIRECTORY and create the corresponding 'modules.alias' file." (define aliases (map (lambda (file) (cons (file-name->module-name file) (module-aliases file)))- (find-files directory "\\.ko$")))+ (find-files directory "\\.ko.*$"))) (call-with-output-file (string-append directory "/modules.alias") (lambda (port)@@ -616,7 +648,7 @@ are found, return a tuple (DEVNAME TYPE MAJOR MINOR), otherwise return #f." (char-set-complement (char-set #\-))) (define (write-module-device-database directory)- "Traverse the '.ko' files in DIRECTORY and create the corresponding+ "Traverse the '.ko[.gz|.xz]' files in DIRECTORY and create the corresponding 'modules.devname' file. This file contains information about modules that can be loaded on-demand, such as file system modules." (define aliases@@ -624,7 +656,7 @@ be loaded on-demand, such as file system modules." (match (aliases->device-tuple (module-aliases file)) (#f #f) (tuple (cons (file-name->module-name file) tuple))))- (find-files directory "\\.ko$")))+ (find-files directory "\\.ko.*$"))) (call-with-output-file (string-append directory "/modules.devname") (lambda (port)diff --git a/gnu/packages/aux-files/linux-libre/5.4-arm.conf b/gnu/packages/aux-files/linux-libre/5.4-arm.confindex a54228643b..7c9ab94719 100644--- a/gnu/packages/aux-files/linux-libre/5.4-arm.conf+++ b/gnu/packages/aux-files/linux-libre/5.4-arm.conf@@ -880,7 +880,9 @@ CONFIG_MODULE_FORCE_UNLOAD=y CONFIG_MODVERSIONS=y # CONFIG_MODULE_SRCVERSION_ALL is not set # CONFIG_MODULE_SIG is not set-# CONFIG_MODULE_COMPRESS is not set+CONFIG_MODULE_COMPRESS=y+CONFIG_MODULE_COMPRESS_GZIP=y+# CONFIG_MODULE_COMPRESS_XZ is not set # CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is not set # CONFIG_UNUSED_SYMBOLS is not set # CONFIG_TRIM_UNUSED_KSYMS is not setdiff --git a/gnu/packages/aux-files/linux-libre/5.4-arm64.conf b/gnu/packages/aux-files/linux-libre/5.4-arm64.confindex fabd25c6a4..6520d1ddf2 100644--- a/gnu/packages/aux-files/linux-libre/5.4-arm64.conf+++ b/gnu/packages/aux-files/linux-libre/5.4-arm64.conf@@ -781,7 +781,9 @@ CONFIG_MODVERSIONS=y CONFIG_ASM_MODVERSIONS=y # CONFIG_MODULE_SRCVERSION_ALL is not set # CONFIG_MODULE_SIG is not set-# CONFIG_MODULE_COMPRESS is not set+CONFIG_MODULE_COMPRESS=y+CONFIG_MODULE_COMPRESS_GZIP=y+# CONFIG_MODULE_COMPRESS_XZ is not set # CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is not set # CONFIG_UNUSED_SYMBOLS is not set # CONFIG_TRIM_UNUSED_KSYMS is not setdiff --git a/gnu/packages/aux-files/linux-libre/5.4-i686.conf b/gnu/packages/aux-files/linux-libre/5.4-i686.confindex 50a41f6cc9..3727f9d486 100644--- a/gnu/packages/aux-files/linux-libre/5.4-i686.conf+++ b/gnu/packages/aux-files/linux-libre/5.4-i686.conf@@ -850,7 +850,9 @@ CONFIG_MODVERSIONS=y CONFIG_ASM_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y # CONFIG_MODULE_SIG is not set-# CONFIG_MODULE_COMPRESS is not set+CONFIG_MODULE_COMPRESS=y+CONFIG_MODULE_COMPRESS_GZIP=y+# CONFIG_MODULE_COMPRESS_XZ is not set # CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is not set CONFIG_UNUSED_SYMBOLS=y CONFIG_MODULES_TREE_LOOKUP=ydiff --git a/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.4-x86_64.confindex 30fdc4e86a..be7a603af1 100644--- a/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf+++ b/gnu/packages/aux-files/linux-libre/5.4-x86_64.conf@@ -849,7 +849,9 @@ CONFIG_MODVERSIONS=y CONFIG_ASM_MODVERSIONS=y CONFIG_MODULE_SRCVERSION_ALL=y # CONFIG_MODULE_SIG is not set-# CONFIG_MODULE_COMPRESS is not set+CONFIG_MODULE_COMPRESS=y+CONFIG_MODULE_COMPRESS_GZIP=y+# CONFIG_MODULE_COMPRESS_XZ is not set # CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is not set CONFIG_UNUSED_SYMBOLS=y CONFIG_MODULES_TREE_LOOKUP=ydiff --git a/gnu/system/linux-initrd.scm b/gnu/system/linux-initrd.scmindex 0971ec29e2..99ec82246b 100644--- a/gnu/system/linux-initrd.scm+++ b/gnu/system/linux-initrd.scm@@ -111,11 +111,29 @@ the derivations referenced by EXP are automatically copied to the initrd." (define (flat-linux-module-directory linux modules) "Return a flat directory containing the Linux kernel modules listed in MODULES and taken from LINUX."+ (define zlib+ (module-ref (resolve-interface '(gnu packages compression)) 'zlib))++ (define config.scm+ (scheme-file "config.scm"+ #~(begin+ (define-module (guix config)+ #:export (%libz))++ (define %libz+ #+(file-append zlib "/lib/libz")))))++ (define imported-modules+ (cons `((guix config) => ,config.scm)+ (delete '(guix config)+ (source-module-closure '((gnu build linux-modules)+ (guix build utils))))))+ (define build-exp- (with-imported-modules (source-module-closure- '((gnu build linux-modules)))+ (with-imported-modules imported-modules #~(begin (use-modules (gnu build linux-modules)+ (guix build utils) (srfi srfi-1) (srfi srfi-26)) @@ -129,12 +147,20 @@ MODULES and taken from LINUX." (recursive-module-dependencies modules #:lookup-module lookup)))) + (define (maybe-uncompress file)+ ;; If FILE is a compressed module, uncompress it, as the initrd is+ ;; already gzipped as a whole.+ (cond+ ((string-contains file ".ko.gz")+ (invoke #+(file-append gzip "/bin/gunzip") file))))+ (mkdir #$output) (for-each (lambda (module)- (format #t "copying '~a'...~%" module)- (copy-file module- (string-append #$output "/"- (basename module))))+ (let ((out-module+ (string-append #$output "/" (basename module))))+ (format #t "copying '~a'...~%" module)+ (copy-file module out-module)+ (maybe-uncompress out-module))) (delete-duplicates modules)) ;; Hyphen or underscore? This database tells us.-- 2.26.2
M
M
Mathieu Othacehe wrote 6 days ago
(address . 42123@debbugs.gnu.org)
87a70l103p.fsf@gnu.org
Hello,
There's at least one issue with this one. When running the"installation-os" test, I have this backtrace:
Toggle snippet (32 lines)+ guix system init /mnt/etc/config.scm /mnt --no-substitutesThe following derivations will be built: /gnu/store/rlq93i0ahllyvmjxk14w3snmqsv7bsvg-system.drv /gnu/store/28cfjshgch8jyixmwv3q0x1ybniwlvf5-parameters.drv /gnu/store/vk3rw7qwm7p0ldy34cadzgczxx2hc5xf-raw-initrd.drv /gnu/store/w219h1ia74bkplvr622f0b8qxyi9xw7y-provenance.drv /gnu/store/z56pp4bw5hif9mh856cckqvfnvykaybh-profile.drv /gnu/store/xalv7fm73cpyyi3zyvy1zlb26nfi1fb6-module-import-compiled.drv /gnu/store/rmpwh65ypvv1805zwmcir8gk9b53c4gz-module-import-compiled.drv /gnu/store/l9ixrby1zjqvdc719lyvfp9n9n4hb5pv-grub.cfg.drvThe following profile hook will be built: /gnu/store/92giwj2f8jyq90l20q19vcvds18v9xf4-linux-module-database.drvbuilding /gnu/store/w219h1ia74bkplvr622f0b8qxyi9xw7y-provenance.drv...building /gnu/store/k4m2pj7sadz4vv5aaz40f68gaa4mw36b-Python-3.5.9.tar.xz.drv...\builder for `/gnu/store/k4m2pj7sadz4vv5aaz40f68gaa4mw36b-Python-3.5.9.tar.xz.drv' failed to produce output path `/gnu/store/f99fblkzb6ip268sg096shhs7wzjyp55-Python-3.5.9.tar.xz'build of /gnu/store/k4m2pj7sadz4vv5aaz40f68gaa4mw36b-Python-3.5.9.tar.xz.drv failedView build log at '/var/log/guix/drvs/k4/m2pj7sadz4vv5aaz40f68gaa4mw36b-Python-3.5.9.tar.xz.drv.bz2'.cannot build derivation `/gnu/store/9l09n8d6ick1nsjvchysys3hdgq7ynfr-Python-3.5.9.tar.xz.drv': 1 dependencies couldn't be builtbuilding /gnu/store/wd9giqyfcfm1wgc6rscl3m9i30hg6rcs-bash-2.05b.tar.gz.drv...cannot build derivation `/gnu/store/66q0r5cr3j1cbwckx5zvi0wv4cp3kxgl-python-minimal-3.5.9.drv': 1 dependencies couldn't be builtcannot build derivation `/gnu/store/c2ly303cbslks8hx3811wa91wahqr295-glibc-2.31.drv': 1 dependencies couldn't be builtbuilding /gnu/store/h1p3962y3bmv1zgwsng1gb4c7caryj82-config.scm.drv...cannot build derivation `/gnu/store/97vna9jgn19hyfx24s2kd6c3wywg22wl-e2fsprogs-1.45.6.drv': 1 dependencies couldn't be builtcannot build derivation `/gnu/store/r4dg2iypidr067kyddg90z07arrxp3h6-e2fsck-static-1.45.6.drv': 1 dependencies couldn't be builtcannot build derivation `/gnu/store/64f1y8njbd8bppl61fm6dhljnlgmh3h2-init.drv': 1 dependencies couldn't be builtbuilding /gnu/store/6v5f1ry0pbhm2a1v5v8b773qpncnf6rr-module-import-compiled.drv...cannot build derivation `/gnu/store/vk3rw7qwm7p0ldy34cadzgczxx2hc5xf-raw-initrd.drv': 1 dependencies couldn't be builtcannot build derivation `/gnu/store/l9ixrby1zjqvdc719lyvfp9n9n4hb5pv-grub.cfg.drv': 1 dependencies couldn't be builtguix system: error: build of `/gnu/store/l9ixrby1zjqvdc719lyvfp9n9n4hb5pv-grub.cfg.drv' failedenvironment variable `PATH' set to `/gnu/store/a2b10x6h8j8qgsrcqip06xhnbssa0k25-qemu-minimal-5.0.0/bin'
For some reason, something triggers a build of the initrd (instead of usingthe gcrooted one). I guess it's related to the addition of "zlib" and"gzip" to the initrd inputs, but I don't understand why.
Someone?
Thanks,
Mathieu
L
L
Ludovic Courtès wrote 4 days ago
(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)
87366atdve.fsf@gnu.org
Hi!
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
Toggle quote (30 lines)> This commit enables GZIP compression for linux-libre kernel modules, reducing> the size of linux-libre by 63% (165MB). The initrd modules are kept> uncompressed as the initrd is already compressed as a whole.>> The linux-libre kernel also supports XZ compression, but as Guix does not have> any available bindings for now, and the compression time is far more> significant, GZIP seems to be a better option.>> * gnu/packages/aux-files/linux-libre/5.4-arm.conf: Enable GZ compression.> * gnu/packages/aux-files/linux-libre/5.4-arm64.conf: Ditto.> * gnu/packages/aux-files/linux-libre/5.4-i686.conf: Ditto.> * gnu/packages/aux-files/linux-libre/5.4-x86_64.conf: Ditto.> * gnu/build/linux-modules.scm (modinfo-section-contents): Use> 'call-with-gzip-input-port' to read from a module file using '.gz' extension,> (strip-extension): new procedure,> (dot-ko): adapt to support compression,> (ensure-dot-ko): ditto,> (file-name->module-name): ditto,> (find-module-file): ditto,> (load-linux-module*): ditto,> (module-name->file-name/guess): ditto,> (module-name-lookup): ditto,> (write-module-name-database): ditto,> (write-module-alias-database): ditto,> (write-module-device-database): ditto.> * gnu/system/linux-initrd.scm (flat-linux-module-directory): Make sure that> zlib bindings are available because they may be used in> 'write-module-device-database'. Also make sure that the initrd only contains> uncompressed module files.
Nice!
I do think that gzip is more appropriate than xz here, also in terms ofmemory requirements.
Perhaps you can do this in two patches: first the linux-initrd bits, and2nd the linux-libre changes.
Toggle quote (21 lines)> diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm> index aa1c7cfeae..7c6945a881 100644> --- a/gnu/build/linux-modules.scm> +++ b/gnu/build/linux-modules.scm> @@ -21,6 +21,7 @@> (define-module (gnu build linux-modules)> #:use-module (guix elf)> #:use-module (guix glob)> + #:use-module (guix zlib)> #:use-module (guix build syscalls)> #:use-module ((guix build utils) #:select (find-files invoke))> #:use-module (guix build union)> @@ -97,7 +98,16 @@ string list."> (define (modinfo-section-contents file)> "Return the contents of the '.modinfo' section of FILE as a list of> key/value pairs.."> - (let* ((bv (call-with-input-file file get-bytevector-all))> + (define (get-bytevector file)> + (cond> + ((string-contains file ".ko.gz")
‘string-suffix?’ would be more accurate.
Toggle quote (4 lines)> + (call-with-input-file file> + (lambda (port)> + (call-with-gzip-input-port port get-bytevector-all))))
‘call-with-input-file’ creates a buffered port, which could beproblematic, although ‘make-gzip-input-port’ checks that.
To be safe, you’d do (open-file file "r0") with a dynwind.
Toggle quote (6 lines)> +(define* (module-name->file-name/guess directory name> + #:key compression)> "Guess the file name corresponding to NAME, a module name. That doesn't> always work because sometimes underscores in NAME map to hyphens (e.g.,> \"input-leds.ko\"), sometimes not (e.g., \"mac_hid.ko\")."
Please mention COMPRESSION in the docstring.
Toggle quote (10 lines)> (define (write-module-alias-database directory)> - "Traverse the '.ko' files in DIRECTORY and create the corresponding> + "Traverse the '.ko[.gz|.xz]' files in DIRECTORY and create the corresponding> 'modules.alias' file."> (define aliases> (map (lambda (file)> (cons (file-name->module-name file) (module-aliases file)))> - (find-files directory "\\.ko$")))> + (find-files directory "\\.ko.*$")))
Should we refine this regexp (there are a couple of places like this)?
There other Scheme bits LGTM!
(I don’t really know about Linux-libre but you do!)
Ludo’.
?