lib2geom fails tests on i686-linux

  • Done
  • quality assurance status badge
Details
2 participants
  • Marius Bakke
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Marius Bakke
Severity
normal
M
M
Marius Bakke wrote on 12 Jun 2020 14:30
(address . bug-guix@gnu.org)
87bllofoui.fsf@gnu.org
lib2geom fails several tests on i686-linux:


This is a dependency of Inkscape 1.0.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7jdXUACgkQoqBt8qM6
VPo2sQf+PS8aS+3zGODPbwKFfAU3AeKrh5sxHG9EcorHfqHcs29lb5ctoA/7mbXc
ZRw5f/ZFMFhxf7vL3XUDKDSlV7u5nbJVLTyiSXh6/c37fY/GHG/h6zYtHjhYlcb3
9bsjV5Dn1B16YoueLr7DvItWtf3Ad/4NoqYA6UffJDYyQUlCHFjk+7szHl72qQCY
wayhTtlNevC3St3MQS9Z6zGeuggciSB/3Wk3tBVieSe/OoCh6UqL5tz1UM4+cUyw
HUteJDRyc01YSVbtmTDurDYu8NRrHRcM942U0hRNaoHOAx45lCmL6dGopx71Zyc/
U6DpmwLGY142fldVfxwt5e31CYB4Yg==
=b+RX
-----END PGP SIGNATURE-----

M
M
Marius Bakke wrote on 12 Jun 2020 14:33
(address . 41827@debbugs.gnu.org)
878sgsfoq2.fsf@gnu.org
Marius Bakke <marius@gnu.org> writes:

Toggle quote (6 lines)
> lib2geom fails several tests on i686-linux:
>
> https://ci.guix.gnu.org/log/h3d9i8jqygnc3qvcd83c678kzmr5p4b7-lib2geom-1.0-1.42e119d
>
> This is a dependency of Inkscape 1.0.

The same tests also fail on aarch64-linux:


armhf-linux and x86_64-linux seems fine.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7jdhUACgkQoqBt8qM6
VPpzeggAouaAlE5eSMhxB7mMcX5iTjJcuz2qV2GKo402E9O4DMwRMFilMDthnOhx
bC++9Axgpo9w7cuZ01WxIXvIOg/4EHuU1Fmsr0N0QkGyO0VMFCdaOhTVZkevdmXa
RYb+7XQpsGHQNhnY+qCqxDlCT/SUcwPpKwqcavva+fzcTx+bKLosoXWgr5I3Bsi0
YoV9aOgThZd53xpCLpW4RJGQFbi80Ldr6wKTkbB+TL0nyK4mc7CKbiJIXvSOtdg2
UDWjKr0EqjXfw43PjebjI77ZxxWPO8W+uO9gYzw5TuJ57ERBMFh25210mLT1n8f8
eSM/28jd9S2JJN1NFRBPXXwXvTCL9A==
=KBv0
-----END PGP SIGNATURE-----

M
M
Maxim Cournoyer wrote on 14 Jun 2020 21:19
(name . Marius Bakke)(address . marius@gnu.org)(address . 41827@debbugs.gnu.org)
875zbth2uf.fsf@gmail.com
Hello Marius,

Marius Bakke <marius@gnu.org> writes:

Toggle quote (14 lines)
> Marius Bakke <marius@gnu.org> writes:
>
>> lib2geom fails several tests on i686-linux:
>>
>> https://ci.guix.gnu.org/log/h3d9i8jqygnc3qvcd83c678kzmr5p4b7-lib2geom-1.0-1.42e119d
>>
>> This is a dependency of Inkscape 1.0.
>
> The same tests also fail on aarch64-linux:
>
> https://ci.guix.gnu.org/log/rq7d8y0b8cv7ils7wd3fq97br8j3d4xz-lib2geom-1.0-1.42e119d
>
> armhf-linux and x86_64-linux seems fine.

I had a quick look of the output, and it seems the failures are due to
comparison of inexact numbers. A quick idea would be to make sure that
the test suite is making use of Googletest's floating point comparison
macros, which are designed to handle variations on floats [0].

If that's the flaw, we sould implement a patch and contribute it to
upstream.

Maxim
M
M
Maxim Cournoyer wrote on 18 Jun 2020 08:28
(name . Marius Bakke)(address . marius@gnu.org)(address . 41827@debbugs.gnu.org)
87366sevl7.fsf@gmail.com
Hello,

I think I've fixed it with commit 620796e66b.

Maxim
M
M
Maxim Cournoyer wrote on 19 Jun 2020 05:32
(name . Marius Bakke)(address . marius@gnu.org)(address . 41827-done@debbugs.gnu.org)
87r1ubd93b.fsf@gmail.com
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

Toggle quote (4 lines)
> Hello,
>
> I think I've fixed it with commit 620796e66b.

Closing,

Maxim
Closed
?