Hello,
Fredrik Salomonsson <plattfot@gmail.com> writes:
Toggle quote (2 lines)
> * gnu/packages/emacs-xyz.scm (emacs-flymake-shellcheck): New variable.
Thank you. Some comments follow.
Toggle quote (3 lines)
> + (propagated-inputs> + `(("shellcheck" ,shellcheck)))
I don't think we should do that. It is up to the user to installShellCheck if they want.
For example, installing `emacs-flycheck-haskell' doesn't pull GHC inuser's profile.
Toggle quote (5 lines)
> + (home-page "https://github.com/federicotdn/flymake-shellcheck")> + (synopsis "Flymake backend for Bash/Sh powered by ShellCheck")> + (description> + "This package provides a backend for Flymake (emacs-26+) to use the
Nitpick: you can remove the (emacs-26+) part.
Toggle quote (2 lines)
> +tool @command{shellcheck} for static analyzing @command{bash} and @command{sh}
Nitpick: since you seem to talk about the tool as a whole, I suggest:
@command{shellcheck} -> ShellCheck
Toggle quote (3 lines)
> +scripts. Please see the description on @command{shellcheck} for more> +information on what it can do."
I think you can remove the last sentence.
Could you send an updated patch?
Regards,
-- Nicolas Goaziou