Hi Marius,
you have an impressive pensum!Thanks for the review!
Marius Bakke <marius@gnu.org> writes:
Toggle quote (5 lines)
>> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.>> Thanks! It LGTM but no longer applies, can you rebase it on the current> master branch?
done.
Toggle quote (4 lines)
>> + (synopsis "Visual Bookmarks for Emacs")> ^^^> Lowercase 'b'.
done.
Toggle quote (9 lines)
>> + (description "This package provides visible, buffer local, bookmarks and>> +the ability to jump forward and backward to the next bookmark.")>> The description reads a bit weird, I wonder if...>> "visible, buffer local bookmarks" (without the second comma)>> ...is more correct?
seems more correct, yes => done.
From b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001
* gnu/packages/emacs-xyz.scm (emacs-bm): New variable.--- gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
Toggle diff (33 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scmindex 6d82e1921c..9cf4cdd6a1 100644--- a/gnu/packages/emacs-xyz.scm+++ b/gnu/packages/emacs-xyz.scm@@ -1918,6 +1918,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlinks and doing full-text searches. Unlike code@{emacs-wiki.el}, it can be combined with any format.") (license license:gpl1+))) +(define-public emacs-bm+ (package+ (name "emacs-bm")+ (version "201905")+ (source+ (origin+ (method git-fetch)+ (uri (git-reference+ (url "https://github.com/joodland/bm.git")+ (commit version)))+ (file-name (git-file-name name version))+ (sha256+ (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))+ (build-system emacs-build-system)+ (home-page "https://github.com/joodland/bm")+ (synopsis "Visual bookmarks for Emacs")+ (description "This package provides visible, buffer local bookmarks and+the ability to jump forward and backward to the next bookmark.")+ (license license:gpl2+)))+ (define-public emacs-calfw (package (name "emacs-calfw")-- 2.26.2-- In short, I think gcc should be fixed, or at the very least it should be a_documented_ bug at which point I have no gripe with fixing it in thekernel. But I refuse to work around undocumented bugs - that starts tosmell too much like microsoft, and then I might as well start usingWindows myself. Linus
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl7SnhMACgkQfHr/vv7yyyWXwgf9E6UTdgVjlbf/PRGlHC33Und17h7/7wrNaW2c12zXSedHTb4cZ7vHZS1DC+WHrpfd3b3S71ITy71YXsjdAM02yupNZ2BalzJr34+e78ROKvJfNy7i1OMbbb7z644FXLciXoZqJPcRLhp6xtPmOTjrZqJq+NFgvJNcac1DlB9BZbIbadyvEIriHiHlCKhCgaYDkBa+0AQyCuF13eiPMvrY8NRqZHyXeVX9t0xODU/cOMEeVuS16ABo/KDc4w6PVeF9y+O45t5hhzDu7iPa5EeLuYI2rH6UTuNy9gzQj9KjeEQDjsxTjuP90uxw0VdNs6QkvenSZupeZYFTiBZQcOUXcQ===0ttF-----END PGP SIGNATURE-----