[PATCH] gnu: icedove: Add a desktop file.

Jonathan Brielmaier wrote on 14 May 2020 13:49

Recipients:(address . guix-patches@gnu.org)(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)

Message-ID:20200514114953.4457-1-jonathan.brielmaier@web.de

Thunderbird upstream doesn't provide any desktop file. So we haveto create it downstream. I filed an upstream bug:https://bugzilla.mozilla.org/show_bug.cgi?id=1637575
* gnu/packages/gnuzilla.scm (icedove)[phases]: Add install-desktop-file phase.--- gnu/packages/gnuzilla.scm | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)

Toggle diff (37 lines)diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scmindex 8a926681e0..7bf9850e97 100644--- a/gnu/packages/gnuzilla.scm+++ b/gnu/packages/gnuzilla.scm@@ -1344,6 +1344,32 @@ standards of the IceCat project.")            (lambda _ (invoke "./mach" "build")))          (replace 'install            (lambda _ (invoke "./mach" "install")))+         ;; Thunderbird doesn't provide any .desktop file.+         ;; See https://bugzilla.mozilla.org/show_bug.cgi?id=1637575+         (add-after 'install 'install-desktop-file+           (lambda* (#:key outputs #:allow-other-keys)+             (let* ((out (assoc-ref outputs "out"))+                    (apps (string-append out "/share/applications")))+               (mkdir-p apps)+               (with-output-to-file (string-append apps "/icedove.desktop")+                 (lambda _+                   (format #t+                           "[Desktop Entry]~@+                            Name=Icedove~@+                            Exec=~a/bin/icedove~@+                            Icon=icedove~@+                            GenericName=Mail/News Client~@+                            Categories=Network;Email;~@+                            Terminal=false~@+                            StartupNotify=true~@+                            MimeType=x-scheme-handler/mailto;~@+                            Type=Application~@+                            Actions=ComposeMessage;~@+                            [Desktop Action ComposeMessage]~@+                            Name=Write new message~@+                            Exec=~@*~a/bin/icedove -compose~%"+                           out))))+             #t))          (add-after 'install 'wrap-program            (lambda* (#:key inputs outputs #:allow-other-keys)              (let* ((out (assoc-ref outputs "out"))

--2.26.2

Ricardo Wurmus via web wrote on 14 May 2020 14:50

Recipients:(address . 41256@debbugs.gnu.org)

Message-ID:7f41efd29560.101e2b8fb1797f28@guile.gnu.org

This looks good to me!

Jonathan Brielmaier wrote on 15 May 2020 10:56

Recipients:

Message-ID:07536394-a6a9-d6d0-461d-1c208559cd6d@web.de

so is this good for push? I cannot do that myself.
On 14.05.20 14:50, Ricardo Wurmus via web wrote:

Toggle quote (5 lines)> This looks good to me!>>>>

Marius Bakke wrote on 23 May 2020 21:16

Recipients:(name . Jonathan Brielmaier)(address . jonathan.brielmaier@web.de)

Message-ID:87imgm797g.fsf@devup.no

Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:

Toggle quote (6 lines)

> Thunderbird upstream doesn't provide any desktop file. So we have> to create it downstream. I filed an upstream bug:> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add install-desktop-file phase.

Applied, thanks!

Closed

Nicolas Goaziou wrote on 23 May 2020 21:56

Re: bug#41256: [PATCH] gnu: icedove: Add a desktop file.

Recipients:(address . 41256@debbugs.gnu.org)

Message-ID:87pnaubf2w.fsf@nicolasgoaziou.fr

Hello,
Marius Bakke <mbakke@fastmail.com> writes:

Toggle quote (9 lines)

> Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:>>> Thunderbird upstream doesn't provide any desktop file. So we have>> to create it downstream. I filed an upstream bug:>> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575>>>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add>> install-desktop-file phase.

I'm a bit late at the party, but would it make sense to usemake-desktop-entry-file instead?
Regards,
-- Nicolas Goaziou

Marius Bakke wrote on 23 May 2020 22:18

Recipients:(address . jonathan.brielmaier@web.de)

Message-ID:878shi76c2.fsf@devup.no

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

Toggle quote (16 lines)> Hello,>> Marius Bakke <mbakke@fastmail.com> writes:>>> Jonathan Brielmaier <jonathan.brielmaier@web.de> writes:>>>>> Thunderbird upstream doesn't provide any desktop file. So we have>>> to create it downstream. I filed an upstream bug:>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1637575>>>>>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add>>> install-desktop-file phase.>> I'm a bit late at the party, but would it make sense to use> make-desktop-entry-file instead?

Probably, yes. :-)

Jonathan Brielmaier wrote on 23 May 2020 23:47

Recipients:(address . mbakke@fastmail.com)

Message-ID:9660323d-6b9f-5094-e01d-d3f923aea6f7@web.de

On 23.05.20 21:56, Nicolas Goaziou wrote:

Toggle quote (5 lines)>>> * gnu/packages/gnuzilla.scm (icedove)[phases]: Add>>> install-desktop-file phase.>> I'm a bit late at the party, but would it make sense to use> make-desktop-entry-file instead?

Oh Nicolas that is a good catch. I didn't know this nice function :P
But I wonder how to archive the compose action:```[Desktop Action ComposeMessage]~@Name=Write new message~@Exec=~@*~a/bin/icedove -compose~%"```
With the field `actions` but how?

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 41256@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date