[PATCH] gnu: Add gnome-shell-extension-clipboard-indicator.

Recipients:(address . guix-patches@gnu.org)

Message-ID:20200504223005.11419-1-jackhill@jackhill.us

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):New variable.--- gnu/packages/gnome-xyz.scm | 42 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+)

Toggle diff (55 lines)diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scmindex 625248a25a..ee5176d22a 100644--- a/gnu/packages/gnome-xyz.scm+++ b/gnu/packages/gnome-xyz.scm@@ -148,6 +148,48 @@ GNOME Shell.")     (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")     (license license:gpl2+))) +(define-public gnome-shell-extension-clipboard-indicator+  (package+    (name "gnome-shell-extension-clipboard-indicator")+    (version "34")+    (source (origin+              (method git-fetch)+              (uri (git-reference+                    (url (string-append "https://github.com/Tudmotu/"+                                        "gnome-shell-extension-clipboard-indicator.git"))+                    (commit (string-append "v" version))))+              (file-name (git-file-name name version))+              (sha256+               (base32+                "0i00psc1ky70zljd14jzr627y7nd8xwnwrh4xpajl1f6djabh12s"))+              (modules '((guix build utils)))+              (snippet+               '(begin (delete-file "schemas/gschemas.compiled")+                       (for-each delete-file (find-files "locale" "\\.mo$"))+                       #t))))+    (build-system copy-build-system)+    (arguments+     '(#:install-plan+       '(("." "share/gnome-shell/extensions/clipboard-indicator@tudmotu.com"+          #:include-regexp ("\\.css$" "\\.compiled$" "\\.js(on)?$" "\\.mo$" "\\.xml$")))+       #:phases+       (modify-phases %standard-phases+         (add-before 'install 'compile-schemas+           (lambda _+             (with-directory-excursion "schemas"+               (invoke "glib-compile-schemas" "."))+             #t))+         (add-before 'install 'compile-locales+           (lambda _ (invoke "./compile-locales.sh"))))))+    (native-inputs+     `(("gettext" ,gettext-minimal)+       ("glib:bin" ,glib "bin")))       ; for glib-compile-schemas+    (home-page "https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator")+    (synopsis "Clipboard manager extension for GNOME Shell")+    (description "Clipboard Indicator is a clipboard manager for GNOME Shell+that caches clipboard history.")+    (license license:expat)))+ (define-public gnome-shell-extension-topicons-redux   (package     (name "gnome-shell-extension-topicons-redux")-- 2.26.2

Jack Hill wrote on 5 May 00:40 +0200

[PATCH v2] gnu: Add gnome-shell-extension-clipboard-indicator.

Recipients:(address . 41088@debbugs.gnu.org)

Message-ID:20200504224036.11979-1-jackhill@jackhill.us

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):New variable.---
New in this version: Now all phases return #t
gnu/packages/gnome-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)

Toggle diff (56 lines)diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scmindex 625248a25a..26de92c2c9 100644--- a/gnu/packages/gnome-xyz.scm+++ b/gnu/packages/gnome-xyz.scm@@ -148,6 +148,49 @@ GNOME Shell.")     (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")     (license license:gpl2+))) +(define-public gnome-shell-extension-clipboard-indicator+  (package+    (name "gnome-shell-extension-clipboard-indicator")+    (version "34")+    (source (origin+              (method git-fetch)+              (uri (git-reference+                    (url (string-append "https://github.com/Tudmotu/"+                                        "gnome-shell-extension-clipboard-indicator.git"))+                    (commit (string-append "v" version))))+              (file-name (git-file-name name version))+              (sha256+               (base32+                "0i00psc1ky70zljd14jzr627y7nd8xwnwrh4xpajl1f6djabh12s"))+              (modules '((guix build utils)))+              (snippet+               '(begin (delete-file "schemas/gschemas.compiled")+                       (for-each delete-file (find-files "locale" "\\.mo$"))+                       #t))))+    (build-system copy-build-system)+    (arguments+     '(#:install-plan+       '(("." "share/gnome-shell/extensions/clipboard-indicator@tudmotu.com"+          #:include-regexp ("\\.css$" "\\.compiled$" "\\.js(on)?$" "\\.mo$" "\\.xml$")))+       #:phases+       (modify-phases %standard-phases+         (add-before 'install 'compile-schemas+           (lambda _+             (with-directory-excursion "schemas"+               (invoke "glib-compile-schemas" "."))+             #t))+         (add-before 'install 'compile-locales+           (lambda _ (invoke "./compile-locales.sh")+                   #t)))))+    (native-inputs+     `(("gettext" ,gettext-minimal)+       ("glib:bin" ,glib "bin")))       ; for glib-compile-schemas+    (home-page "https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator")+    (synopsis "Clipboard manager extension for GNOME Shell")+    (description "Clipboard Indicator is a clipboard manager for GNOME Shell+that caches clipboard history.")+    (license license:expat)))+ (define-public gnome-shell-extension-topicons-redux   (package     (name "gnome-shell-extension-topicons-redux")-- 2.26.2

Marius Bakke wrote on 5 May 20:06 +0200

Recipients:

Message-ID:87imhaxnnb.fsf@devup.no

Jack Hill <jackhill@jackhill.us> writes:

Toggle quote (3 lines)

> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):> New variable.

Thanks!
[...]

Toggle quote (5 lines)

> + (snippet> + '(begin (delete-file "schemas/gschemas.compiled")> + (for-each delete-file (find-files "locale" "\\.mo$"))> + #t))))

Can you add a comment about why this is necessary?
Otherwise LGTM.

Jack Hill wrote on 5 May 22:11 +0200

Recipients:(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 41088@debbugs.gnu.org)

Message-ID:alpine.DEB.2.20.2005051606340.5735@marsh.hcoop.net

On Tue, 5 May 2020, Marius Bakke wrote:

Toggle quote (9 lines)

> Jack Hill <jackhill@jackhill.us> writes:>>> + (snippet>> + '(begin (delete-file "schemas/gschemas.compiled")>> + (for-each delete-file (find-files "locale" "\\.mo$"))>> + #t))))>> Can you add a comment about why this is necessary?

I've added a commend and will send the updated patch shortly. However, I may have been wrong to remove these files as part of the snippet. I did it because the removed files are not source form, but instead can be generated from source during the package build. I believe that upstream includes them in the code repository because it is common for people to install GNOME Shell extensions by directly cloning the repo in their home directories.

Toggle quote (2 lines)

> Otherwise LGTM.

Thanks for the review.
Best,Jack

Jack Hill wrote on 5 May 22:12 +0200

[PATCH v3] gnu: Add gnome-shell-extension-clipboard-indicator.

Recipients:(address . 41088@debbugs.gnu.org)(name . Marius Bakke)(address . mbakke@fastmail.com)

Message-ID:20200505201255.29313-1-jackhill@jackhill.us

* gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):New variable.---
New in this version: Added comment about why compiled schemas andtranslations are removed as part of the source snippet.
gnu/packages/gnome-xyz.scm | 47 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+)

Toggle diff (60 lines)diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scmindex 625248a25a..41c341fd41 100644--- a/gnu/packages/gnome-xyz.scm+++ b/gnu/packages/gnome-xyz.scm@@ -148,6 +148,53 @@ GNOME Shell.")     (home-page "https://github.com/ubuntu/gnome-shell-extension-appindicator/")     (license license:gpl2+))) +(define-public gnome-shell-extension-clipboard-indicator+  (package+    (name "gnome-shell-extension-clipboard-indicator")+    (version "34")+    (source (origin+              (method git-fetch)+              (uri (git-reference+                    (url (string-append "https://github.com/Tudmotu/"+                                        "gnome-shell-extension-clipboard-indicator.git"))+                    (commit (string-append "v" version))))+              (file-name (git-file-name name version))+              (sha256+               (base32+                "0i00psc1ky70zljd14jzr627y7nd8xwnwrh4xpajl1f6djabh12s"))+              (modules '((guix build utils)))+              (snippet+               ;; Remove pre-compiled settings schemas and translations from+               ;; source, as they are generated as part of build. Upstream+               ;; includes them for people who want to run the software+               ;; directly from source tree.+               '(begin (delete-file "schemas/gschemas.compiled")+                       (for-each delete-file (find-files "locale" "\\.mo$"))+                       #t))))+    (build-system copy-build-system)+    (arguments+     '(#:install-plan+       '(("." "share/gnome-shell/extensions/clipboard-indicator@tudmotu.com"+          #:include-regexp ("\\.css$" "\\.compiled$" "\\.js(on)?$" "\\.mo$" "\\.xml$")))+       #:phases+       (modify-phases %standard-phases+         (add-before 'install 'compile-schemas+           (lambda _+             (with-directory-excursion "schemas"+               (invoke "glib-compile-schemas" "."))+             #t))+         (add-before 'install 'compile-locales+           (lambda _ (invoke "./compile-locales.sh")+                   #t)))))+    (native-inputs+     `(("gettext" ,gettext-minimal)+       ("glib:bin" ,glib "bin")))       ; for glib-compile-schemas+    (home-page "https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator")+    (synopsis "Clipboard manager extension for GNOME Shell")+    (description "Clipboard Indicator is a clipboard manager for GNOME Shell+that caches clipboard history.")+    (license license:expat)))+ (define-public gnome-shell-extension-topicons-redux   (package     (name "gnome-shell-extension-topicons-redux")-- 2.26.2

Marius Bakke wrote on 6 May 22:32 +0200

Recipients:

Message-ID:874kss4xem.fsf@devup.no

Jack Hill <jackhill@jackhill.us> writes:

Toggle quote (3 lines)

> * gnu/packages/gnome-xyz.scm (gnome-shell-extension-clipboard-indicator):> New variable.

Applied, thanks!

Closed

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date