On Tue, 5 May 2020, Marius Bakke wrote:
Toggle quote (9 lines)
> Jack Hill <jackhill@jackhill.us> writes:>>> + (snippet>> + '(begin (delete-file "schemas/gschemas.compiled")>> + (for-each delete-file (find-files "locale" "\\.mo$"))>> + #t))))>> Can you add a comment about why this is necessary?
I've added a commend and will send the updated patch shortly. However, I may have been wrong to remove these files as part of the snippet. I did it because the removed files are not source form, but instead can be generated from source during the package build. I believe that upstream includes them in the code repository because it is common for people to install GNOME Shell extensions by directly cloning the repo in their home directories.
Toggle quote (2 lines)
> Otherwise LGTM.
Thanks for the review.
Best,Jack