Jean-Baptiste Note <jean-baptiste.note@m4x.org> writes:
Toggle quote (9 lines)
> Hi Marius,>> Thanks for your review and the heads up on the correct file.> Please find an updated patch.>> I've used guix-devel-mode and ran indent-according-to-mode on the buffer> before producing the patch; let me know if this is not sufficient to> correctly indent the code :)
Thanks! My Emacs agrees, so LGTM.
[...]
Toggle quote (6 lines)
> + (arguments> + `(#:phases> + (modify-phases %standard-phases> + (delete 'configure))> + #:make-flags (list "CC=gcc" (string-append "PREFIX=" (assoc-ref %outputs "out")))
I moved the second flag to its own line as 89 characters is a bit much.
Toggle quote (2 lines)
> + #:tests? #f))
And added a comment about why tests are disabled.
Toggle quote (8 lines)
> + (synopsis "Generate (pseudo-)random passwords and hashes")> + (description> + "Makepasswd is a program that generates pseudo-random passwords of a> +desired length. It can also generate their corresponding hashes for a given> +encryption algorithm if so desired.")> + (home-page "https://github.com/khorben/makepasswd")> + (license license:gpl3))))
Indeed GPL3 only :-/
Applied!