Alex McGrath <amk@amk.ie> writes:
Toggle quote (2 lines)
> * gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable.
Thanks! Unfortunately the patch no longer applies, can you rebase it onthe current master branch?
[...]
Toggle quote (17 lines)
> +(define-public j4-dmenu-desktop> + (package> + (name "j4-dmenu-desktop")> + (version "2.17")> + (source (origin> + (method git-fetch)> + (uri (git-reference> + (url "https://github.com/enkore/j4-dmenu-desktop.git")> + (commit (string-append "r" version))))> + (file-name (git-file-name name version))> + (sha256> + (base32> + "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc"))))> + (build-system cmake-build-system)> + (arguments> + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off")
Note that cmake-build-system exposes #:build-type, so you don't have topass "-DCMAKE_BUILD_TYPE". By default it uses RelWithDebugInfo which isbetter because it adds debug information. There are cases where wewant "Release" instead (size or performance concerns), but it probablyis fine for this package?
Toggle quote (2 lines)
> + #:tests? #f)) ;; tests fetch an external git repo
Is it possible to provide this repo as a native-input? See e.g. 'ghc'.Don't stress it if it's not possible, though.
Toggle quote (2 lines)
> + (synopsis "A fast desktop menu")
Just "Fast desktop menu" ('./pre-inst-env guix lint j4-dmenu-desktop'should warn about this).
Toggle quote (2 lines)
> + (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.")
Use two spaces between sentences, and try to wrap lines at ~78characters. 'guix lint' will warn about this, too. :-)
Can you send an updated patch? Thanks in advance!