Hi, the attached patch adds the monitoring software “collectd”. Its configurationis quite minimal right now. A lot of plugins are not enabled, because theyintroduce many external dependencies. I’m sure that can be fixed easily ifthere’s demand though. I’ve been running the package in production for a week now without any problems(via systemd on a foreign distribution, thus no herd service). Cheers,Lars
This is incorrect (see patch below, which also includes indentationfixes and minor changes to the description to placate ‘guix lint’.) Also, could you add a comment stating whether it’s dual-licensing orjust that there’s code in both licenses?
Toggle quote (6 lines)> diff --git a/gnu/packages/patches/collectd-5.11.0-noinstallvar.patch b/gnu/packages/patches/collectd-5.11.0-noinstallvar.patch> new file mode 100644> index 0000000000..a8ca142147> --- /dev/null> +++ b/gnu/packages/patches/collectd-5.11.0-noinstallvar.patch
A one-line comment at the top explaining what it does would be great. Otherwise LGTM. Could you send an updated patch? Thanks in advance! Ludo’.
Toggle diff (37 lines)diff --git a/gnu/packages/monitoring.scm b/gnu/packages/monitoring.scmindex 5a37b14328..7ee58f0d0c 100644--- a/gnu/packages/monitoring.scm+++ b/gnu/packages/monitoring.scm@@ -467,11 +467,11 @@ written in Go with pluggable metric collectors.") (build-system gnu-build-system) (arguments `(#:configure-flags (list "--localstatedir=/var" "--sysconfdir=/etc")- #:phases- (modify-phases %standard-phases- ;; Required because of patched sources.- (add-before 'configure 'autoreconf- (lambda _ (invoke "autoreconf" "-vfi") #t)))))+ #:phases (modify-phases %standard-phases+ (add-before 'configure 'autoreconf+ (lambda _+ ;; Required because of patched sources.+ (invoke "autoreconf" "-vfi")))))) (inputs `(("rrdtool" ,rrdtool) ("curl" ,curl)))@@ -483,10 +483,10 @@ written in Go with pluggable metric collectors.") (home-page "https://collectd.org/") (synopsis "Collect system and application performance metrics periodically") (description- "collectd gathers metrics from various sources, e.g. the operating system,-applications, logfiles and external devices, and stores this information or-makes it available over the network. Those statistics can be used to monitor-systems, find performance bottlenecks (i.e. performance analysis) and predict-future system load (i.e. capacity planning).")- (license '(licenses:expat licenses:gpl2))))+ "collectd gathers metrics from various sources such as the operating system,+applications, log files and external devices, and stores this information or+makes it available over the network. Those statistics can be used to monitor+systems, find performance bottlenecks (i.e., performance analysis) and predict+future system load (i.e., capacity planning).")+ (license (list license:expat license:gpl2))))