Hello Eric,
Thanks for the patch.
Toggle quote (2 lines)
> + (version "1.0.19")
Looks like 1.0.20 is out there.
Toggle quote (14 lines)
> + (source> + (origin> + (method git-fetch)> + (uri (git-reference> + (url "https://github.com/akopytov/sysbench")> + (commit version)))> + (file-name (git-file-name name version))> + (sha256> + (base32 "1zgqb9cr7ld3vw4a3jhq1mlszhcyjlpr0c8q1jcp1d27l9dcvd1w"))> + (modules '((guix build utils)))))> + (build-system gnu-build-system)> + (arguments> + `(#:tests? #f ; until shebangs fixed
Tests can run but you actually need to modify run_tests.sh so that it'sable to locate the python interpreter.
Toggle quote (14 lines)
> + (modify-phases %standard-phases> + (delete 'bootstrap)> + (add-after 'patch-source-shebangs 'libtoolize> + (lambda _ (invoke "libtoolize" "--copy" "--force")))> + (add-after 'libtoolize 'aclocal> + (lambda _ (invoke "aclocal" "-I" "m4")))> + (add-after 'aclocal 'autoreconf> + (lambda _ (invoke "autoreconf" "--install")))> + (add-after 'autoreconf 'automake> + (lambda _ (invoke "automake"> + "-c" "--foreign" "--add-missing")))> + (add-after 'automake 'autoconf> + (lambda _ (invoke "autoconf"))))))
You can remove all this block by just adding "which" to thenative-inputs list :)
Toggle quote (2 lines)
> + (synopsis "Scriptable multi-threaded benchmark tool ")
Trailing space at the end of the sentence.
Toggle quote (5 lines)
> + (description "sysbench is a scriptable multi-threaded benchmark tool based> +on LuaJIT. It is most frequently used for database benchmarks, but can also be> +used to create arbitrarily complex workloads that do not involve a database> +server.")
Please remember to run `guix lint' before submitting.
Thanks,
Mathieu