Good morning,
Michael Rohleder 写道:
Toggle quote (4 lines)
> My girlfriend's laptop has this chip, so I needed this to spread > the> love of guix (to her already endless sea of love).
Yay! Thank her for the patch.
Toggle quote (3 lines)
> Im not sure about the naming, it could also be something like> rtl8821ce-driver-linux.
-linux-module's better. The currently random names should probably be standardised.
Toggle quote (2 lines)
> + (define-public rtl8821ce-linux-module
This can go under the existing rtl8812au-aircrack-ng-linux-module. I knew that chip number looked familiar.
Toggle quote (2 lines)
> + (version (git-version "0.0.1" revision commit))
This should be 0.0.0 unless there's some 0.0.1 release of which I'm unaware.
Toggle quote (12 lines)
> + (source> + (origin> + (method git-fetch)> + (uri (git-reference> + (url > "https://github.com/tomaspinho/rtl8821ce.git")> + (commit commit)))> + (sha256> + (base32> + > "17jiw25k74kv5lnvgycvj2g1n06hbrpjz6p4znk4a62g136rhn4s"))))
Git check-outs should have a
(file-name (git-file-name name version))
field to make the store file name a bit nicer (and easier to recognise).
Toggle quote (7 lines)
> + (arguments> + `(#:phases> + (modify-phases %standard-phases> + (replace 'build> + (lambda* (#:key inputs make-flags > #:allow-other-keys)
OK, I'm going to add #:make-flags support to l-m-b-s.
Toggle quote (8 lines)
> + (setenv "CC" "gcc")> + (apply invoke "make"> + (string-append "KSRC="> + (assoc-ref inputs > "linux-module-builder")> + "/lib/modules/build")> + (or make-flags '())))))
If you copied this from rtl8812au-aircrack-ng-linux-module I apologise :-) I (and Guix) prefer specifying the default up-front like so:
(lambda* (#:key (make-flags '()) … #:allow-other-keys) …
Then you can use it without ceremony.
Toggle quote (3 lines)
> + (synopsis "Linux Driver for Realtek RTL8821CE wireless > network adapters")
‘driver’
Toggle quote (3 lines)
> + (description "This is Realtek's RTL8821CE Linux driver > for wireless
Invisible trailing space.
Toggle quote (2 lines)
> +network adapters.")
This ought to be a little longer. I can throw something together if you're without inspiration.
The AUR package says ‘with firmware’, which would be problematic if I'd actually found any. The README also mentions firmware at the very end. Do you know what they mean? Does this package work out of the box with Linux-Libre? Is that only for Bluetooth?
Kind regards,
T G-R