[PATCH] gnu: Add gnome-chess

Jack Hill wrote on 1 Apr 2020 06:00

Recipients:(address . guix-patches@gnu.org)(name . Jack Hill)(address . jackhill@jackhill.us)

Message-ID:20200401040053.9054-1-jackhill@jackhill.us

* gnu/packages/games.scm (gnome-chess): New variable.--- gnu/packages/games.scm | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+)

Toggle diff (60 lines)diff --git a/gnu/packages/games.scm b/gnu/packages/games.scmindex e818b851f4..dbc9e899b8 100644--- a/gnu/packages/games.scm+++ b/gnu/packages/games.scm@@ -49,6 +49,7 @@ ;;; Copyright © 2020 Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx> ;;; Copyright © 2020 Naga Malleswari <nagamalli@riseup.net> ;;; Copyright © 2020 Vitaliy Shatrov <D0dyBo0D0dyBo0@protonmail.com>+;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us> ;;; ;;; This file is part of GNU Guix. ;;;@@ -1095,6 +1096,45 @@ destroying an ancient book using a special wand.")     ;; license.  The whole package is released under GPLv3+.     (license license:gpl3+))) +(define-public gnome-chess+  (package+    (name "gnome-chess")+    (version "3.36.0")+    (source (origin+              (method url-fetch)+              (uri (string-append "mirror://gnome/sources/" name "/"+                                  (version-major+minor version)  "/"+                                  name "-" version ".tar.xz"))+              (sha256+               (base32+                "1a9fgi749gy1f60vbcyrqqkab9vqs42hji70q73k1xx8rv0agmg0"))))+    (build-system meson-build-system)+    (arguments+     '(#:phases+       (modify-phases %standard-phases+         (add-after 'unpack 'skip-gtk-update-icon-cache+           ;; Don't create 'icon-theme.cache'.+           (lambda _+             (substitute* "meson_post_install.py"+               (("gtk-update-icon-cache") "true"))+             #t)))))+    (inputs+     `(("gtk+" ,gtk+)+       ("librsvg" ,librsvg)))+    (native-inputs+     `(("gettext" ,gettext-minimal)+       ("glib:bin" ,glib "bin") ; for desktop-file-validate and appstream-util+       ("itstool" ,itstool)+       ("pkg-config" ,pkg-config)+       ("vala" ,vala)))+    (home-page "https://wiki.gnome.org/Apps/Chess")+    (synopsis "Chess board for GNOME")+    (description "GNOME Chess provides a 2D board for playing chess games+against human or computer players.  It supports loading and saving games in+Portable Game Notation.  To play against a computer, install a chess engine+such as chess or stockfish.")+    (license license:gpl3+)))+ (define-public gnubg   (package     (name "gnubg")-- 2.25.1

Christopher Baines wrote on 1 Apr 2020 09:36

Recipients:

Message-ID:87d08rac9f.fsf@cbaines.net

Jack Hill <jackhill@jackhill.us> writes:

Toggle quote (5 lines)

> * gnu/packages/games.scm (gnome-chess): New variable.> ---> gnu/packages/games.scm | 40 ++++++++++++++++++++++++++++++++++++++++> 1 file changed, 40 insertions(+)

Thanks for the patch Jack!

Toggle quote (39 lines)> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm> index e818b851f4..dbc9e899b8 100644> --- a/gnu/packages/games.scm> +++ b/gnu/packages/games.scm> @@ -49,6 +49,7 @@>  ;;; Copyright © 2020 Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx>>  ;;; Copyright © 2020 Naga Malleswari <nagamalli@riseup.net>>  ;;; Copyright © 2020 Vitaliy Shatrov <D0dyBo0D0dyBo0@protonmail.com>> +;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us>>  ;;;>  ;;; This file is part of GNU Guix.>  ;;;> @@ -1095,6 +1096,45 @@ destroying an ancient book using a special wand.")>      ;; license.  The whole package is released under GPLv3+.>      (license license:gpl3+)))>> +(define-public gnome-chess> +  (package> +    (name "gnome-chess")> +    (version "3.36.0")> +    (source (origin> +              (method url-fetch)> +              (uri (string-append "mirror://gnome/sources/" name "/"> +                                  (version-major+minor version)  "/"> +                                  name "-" version ".tar.xz"))> +              (sha256> +               (base32> +                "1a9fgi749gy1f60vbcyrqqkab9vqs42hji70q73k1xx8rv0agmg0"))))> +    (build-system meson-build-system)> +    (arguments> +     '(#:phases> +       (modify-phases %standard-phases> +         (add-after 'unpack 'skip-gtk-update-icon-cache> +           ;; Don't create 'icon-theme.cache'.> +           (lambda _> +             (substitute* "meson_post_install.py"> +               (("gtk-update-icon-cache") "true"))> +             #t))))

It would be good to wrap gnome-chess to include it's own share directoryin the XDG_DATA_DIRS environment variable. Without that, I can't justrun it [1], but when I set that variable correctly [2], it works :)
1:→ /gnu/store/jv8jpq23iic13j7zdl8mdc30vcv508wh-gnome-chess-3.36.0/bin/gnome-chess
(gnome-chess:10039): GLib-GIO-ERROR **: 08:31:52.482: Settings schema 'org.gnome.Chess' is not installedTrace/breakpoint trap
2:→ XDG_DATA_DIRS="$XDG_DATA_DIRS:/gnu/store/jv8jpq23iic13j7zdl8mdc30vcv508wh-gnome-chess-3.36.0/share" /gnu/store/jv8jpq23iic13j7zdl8mdc30vcv508wh-gnome-chess-3.36.0/bin/gnome-chess

This wrapping is something that would automatically be done through theglib-or-gtk-build-system, but maybe not automatically through the mesonbuild system.

Toggle quote (21 lines)> +    (inputs> +     `(("gtk+" ,gtk+)> +       ("librsvg" ,librsvg)))> +    (native-inputs> +     `(("gettext" ,gettext-minimal)> +       ("glib:bin" ,glib "bin") ; for desktop-file-validate and appstream-util> +       ("itstool" ,itstool)> +       ("pkg-config" ,pkg-config)> +       ("vala" ,vala)))> +    (home-page "https://wiki.gnome.org/Apps/Chess")> +    (synopsis "Chess board for GNOME")> +    (description "GNOME Chess provides a 2D board for playing chess games> +against human or computer players.  It supports loading and saving games in> +Portable Game Notation.  To play against a computer, install a chess engine> +such as chess or stockfish.")> +    (license license:gpl3+)))> +>  (define-public gnubg>    (package>      (name "gnubg")

Apart from the wrapping I mentioned above, this looks good to me :)
Thanks,
Chris

Nicolas Goaziou wrote on 1 Apr 2020 10:27

Recipients:(name . Christopher Baines)(address . mail@cbaines.net)

Message-ID:874ku34nlm.fsf@nicolasgoaziou.fr

Hello,
Christopher Baines <mail@cbaines.net> writes:

Toggle quote (4 lines)

> This wrapping is something that would automatically be done through the> glib-or-gtk-build-system, but maybe not automatically through the meson> build system.

I think the meson build system has a #:glib-or-gtk? parameter to dothat.
Regards,
-- Nicolas Goaziou

Jack Hill wrote on 1 Apr 2020 16:32

[PATCH v2] gnu: Add gnome-chess

Recipients:(address . 40364@debbugs.gnu.org)

Message-ID:20200401143207.13357-1-jackhill@jackhill.us

* gnu/packages/games.scm (gnome-chess): New variable.---
Thanks for the review and suggestion. I've added the #glib-or-gtk? #targument, and it looks like the wrapping happens correctly.
gnu/packages/games.scm | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)

Toggle diff (61 lines)diff --git a/gnu/packages/games.scm b/gnu/packages/games.scmindex e818b851f4..8a24dad33d 100644--- a/gnu/packages/games.scm+++ b/gnu/packages/games.scm@@ -49,6 +49,7 @@ ;;; Copyright © 2020 Alberto Eleuterio Flores Guerrero <barbanegra+guix@posteo.mx> ;;; Copyright © 2020 Naga Malleswari <nagamalli@riseup.net> ;;; Copyright © 2020 Vitaliy Shatrov <D0dyBo0D0dyBo0@protonmail.com>+;;; Copyright © 2020 Jack Hill <jackhill@jackhill.us> ;;; ;;; This file is part of GNU Guix. ;;;@@ -1095,6 +1096,46 @@ destroying an ancient book using a special wand.")     ;; license.  The whole package is released under GPLv3+.     (license license:gpl3+))) +(define-public gnome-chess+  (package+    (name "gnome-chess")+    (version "3.36.0")+    (source (origin+              (method url-fetch)+              (uri (string-append "mirror://gnome/sources/" name "/"+                                  (version-major+minor version)  "/"+                                  name "-" version ".tar.xz"))+              (sha256+               (base32+                "1a9fgi749gy1f60vbcyrqqkab9vqs42hji70q73k1xx8rv0agmg0"))))+    (build-system meson-build-system)+    (arguments+     '(#:glib-or-gtk? #t+       #:phases+       (modify-phases %standard-phases+         (add-after 'unpack 'skip-gtk-update-icon-cache+           ;; Don't create 'icon-theme.cache'.+           (lambda _+             (substitute* "meson_post_install.py"+               (("gtk-update-icon-cache") "true"))+             #t)))))+    (inputs+     `(("gtk+" ,gtk+)+       ("librsvg" ,librsvg)))+    (native-inputs+     `(("gettext" ,gettext-minimal)+       ("glib:bin" ,glib "bin") ; for desktop-file-validate and appstream-util+       ("itstool" ,itstool)+       ("pkg-config" ,pkg-config)+       ("vala" ,vala)))+    (home-page "https://wiki.gnome.org/Apps/Chess")+    (synopsis "Chess board for GNOME")+    (description "GNOME Chess provides a 2D board for playing chess games+against human or computer players.  It supports loading and saving games in+Portable Game Notation.  To play against a computer, install a chess engine+such as chess or stockfish.")+    (license license:gpl3+)))+ (define-public gnubg   (package     (name "gnubg")-- 2.25.1

Christopher Baines wrote on 1 Apr 2020 19:30

Recipients:(name . Jack Hill)(address . jackhill@jackhill.us)

Message-ID:878sjf9kr3.fsf@cbaines.net

Jack Hill <jackhill@jackhill.us> writes:

Toggle quote (6 lines)

> * gnu/packages/games.scm (gnome-chess): New variable.> --->> Thanks for the review and suggestion. I've added the #glib-or-gtk? #t> argument, and it looks like the wrapping happens correctly.

Great, I've pushed this as 63406c0bfd0d016098ef593dcc8bfc412df36bea.
Thanks for the patch!

Closed

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 40364@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date