Hello,
John Soo <jsoo1@asu.edu> writes:
Toggle quote (3 lines)
> dhall-mode provides language support for the dhall configuration> language.
Thank you.
Toggle quote (5 lines)
> +(define-public emacs-dhall-mode> + (package> + (name "emacs-dhall-mode")> + (version "0.1.0")
This version is not accurate. The ".el" file mentions 0.1.3, but I thinkwe should use Github versioning, i.e., there is no versioning at all, sowe should do the commit + revision dance again, and use "0.1.3" as thebase of the version string.
Toggle quote (8 lines)
> + (source> + (origin> + (method git-fetch)> + (uri> + (git-reference> + (url "https://github.com/psibi/dhall-mode")> + (commit "ef4d33debe224c6ba37e51a29b9dc8b74f20f1c2")))
This should go in a dedicated variable.
Toggle quote (5 lines)
> + (file-name (git-file-name name version))> + (sha256> + (base32> + "1232y2k4l3bsz90pgis78zxmrw7jv09dfaip21yc1w4vpxfyr384"))))
Nitpick: I usually put `base32' on the same line as the string.
Toggle quote (2 lines)
> + (inputs
Nitpick: Emacs build system uses `propagated-inputs', although this isthe same.
Toggle quote (3 lines)
> + `(("emacs-reformatter" ,emacs-reformatter)))> + (build-system emacs-build-system)
Nitpick: `build-system' is usually above
Toggle quote (6 lines)
> + (home-page "https://github.com/psibi/dhall-mode")> + (synopsis "Major mode for working with Dhall configuration language")> + (description> + "Emacs Major mode for working with Dhall configuration> language.")
The description must be a full sentence.
Toggle quote (2 lines)
> + (license license:gpl2+)))
The license looks wrong. I see GPL3+ in this package.
Could you send an updated patch?
Regards,
-- Nicolas Goaziou