[PATCH] gnu: Add emacs-psc-ide.

DoneSubmitted by John Soo.
Details
2 participants
  • John Soo
  • Nicolas Goaziou
Owner
unassigned
Severity
normal
J
J
John Soo wrote on 29 Mar 2020 03:11
(address . guix-patches@gnu.org)
87h7y82cey.fsf@asu.edu
Hi Guix,
psd-ide is an indispensable part of my PureScript workflow.
Thanks!
John
Toggle quote (1 lines)>From c2001d000ffa61a4d2ae18e1f7db9b0c57923197 Mon Sep 17 00:00:00 2001
From: John Soo <jsoo1@asu.edu>Date: Tue, 24 Mar 2020 07:36:28 -0700Subject: [PATCH] gnu: Add emacs-psc-ide.
* gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable.--- gnu/packages/emacs-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)
Toggle diff (56 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scmindex 9d40b8019e..0fa43fa4d1 100644--- a/gnu/packages/emacs-xyz.scm+++ b/gnu/packages/emacs-xyz.scm@@ -65,6 +65,7 @@ ;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de> ;;; Copyright © 2020 Brice Waegeneire <brice@waegenei.re> ;;; Copyright © 2020 6033fe7de85d <6033fe7de85d@airmail.cc>+;;; Copyright © 2020 John Soo <jsoo1@asu.edu> ;;; ;;; This file is part of GNU Guix. ;;;@@ -21776,3 +21777,41 @@ enables modal editing and composition of commands, too. It combines ideas of other Editors like Vim or Kakoune and tries to align them with regular Emacs conventions.") (license license:gpl3+)))++(define-public emacs-psc-ide+ (package+ (name "emacs-psc-ide")+ (version "0.0.0")+ (source+ (origin+ (method git-fetch)+ (uri+ (git-reference+ (url "https://github.com/purescript-emacs/psc-ide-emacs")+ (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))+ (file-name (git-file-name name "0.0.0"))+ (sha256+ (base32+ "0r0fymyai30jimm34z1cmav4wgij8ci6s1d9y7qigygfbbfrdsmj"))))+ (inputs+ `(("emacs-company" ,emacs-company)+ ("emacs-dash" ,emacs-dash)+ ("emacs-flycheck" ,emacs-flycheck)+ ("emacs-let-alist" ,emacs-let-alist)+ ("emacs-s" ,emacs-s)+ ("emacs-seq" ,emacs-seq)))+ (build-system emacs-build-system)+ (home-page "https://github.com/purescript-emacs/psc-ide-emacs")+ (synopsis "Emacs integration for PureScript's psc-ide tool")+ (description+ "Emacs integration for PureScript's psc-ide tool. Featuring:+@itemize+@item Completions+@item Type at point+@item Go to definition+@item Automatic imports+@item Case split+@item Build system integration+@item Flycheck support+@end itemize")+ (license license:gpl3+)))-- 2.26.0
J
J
John Soo wrote on 11 Apr 2020 18:21
[PATCH] Fixed some issues with the patches.
(address . 40301@debbugs.gnu.org)
87o8ryq9h4.fsf@asu.edu
Hi Guix,
I rebased these commits on master, moved the build-system field up, andput the sha string on the same line as base32. I also moved thedefinition further up in the file to avoid conflicts.
Thanks!
John
From ce0c61cbf65fbda29f5fa8ebd5c22558d71eec62 Mon Sep 17 00:00:00 2001From: John Soo <jsoo1@asu.edu>Date: Tue, 24 Mar 2020 07:36:28 -0700Subject: [PATCH] gnu: Add emacs-psc-ide.
* gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable.--- gnu/packages/emacs-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
Toggle diff (50 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scmindex e700920266..25a854cf5a 100644--- a/gnu/packages/emacs-xyz.scm+++ b/gnu/packages/emacs-xyz.scm@@ -12334,6 +12334,43 @@ keychains. The keychain entries are displayed in a directory-like structure and can be consulted and modified.") (license license:gpl3+))) +(define-public emacs-psc-ide+ (package+ (name "emacs-psc-ide")+ (version "0.0.0")+ (source+ (origin+ (method git-fetch)+ (uri+ (git-reference+ (url "https://github.com/purescript-emacs/psc-ide-emacs")+ (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))+ (file-name (git-file-name name "0.0.0"))+ (sha256+ (base32 "0r0fymyai30jimm34z1cmav4wgij8ci6s1d9y7qigygfbbfrdsmj"))))+ (build-system emacs-build-system)+ (inputs+ `(("emacs-company" ,emacs-company)+ ("emacs-dash" ,emacs-dash)+ ("emacs-flycheck" ,emacs-flycheck)+ ("emacs-let-alist" ,emacs-let-alist)+ ("emacs-s" ,emacs-s)+ ("emacs-seq" ,emacs-seq)))+ (home-page "https://github.com/purescript-emacs/psc-ide-emacs")+ (synopsis "Emacs integration for PureScript's psc-ide tool")+ (description+ "Emacs integration for PureScript's psc-ide tool. Featuring:+@itemize+@item Completions+@item Type at point+@item Go to definition+@item Automatic imports+@item Case split+@item Build system integration+@item Flycheck support+@end itemize")+ (license license:gpl3+)))+ (define-public emacs-evil-anzu (package (name "emacs-evil-anzu")-- 2.26.0
N
N
Nicolas Goaziou wrote on 11 Apr 2020 21:55
(name . John Soo)(address . jsoo1@asu.edu)(address . 40301@debbugs.gnu.org)
87a73h3ih3.fsf@nicolasgoaziou.fr
Hello,
John Soo <jsoo1@asu.edu> writes:
Toggle quote (4 lines)> I rebased these commits on master, moved the build-system field up, and> put the sha string on the same line as base32. I also moved the> definition further up in the file to avoid conflicts.
Thank you!
Toggle quote (5 lines)> +(define-public emacs-psc-ide> + (package> + (name "emacs-psc-ide")> + (version "0.0.0")
According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also,you need to add a revision number, "0", or "1" at this point.
Toggle quote (8 lines)> + (source> + (origin> + (method git-fetch)> + (uri> + (git-reference> + (url "https://github.com/purescript-emacs/psc-ide-emacs")> + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))
The commit should be moved in a top-level `let' at the beginning of thepackage definition.
Toggle quote (2 lines)> + (file-name (git-file-name name "0.0.0"))
This should use version, along with the revision number.
Toggle quote (4 lines)> + (synopsis "Emacs integration for PureScript's psc-ide tool")> + (description> + "Emacs integration for PureScript's psc-ide tool. Featuring:
Description should be made of full sentences. Also, it might be usefulto explain what "psc-ide" tool is.
Could you send an updated patch?
Regards,
-- Nicolas Goaziou
J
J
John Soo wrote on 12 Apr 2020 02:45
(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)(address . 40301@debbugs.gnu.org)
87ftd9r0p0.fsf@asu.edu
Hi Nicolas,
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
Toggle quote (26 lines)>> +(define-public emacs-psc-ide>> + (package>> + (name "emacs-psc-ide")>> + (version "0.0.0")>> According to "Version:" keyword in "psc-ide.el", it is "0.1.0". Also,> you need to add a revision number, "0", or "1" at this point.> ...>> + (source>> + (origin>> + (method git-fetch)>> + (uri>> + (git-reference>> + (url "https://github.com/purescript-emacs/psc-ide-emacs")>> + (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe")))>> The commit should be moved in a top-level `let' at the beginning of the> package definition.>>> + (file-name (git-file-name name "0.0.0"))>> This should use version, along with the revision number.>> + (synopsis "Emacs integration for PureScript's psc-ide tool")>> + (description>> + "Emacs integration for PureScript's psc-ide tool. Featuring:
Ok I added the revision and the commit and used git-version andgit-file-name. As an aside, what does the revision mean? Maybe if Ireally understand it I can submit better patches in the future.
Toggle quote (3 lines)> Description should be made of full sentences. Also, it might be useful> to explain what "psc-ide" tool is.
I think I clarified the description a little. This was an excellentdetailed review, thank you so much.
Also, I changed inputs->propagated-inputs.
Kindly,
John
From 20e7f672bb002e8e0e784300789c3e11aeabd41f Mon Sep 17 00:00:00 2001From: John Soo <jsoo1@asu.edu>Date: Tue, 24 Mar 2020 07:36:28 -0700Subject: [PATCH] gnu: Add emacs-psc-ide.
* gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable.--- gnu/packages/emacs-xyz.scm | 41 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+)
Toggle diff (54 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scmindex e700920266..530eee7eb7 100644--- a/gnu/packages/emacs-xyz.scm+++ b/gnu/packages/emacs-xyz.scm@@ -12334,6 +12334,47 @@ keychains. The keychain entries are displayed in a directory-like structure and can be consulted and modified.") (license license:gpl3+))) +(define-public emacs-psc-ide+ (let ((revision "1")+ (commit "7fc2b841be25f5bc5e1eb7d0634436181c38b3fe"))+ (package+ (name "emacs-psc-ide")+ (version (git-version "0.1.0" revision commit))+ (source+ (origin+ (method git-fetch)+ (uri+ (git-reference+ (url "https://github.com/purescript-emacs/psc-ide-emacs")+ (commit commit)))+ (file-name (git-file-name name version))+ (sha256+ (base32 "0r0fymyai30jimm34z1cmav4wgij8ci6s1d9y7qigygfbbfrdsmj"))))+ (build-system emacs-build-system)+ (propagated-inputs+ `(("emacs-company" ,emacs-company)+ ("emacs-dash" ,emacs-dash)+ ("emacs-flycheck" ,emacs-flycheck)+ ("emacs-let-alist" ,emacs-let-alist)+ ("emacs-s" ,emacs-s)+ ("emacs-seq" ,emacs-seq)))+ (home-page "https://github.com/purescript-emacs/psc-ide-emacs")+ (synopsis "Emacs integration for PureScript's psc-ide tool")+ (description+ "PureScript implements an ide protocol in its compiler called psc-ide.+This package provices Emacs integration for psc-ide. It features:++@itemize+@item Completions+@item Type at point+@item Go to definition+@item Automatic imports+@item Case split+@item Build system integration, and+@item Flycheck support+@end itemize")+ (license license:gpl3+))))+ (define-public emacs-evil-anzu (package (name "emacs-evil-anzu")-- 2.26.0
N
N
Nicolas Goaziou wrote on 12 Apr 2020 11:04
(name . John Soo)(address . jsoo1@asu.edu)(address . 40301-done@debbugs.gnu.org)
87sgh913ef.fsf@nicolasgoaziou.fr
Hello,
John Soo <jsoo1@asu.edu> writes:
Toggle quote (4 lines)> Ok I added the revision and the commit and used git-version and> git-file-name. As an aside, what does the revision mean? Maybe if I> really understand it I can submit better patches in the future.
If there is no proper versioning for the package (e.g., no releases, orversion strings hidden in a source file), we have to rely on commithashes. But commit hashes are not monotonic. So, if you package, e.g.,"emacs-psc-ide" with commit "bbbb", and later, update it to includelatest commit "aaaa", you have, from Guix's point of view, downgradedthe package, even though "aaaa" is more advanced than "bbbb".
The revision number solves that. Each time you update the commitmessage, you increase the revision number, so you releases aremonotonic. E.g., your first package will be "emacs-psc-ide-1-bbbb", andthe other "emacs-psc-ide-2-aaaa".
Toggle quote (4 lines)> Subject: [PATCH] gnu: Add emacs-psc-ide.>> * gnu/packages/emacs-xyz.scm (emacs-psc-ide): New variable.
Thank you. Applied as 8a00a2202ef2a0a0173e17479359370f5656ecd0.
Regards,
-- Nicolas Goaziou
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 40301@debbugs.gnu.org