(name . Leo Famulari)(address . firstname.lastname@example.org)(address . email@example.com)
On Fri, Mar 20, 2020 at 04:21:03PM -0400, Leo Famulari wrote:
Toggle quote (8 lines)> On Fri, Mar 20, 2020 at 08:32:49PM +0100, Jakub Kądziołka wrote:> > ---> > gnu/packages/crypto.scm | 39 +++++++++++++++++++> > .../patches/hash-extender-test-suite.patch | 12 ++++++> > Remember to register the patch file in 'gnu/local.mk' and mention it in> the commit message.
Ugh, I always forget to do this, even though I always notice it'smissing when I'm *reviewing* patches.
Toggle quote (11 lines)> > + (replace 'install> > + (lambda* (#:key outputs #:allow-other-keys)> > + (let* ((outdir (assoc-ref outputs "out"))> > + (bindir (string-append outdir "/bin")))> > + (install-file "hash_extender" bindir)))))))> > Can you install the README.md too? It would go under something like:> (string-append "share/doc/hash-extender" ,version "/")> > ... so that it fits correctly in the user's profile.
Huh. For a moment I thought the version is pointless here, but then Inoticed the LICENSE file. I did as suggested, though with a dash before theversion.
Toggle quote (4 lines)> > diff --git a/gnu/packages/patches/hash-extender-test-suite.patch b/gnu/packages/patches/hash-extender-test-suite.patch> > And I would consider submitting this patch upstream.
Good idea! Thanks for your review! Amended patch pushed asbbeb710de70521010b3d432cb5b4b14ce6e45ca6.