[PATCH 0/1] qtwebkit: Uses sqlite-with-column-metadata

  • Done
  • quality assurance status badge
Details
3 participants
  • Efraim Flashner
  • Hartmut Goebel
  • Marius Bakke
Owner
unassigned
Submitted by
Hartmut Goebel
Severity
normal
H
H
Hartmut Goebel wrote on 8 Nov 2019 11:37
(address . guix-patches@gnu.org)
20191108103719.8633-1-h.goebel@crazy-compilers.com
I had a hard time finding an error caused by conflicting sqlite3 libs to be
loaded.

I suggest this to go to staging.


Hartmut Goebel (1):
gnu: qtwebkit: Uses sqlite-with-column-metadata.

gnu/packages/qt.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
2.21.0
H
H
Hartmut Goebel wrote on 8 Nov 2019 11:38
[PATCH 1/1] gnu: qtwebkit: Uses sqlite-with-column-metadata.
(address . 38123@debbugs.gnu.org)
20191108103843.8731-1-h.goebel@crazy-compilers.com
This needs to be the same variant as for qtbase, otherwise applications
might fail if libQt5WebKit is loaded prior to libQt5Sql.

* gnu/packages/qt.scm(wtwebkit)[inputs]: Replace sqlite by
sqlite-with-column-metadata.
---
gnu/packages/qt.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index 0ef879678f..222a0cc867 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -2182,7 +2182,7 @@ different kinds of sliders, and much more.")
("libjpeg" ,libjpeg)
("libpng" ,libpng)
("libwebp" ,libwebp)
- ("sqlite" ,sqlite)
+ ("sqlite" ,sqlite-with-column-metadata)
("fontconfig" ,fontconfig)
("libxrender" ,libxrender)
("qtbase" ,qtbase)
--
2.21.0
H
H
Hartmut Goebel wrote on 8 Nov 2019 11:43
Re: bug#38123: Acknowledgement ([PATCH 0/1] qtwebkit: Uses sqlite-with-column-metadata)
(address . 38123@debbugs.gnu.org)
ab36455c-e3b2-6c2c-4747-a9302097018f@crazy-compilers.com
Toggle quote (3 lines)
> qtwebkit: Uses sqlite-with-column-metadata.


Type "uses" jsut fixed.

--
Regards
Hartmut Goebel

| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
M
M
Marius Bakke wrote on 10 Nov 2019 00:01
Re: [bug#38123] [PATCH 1/1] gnu: qtwebkit: Uses sqlite-with-column-metadata.
87a794mz7f.fsf@devup.no
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

Toggle quote (6 lines)
> This needs to be the same variant as for qtbase, otherwise applications
> might fail if libQt5WebKit is loaded prior to libQt5Sql.
>
> * gnu/packages/qt.scm(wtwebkit)[inputs]: Replace sqlite by
> sqlite-with-column-metadata.

LGTM. I think we should enable column metadata in the regular SQLite
package this upcoming 'core-updates' round.

Thoughts?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3HRUQACgkQoqBt8qM6
VPr4nQgAqmq7ZpcF9xP/RVoGYZHD/qhGDP12QlC4EUXjwXBCCguXw14z/bAHhaYB
JqVI8+axxThARYimm3ExQOwC1+ywnvkVTcvq64W3Pp9guW8p3IQ1UKqI8B3ixULA
F0qjUBQU0M4/rxtw2aEPBZcluYWYS+P4s02+KlWS7e7nGAsbxtrk2UjlKbM23GNe
3VnrbH8AYnapqZuuY0yRO9slcW5bCMGjsOVuXm9BuBMzGSvzHO0H37zNZrHTHcdm
zygUUesf6/pBnJezPvnySafKasnDcfoV/FumviJMrSZ4amEy9BCL/xxcbTdumZwh
ajvH3UtVtLQKFVs3GoXDne3CaZfbrQ==
=edkE
-----END PGP SIGNATURE-----

E
E
Efraim Flashner wrote on 10 Nov 2019 08:23
(name . Marius Bakke)(address . mbakke@fastmail.com)
20191110072302.GD3954@E5400
On Sun, Nov 10, 2019 at 12:01:24AM +0100, Marius Bakke wrote:
Toggle quote (13 lines)
> Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
>
> > This needs to be the same variant as for qtbase, otherwise applications
> > might fail if libQt5WebKit is loaded prior to libQt5Sql.
> >
> > * gnu/packages/qt.scm(wtwebkit)[inputs]: Replace sqlite by
> > sqlite-with-column-metadata.
>
> LGTM. I think we should enable column metadata in the regular SQLite
> package this upcoming 'core-updates' round.
>
> Thoughts?

Core-updates is open. I don't see any reason to delay merging the two
any longer


--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3HutYACgkQQarn3Mo9
g1H4hA/7B4xgICsu5HrrZPauNVLmsFDgKfdu2ubXytN1ujpvuBKz5JXZjtJVaEcE
+d4TNK+G+wCYzbsRVy63JtptWkNphLy6PFhEW9/0m8rMwnl+5FixLqf28RUZTKpE
pXBjmDwXMSNXzG2o2VV4S9IbWvQq8RR5nYp2xXE7i1As4HV8eOqJz32GpdMQZptf
/KKXHhI1oskjBsGa1KaQuEPyvQuGBjOOzHFe5uj+Rex26J+HBRbRd9ewTceVAmDE
+4OjTaEtaS79rxp8Ytbxtxx/Wqp1UCZmyPt4NesayCMLyiLwnMhpdW0a4OXqpivi
t8oXDXkcUhN4QIQMXHDVqL5L0ZZJMv97Q4+BQFx5hbFBkK52CalWiShFYywq+RJO
C8N489FVN6WKeJFnpT1Dz/QI5TIhN0UKJHjoQy41wlPlJlR+VAAO4iNYLrUGtGDY
roa5A4V0keGjhSA3A7uifw/kKx02+W+NvihTig1FqnSltsD3nNG32ViNio6teNeb
LBdrhdpgbOjbZa0hvtcy4tfNtv4PW0pKJnuhG+OKHiK3g/WeFyWFe8b0RVLUJbg4
HhzqKo+wRU4K7QbUH0kJ//D8XosKmhWWMwFVCh5lBSrljGFfwsbdstl5lgcqBjQa
QBdEvBnXr2+xitbc2Bcs2IV2k7Qy6w03DGi0dvfC+eh4c2vjP8A=
=LHSG
-----END PGP SIGNATURE-----


H
H
Hartmut Goebel wrote on 10 Nov 2019 21:28
bf7f13db-9cfe-49f7-da98-bf8528e39ed6@crazy-compilers.com
Pushed to staging as 8bfd7c8beb75ed3838efdf5973b9db5fb3ced68c

--
Regards
Hartmut Goebel

| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
Attachment: signature.asc
?