[PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.

  • Done
  • quality assurance status badge
Details
2 participants
  • Alexandros Theodotou
  • Marius Bakke
Owner
unassigned
Submitted by
Alexandros Theodotou
Severity
normal
A
A
Alexandros Theodotou wrote on 8 Nov 2019 10:14
(name . Guix patches)(address . guix-patches@gnu.org)
98eb79dfe4efd7109d771e60f9b679d3@posteo.net
The gtkmm passed to inputs was unused. Jalv does not support gtkmm 3 at
the moment.

Also, Jalv is the main tool LV2 plugin developers use to test their
plugins. Having more variants
(qt5, gtk2) means you have more types of hosts to test your plugins in
so this is an
extremely useful addition.

From 2ec5fb34c2600c893763ae95d69bf2bd77d17b61 Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 09:05:10 +0000
Subject: [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.

* gnu/packages/audio.scm (jalv)[inputs]:
Add gtk+-2 and qtbase.
Change unused gtkmm to gtkmm-2.
---
gnu/packages/audio.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 28dbf06f3b..ca2d86d525 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1599,8 +1599,10 @@ synchronous execution of all clients, and low
latency operation.")
`(("lv2" ,lv2)
("lilv" ,lilv)
("suil" ,suil)
- ("gtk" ,gtk+)
- ("gtkmm" ,gtkmm)
+ ("gtk2" ,gtk+-2)
+ ("gtk3" ,gtk+)
+ ("gtkmm" ,gtkmm-2)
+ ("qtbase" ,qtbase)
("jack" ,jack-1)))
(native-inputs
`(("pkg-config" ,pkg-config)))
--
2.24.0
M
M
Marius Bakke wrote on 10 Nov 2019 23:39
87mud3jqz4.fsf@devup.no
Alexandros Theodotou <alex@zrythm.org> writes:

Toggle quote (18 lines)
> The gtkmm passed to inputs was unused. Jalv does not support gtkmm 3 at
> the moment.
>
> Also, Jalv is the main tool LV2 plugin developers use to test their
> plugins. Having more variants
> (qt5, gtk2) means you have more types of hosts to test your plugins in
> so this is an
> extremely useful addition.
>
> From 2ec5fb34c2600c893763ae95d69bf2bd77d17b61 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 09:05:10 +0000
> Subject: [PATCH] gnu: jalv: Fix gtkmm, add gtk+-2 and qtbase.
>
> * gnu/packages/audio.scm (jalv)[inputs]:
> Add gtk+-2 and qtbase.
> Change unused gtkmm to gtkmm-2.

Thanks! 'guix size jalv' increases from 1482.2 MiB to 1501.2 MiB with
this patch due to the addition of gtkmm@2, which seems fine.

Applied!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3Ika8ACgkQoqBt8qM6
VPrONQf9HzL8LMxd0053BuKvRa4z6wJxNYYSX93GOEU0+t8D3JL18Qrq3nQCSwgs
5MKfA0x3D5UARDPDzX6r7RjSc1aO4dc0PHZNgfa3S2HGS2DIoiBgp9Pi1ubQvFuz
vonZuE9TZNzy4mk1/tEmeapIl5MtrAQj5owDPnuz9X2UCN53sNZGxNuckV37w+n7
GFR7oWhcDb6IIirSa7vKi1d+K+hjgMDZnIAOnuIXiaqXk1mTrMJsNAZNIl4pg1dV
65D1fnDzmNNzFBq+I7YQUHu/hVIcH47cEPE084VBIRo7LkrQsxtXU0DchONOKDKN
f8GhIfM+5J36FKZpBmN0oz3YTh7zXQ==
=gfhn
-----END PGP SIGNATURE-----

Closed
?