From: Wiktor Żelazny <firstname.lastname@example.org> * gnu/packages/textutils.scm (aha): new variable.---Hi, This is the first time that I’m submitting something that uses thegit-fetch method. I tried to follow the manual. Unfortunately, it doesnot explain the role of this "0.9" string. I noticed that othercontributors use various values. I left it at "0.9". gnu/packages/textutils.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
Wiktor, Thanks for the patch! This isn't a review, just an answer to your question: Wiktor Żelazny 写道：
Toggle quote (7 lines)> Hi, This is the first time that I’m submitting something that > uses the> git-fetch method. I tried to follow the manual. Unfortunately, > it does> not explain the role of this "0.9" string. I noticed that other> contributors use various values. I left it at "0.9".
It's not a random value; it's the last ‘real’ release, think of it as ‘release 0.9 + some more commits that were needed for some reason’. If the project has never seen a release, ‘0.0.0’ is used. You'll find that this is quite common, too. At https://github.com/theZiz/aha/releases,we can see that the last release before this commit was ‘0.5’, so that's what you should use. However: we prefer packaging releases, not arbitrary commits. Why not package 0.5? If it's because it's old (it is) and missing cool features, consider asking the author to cut a new release. Whatever the case, please note the reason in a comment: ‘The last release 0.5 is missing the vital foo feature and/or crashes on Fridays’. Since I'm here (still not a review! :-):
On Thu, Oct 03, 2019 at 04:47:07PM +0200, Tobias Geerinckx-Rice wrote:
Toggle quote (7 lines)> Wiktor Żelazny 写道：>> > I tried to follow the manual. Unfortunately, it does not explain the> > role of this "0.9" string.>> It's not a random value; it's the last ‘real’ release,
Hi Tobias, Thank you for this explanation and for the other remarks. I noted themdown for future reference. The amended patch is on the way. Have a nice weekend, WŻ