[PATCHES] Thunar: Update to 1.8.9.

DoneSubmitted by L p R n d n.
Details
2 participants
  • L p R n d n
  • Ludovic Courtès
Owner
unassigned
Severity
normal
L
L
L p R n d n wrote on 2 Sep 2019 16:10
8736hedc16.fsf@lprndn.info
From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001From: L p R n d n <guix@lprndn.info>Date: Mon, 19 Aug 2019 14:01:52 +0200Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.
* gnu/packages/xfce.scm (thunar): Update to 1.8.9.[propagated-inputs] Add gtk+.--- gnu/packages/xfce.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Toggle diff (31 lines)diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scmindex b27e489678..db8387b9ad 100644--- a/gnu/packages/xfce.scm+++ b/gnu/packages/xfce.scm@@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.") (define-public thunar (package (name "thunar")- (version "1.8.7")+ (version "1.8.9") (source (origin (method url-fetch) (uri (string-append "http://archive.xfce.org/src/xfce/"@@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.") "Thunar-" version ".tar.bz2")) (sha256 (base32- "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))+ "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs")))) (build-system gnu-build-system) (native-inputs `(("pkg-config" ,pkg-config) ("intltool" ,intltool)))+ (propagated-inputs+ ;; Required by thunarx-3.pc+ `(("gtk+" ,gtk+))) (inputs `(("exo" ,exo) ("libexif" ,libexif)-- 2.22.0
From d060bbbe43867160abbe2be836d1ebb035007c80 Mon Sep 17 00:00:00 2001From: L p R n d n <guix@lprndn.info>Date: Mon, 19 Aug 2019 14:03:37 +0200Subject: [PATCH 14/19] gnu: Thunar: Add gobject-introspection support.
* gnu/packages/xfce.scm (thunar)[native-inputs]: Add gobject-introspection.--- gnu/packages/xfce.scm | 1 + 1 file changed, 1 insertion(+)
Toggle diff (14 lines)diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scmindex db8387b9ad..53379b2d2c 100644--- a/gnu/packages/xfce.scm+++ b/gnu/packages/xfce.scm@@ -653,6 +653,7 @@ like appearance, display, keyboard and mouse settings.") (build-system gnu-build-system) (native-inputs `(("pkg-config" ,pkg-config)+ ("gobject-introspection" ,gobject-introspection) ("intltool" ,intltool))) (propagated-inputs ;; Required by thunarx-3.pc-- 2.22.0
L
L
Ludovic Courtès wrote on 8 Sep 2019 14:33
(name . L p R n d n)(address . guix@lprndn.info)(address . 37277@debbugs.gnu.org)
87woej7ysb.fsf@gnu.org
L p R n d n <guix@lprndn.info> skribis:
Toggle quote (38 lines)>>From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001> From: L p R n d n <guix@lprndn.info>> Date: Mon, 19 Aug 2019 14:01:52 +0200> Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.>> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.> [propagated-inputs] Add gtk+.> ---> gnu/packages/xfce.scm | 7 +++++--> 1 file changed, 5 insertions(+), 2 deletions(-)>> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm> index b27e489678..db8387b9ad 100644> --- a/gnu/packages/xfce.scm> +++ b/gnu/packages/xfce.scm> @@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")> (define-public thunar> (package> (name "thunar")> - (version "1.8.7")> + (version "1.8.9")> (source (origin> (method url-fetch)> (uri (string-append "http://archive.xfce.org/src/xfce/"> @@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.")> "Thunar-" version ".tar.bz2"))> (sha256> (base32> - "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))> + "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))> (build-system gnu-build-system)> (native-inputs> `(("pkg-config" ,pkg-config)> ("intltool" ,intltool)))> + (propagated-inputs> + ;; Required by thunarx-3.pc> + `(("gtk+" ,gtk+)))
Hi! We usually propagated in similar cases. However, here that wouldlead to propagating all of gtk+ to the user’s profile, which isundesirable. Furthermore, since thunar has only two dependents, it’sprobably not a problem if we don’t propagate gtk+.
WDYT?
Thanks,Ludo’.
L
L
L p R n d n wrote on 12 Sep 2019 10:18
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 37277@debbugs.gnu.org)
87impyc4gp.fsf@lprndn.info
Hello,
Ludovic Courtès <ludo@gnu.org> writes:
Toggle quote (47 lines)> L p R n d n <guix@lprndn.info> skribis:>>>>From 49d9ed778206d6af039029298f0f8f9aa47171ae Mon Sep 17 00:00:00 2001>> From: L p R n d n <guix@lprndn.info>>> Date: Mon, 19 Aug 2019 14:01:52 +0200>> Subject: [PATCH 13/19] gnu: Thunar: Update to 1.8.9.>>>> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.>> [propagated-inputs] Add gtk+.>> --->> gnu/packages/xfce.scm | 7 +++++-->> 1 file changed, 5 insertions(+), 2 deletions(-)>>>> diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm>> index b27e489678..db8387b9ad 100644>> --- a/gnu/packages/xfce.scm>> +++ b/gnu/packages/xfce.scm>> @@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.")>> (define-public thunar>> (package>> (name "thunar")>> - (version "1.8.7")>> + (version "1.8.9")>> (source (origin>> (method url-fetch)>> (uri (string-append "http://archive.xfce.org/src/xfce/">> @@ -649,11 +649,14 @@ like appearance, display, keyboard and mouse settings.")>> "Thunar-" version ".tar.bz2"))>> (sha256>> (base32>> - "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))>> + "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs"))))>> (build-system gnu-build-system)>> (native-inputs>> `(("pkg-config" ,pkg-config)>> ("intltool" ,intltool)))>> + (propagated-inputs>> + ;; Required by thunarx-3.pc>> + `(("gtk+" ,gtk+)))>> Hi! We usually propagated in similar cases. However, here that would> lead to propagating all of gtk+ to the user’s profile, which is> undesirable. Furthermore, since thunar has only two dependents, it’s> probably not a problem if we don’t propagate gtk+.>> WDYT?
I don't have enough knowledge about how this works to give a useful hinthere so I would probably just follow your advice. Yet I quickly tested withoutpropagated-inputs and it seems to work without trouble.So here is the new patch.
Toggle quote (3 lines)> Thanks,> Ludo’.
Thank you and have a nice day,
L p R n d n
From f57c21a46a0cdf23085195e3645b4f1aae9e8cbd Mon Sep 17 00:00:00 2001From: L p R n d n <guix@lprndn.info>Date: Mon, 19 Aug 2019 14:01:52 +0200Subject: [PATCH] gnu: Thunar: Update to 1.8.9.
* gnu/packages/xfce.scm (thunar): Update to 1.8.9.--- gnu/packages/xfce.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Toggle diff (24 lines)diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scmindex b27e489678..8ddb7ae8a7 100644--- a/gnu/packages/xfce.scm+++ b/gnu/packages/xfce.scm@@ -641,7 +641,7 @@ like appearance, display, keyboard and mouse settings.") (define-public thunar (package (name "thunar")- (version "1.8.7")+ (version "1.8.9") (source (origin (method url-fetch) (uri (string-append "http://archive.xfce.org/src/xfce/"@@ -649,7 +649,7 @@ like appearance, display, keyboard and mouse settings.") "Thunar-" version ".tar.bz2")) (sha256 (base32- "0afkp528mwwa2m18m39mvw53qgaijyynrw9wwwiyxgjiczq3l0ry"))))+ "1fah2d7v3a7fp28xa5wv896rap1iad9q9y04qchca09mq1x8wxbs")))) (build-system gnu-build-system) (native-inputs `(("pkg-config" ,pkg-config)-- 2.22.0
L
L
Ludovic Courtès wrote on 13 Sep 2019 10:29
(name . L p R n d n)(address . guix@lprndn.info)(address . 37277-done@debbugs.gnu.org)
87v9tw8uqf.fsf@gnu.org
Hi,
L p R n d n <guix@lprndn.info> skribis:
Toggle quote (7 lines)> From f57c21a46a0cdf23085195e3645b4f1aae9e8cbd Mon Sep 17 00:00:00 2001> From: L p R n d n <guix@lprndn.info>> Date: Mon, 19 Aug 2019 14:01:52 +0200> Subject: [PATCH] gnu: Thunar: Update to 1.8.9.>> * gnu/packages/xfce.scm (thunar): Update to 1.8.9.
Applied, thanks!
Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 37277@debbugs.gnu.org