[PATCH] gnu: monero: Update to 0.14.1.2.

  • Done
  • quality assurance status badge
Details
2 participants
  • Efraim Flashner
  • Guillaume Le Vaillant
Owner
unassigned
Submitted by
Guillaume Le Vaillant
Severity
normal
G
G
Guillaume Le Vaillant wrote on 14 Aug 2019 23:30
(address . guix-patches@gnu.org)(name . Guillaume Le Vaillant)(address . glv@posteo.net)
20190814213009.10656-1-glv@posteo.net
* gnu/packages/finance.scm (monero): Update to 0.14.1.2.
---
gnu/packages/finance.scm | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)

Toggle diff (49 lines)
diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 7bfe5e62ff..57c12daa9b 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -445,7 +445,7 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch
;; the system's dynamically linked library.
(package
(name "monero")
- (version "0.14.1.0")
+ (version "0.14.1.2")
(source
(origin
(method git-fetch)
@@ -466,7 +466,7 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch
#t))
(sha256
(base32
- "1asa197fad81jfv12qgaa7y7pdr1r1pda96m9pvivkh4v30cx0nh"))))
+ "00zl883c7lcd9z7g4y3vv7rxmr7ppzrxdblnhk32r9l3qzyw55r6"))))
(build-system cmake-build-system)
(native-inputs
`(("doxygen" ,doxygen)
@@ -508,6 +508,12 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch
(("return \\(")
"return ((std::string(getenv(\"HOME\"))) / "))
#t))
+ (add-after 'change-log-path 'fix-file-permissions-for-tests
+ (lambda _
+ (for-each (lambda (f)
+ (chmod f #o644))
+ (find-files "tests/data/" "wallet_9svHk1.*"))
+ #t))
;; Only try tests that don't need access to network or system
(replace 'check
(lambda _
@@ -522,11 +528,6 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch
"DNSResolver.DNSSECSuccess"
"DNSResolver.DNSSECFailure"
"DNSResolver.GetTXTRecord"
- ;; TODO: Find why portability_wallet test fails
- ;; Maybe the Boost version used to create the test
- ;; wallet and the current Boost version are not
- ;; completely compatible?
- "Serialization.portability_wallet"
"is_hdd.linux_os_root")
":")))
(invoke "tests/unit_tests/unit_tests"
--
2.22.0
E
E
Efraim Flashner wrote on 15 Aug 2019 10:22
(name . Guillaume Le Vaillant)(address . glv@posteo.net)(address . 37033@debbugs.gnu.org)
20190815082227.GB27046@E2140
On Wed, Aug 14, 2019 at 11:30:09PM +0200, Guillaume Le Vaillant wrote:
Toggle quote (16 lines)
> * gnu/packages/finance.scm (monero): Update to 0.14.1.2.
> ---
> gnu/packages/finance.scm | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> "return ((std::string(getenv(\"HOME\"))) / "))
> #t))
> + (add-after 'change-log-path 'fix-file-permissions-for-tests
> + (lambda _
> + (for-each (lambda (f)
> + (chmod f #o644))
> + (find-files "tests/data/" "wallet_9svHk1.*"))
> + #t))
> ;; Only try tests that don't need access to network or system
> (replace 'check

Does 'make-file-writable' from (guix build utils) instead of 'chmod'
work here?


--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl1VFkMACgkQQarn3Mo9
g1Ehlg/+PVtxkE/44Gsk2B7s0jCd6TGcEf9v0XY2hMxLPLLyd31T1wFUtyELqA7i
6PsoV3DlIeZ2v67fkBNrhFRgwcjtEcZiQLj0o3ZeRQal36YRpX40neg+BaLh+rvn
tGzyUZWYW4223JcKUAqkk0Yh+3kowslZFGNUwE6kyd56chbrmK/K2KvXJNqx7nl3
r5u6eDhoTCGH0uqBSwLYCPxqVvrW5V7z+EgTIOl++b17gGoMW3VDB4pQZ8egkNcs
iMuYrQkCOHqyFxqKxOJeHV/d8vkdqhcgakvbufwk6bHGxUHVKWtasLmWne9pHPeX
mpxgRf8ozdlj53kp6WrQh5wXBwUu+pUYaEMcFb982HJs1X9NpsIPJT8th43zgNTz
VEMegy3OywWQN76cu8Mt6Bs0/HpHrbUhFMGTsXo2tudOwUJ3wbDY6BfX0vW8Ytrf
SQj3yuYW+cQ9DHJ6oAAr1B91gAB6x0Q8IBwDBVH4waP2GoWBCqVpRkB+C6rSqr/c
ZQCkbO2nJV0Gu+xdU48wlB4f3+dmAh+oVIza4RLecJqEGwxjtEPZOeB4dKg7gVFf
kD4JDFP/YFNAM9i7D9h8kcI6ipMLpv1wP370tFXfcZxYdKSh0e3eRiS1cC9NZUdK
onuGWQ9mnbIhF1GtSiN7RV9eTmKYEDsKXQYNz5qtRCEWbrwYVuI=
=ocWe
-----END PGP SIGNATURE-----


G
G
Guillaume Le Vaillant wrote on 15 Aug 2019 14:23
Re: [bug#37033] [PATCH v2] gnu: monero: Update to 0.14.1.2.
(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 37033@debbugs.gnu.org)
87h86i7h2j.fsf@yamatai
Efraim Flashner a écrit :

Toggle quote (20 lines)
> On Wed, Aug 14, 2019 at 11:30:09PM +0200, Guillaume Le Vaillant wrote:
>> * gnu/packages/finance.scm (monero): Update to 0.14.1.2.
>> ---
>> gnu/packages/finance.scm | 15 ++++++++-------
>> 1 file changed, 8 insertions(+), 7 deletions(-)
>>
>> "return ((std::string(getenv(\"HOME\"))) / "))
>> #t))
>> + (add-after 'change-log-path 'fix-file-permissions-for-tests
>> + (lambda _
>> + (for-each (lambda (f)
>> + (chmod f #o644))
>> + (find-files "tests/data/" "wallet_9svHk1.*"))
>> + #t))
>> ;; Only try tests that don't need access to network or system
>> (replace 'check
>
> Does 'make-file-writable' from (guix build utils) instead of 'chmod'
> work here?

Yes it works. The 'make-file-writable' function is perfect here, I just
didn't know about it. Here's the updated patch:
From 9ec625224313e609c4f3d50b6bd6cf3bb38450a9 Mon Sep 17 00:00:00 2001
From: Guillaume Le Vaillant <glv@posteo.net>
Date: Thu, 15 Aug 2019 14:07:44 +0200
Subject: [PATCH] gnu: monero: Update to 0.14.1.2.

* gnu/packages/finance.scm (monero): Update to 0.14.1.2.
---
gnu/packages/finance.scm | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

Toggle diff (48 lines)
diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 7bfe5e62ff..fc26b77279 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -445,7 +445,7 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch
;; the system's dynamically linked library.
(package
(name "monero")
- (version "0.14.1.0")
+ (version "0.14.1.2")
(source
(origin
(method git-fetch)
@@ -466,7 +466,7 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch
#t))
(sha256
(base32
- "1asa197fad81jfv12qgaa7y7pdr1r1pda96m9pvivkh4v30cx0nh"))))
+ "00zl883c7lcd9z7g4y3vv7rxmr7ppzrxdblnhk32r9l3qzyw55r6"))))
(build-system cmake-build-system)
(native-inputs
`(("doxygen" ,doxygen)
@@ -508,6 +508,11 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch
(("return \\(")
"return ((std::string(getenv(\"HOME\"))) / "))
#t))
+ (add-after 'change-log-path 'fix-file-permissions-for-tests
+ (lambda _
+ (for-each make-file-writable
+ (find-files "tests/data/" "wallet_9svHk1.*"))
+ #t))
;; Only try tests that don't need access to network or system
(replace 'check
(lambda _
@@ -522,11 +527,6 @@ other machines/servers. Electroncash does not download the Bitcoin Cash blockch
"DNSResolver.DNSSECSuccess"
"DNSResolver.DNSSECFailure"
"DNSResolver.GetTXTRecord"
- ;; TODO: Find why portability_wallet test fails
- ;; Maybe the Boost version used to create the test
- ;; wallet and the current Boost version are not
- ;; completely compatible?
- "Serialization.portability_wallet"
"is_hdd.linux_os_root")
":")))
(invoke "tests/unit_tests/unit_tests"
--
2.22.1
E
E
Efraim Flashner wrote on 20 Aug 2019 08:29
(name . Guillaume Le Vaillant)(address . glv@posteo.net)(address . 37033-done@debbugs.gnu.org)
20190820062917.GA8916@E5400
On Thu, Aug 15, 2019 at 02:23:48PM +0200, Guillaume Le Vaillant wrote:
Toggle quote (11 lines)
>
> Efraim Flashner a écrit :
>
> >
> > Does 'make-file-writable' from (guix build utils) instead of 'chmod'
> > work here?
>
> Yes it works. The 'make-file-writable' function is perfect here, I just
> didn't know about it. Here's the updated patch:
>

That was the plan :)

Patch pushed with minimal changes to the commit message.


--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl1bkzwACgkQQarn3Mo9
g1Hs6Q//WXtfzptxQTfD3AYEsnwo3V5rfkQhJ9xq1eqGC5LR1J2RJ4pHMFwP/XuW
7lQGOl159C0kjVjS1wPRFwJEC2+9kuJ6+wzPDnzQlXBrPgdKuNXNMzH97BQYiwjh
/Nh2YviDgXpq+KLhLt+mxM+MN7ysjvQHJPtkhpXnAf72PC7jPkMvhS0nbQeKYzwO
8hD5PvBGwLn8Wca1CPzEswLy+BF6oTkfWB+yy52s2FUSFbvapCPswdwhU79fdmFy
NsrSihvisbYP8CSfIks3gpYEEqHEduP+9R/HPykgZFUMnyOU8eO6bG9wHjlaWsr/
GEe3MazIu1WiCH61lN7RgMNCHnXDx6NUq65a+Iz+jGKfw1ru2WtqihAciWfysqtM
8RMXb24VQz1cweeuVM9R0xrjyrqB9m9PANgblsVsWHJHOox/8xv2UINvEEYsjEjX
LE7Q7TvdavPCd5v9RoqJwT63dpo3tDUPbFzMEj5NtxVudDs2clkbJLGzAKRr71j6
3qjjZRdXk28CeJ2r2dzMg3lvmGUn+NJPIzIo4FxGQ8aOyo2QEO+4KmODSrfQOoA9
01mPlldFl5XK60Ar2JnaLcKuCdo59q0vXv8/nHXtPbtsanB7zAzIP4GO6KGOPEsr
J7PCA0m+qAZTax+Ulc15SuNcOaOjoglzBnGpyo5ZsXuw7t79izs=
=FuvH
-----END PGP SIGNATURE-----


Closed
?