(address . guix-patches@gnu.org)
875znv89iw.fsf@odyssey.lafreniere.xyz
Please see the attached patch.
--
Joseph LaFreniere
[PATCH] gnu: Add emacs-hyperbole.
- Done
Details
- 4 participants
- Alex ter Weele
- LaFreniere, Joseph
- Jakub K?dzio?ka
- swedebugia
- Owner
- unassigned
- Submitted by
- LaFreniere, Joseph
- Severity
- normal
L
L
(address . 36751@debbugs.gnu.org)
87a7d55q0w.fsf@odyssey.lafreniere.xyz
Please find a fixup commit attached. The original patch omitted
several sample files; whie those files are not necessary for the
functioning of Hyperbole itself, they are referred to in its menu system
and are valuable resources for new users.
--
Joseph LaFreniere
From 4624f21921730162f64b3efd90969e64eb54a39a Mon Sep 17 00:00:00 2001
From: Joseph LaFreniere <joseph@lafreniere.xyz>
Date: Mon, 22 Jul 2019 23:18:48 -0500
Subject: [PATCH] fixup! gnu: Add emacs-hyperbole.
---
gnu/packages/emacs-xyz.scm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Toggle diff (20 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7760b889aa..df01e1d931 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -201,7 +201,12 @@ metadata.")
"emacs-hyperbole-toggle-messaging.patch"))))
(build-system emacs-build-system)
(arguments
- `(#:include '("\\.el$" "\\.info$")
+ `(#:include '("DEMO"
+ "DEMO-ROLO.otl"
+ "HY-ABOUT"
+ "\\.el$"
+ "\\.info$"
+ "\\.kotl$")
#:phases
(modify-phases %standard-phases
(add-before 'install 'make-info
--
2.22.0
L
(address . 36751@debbugs.gnu.org)
877e7urii4.fsf@odyssey.lafreniere.xyz
I have squashed the fixup into the original commit and rebased on
current master (82ebb785f178d8618d39b658932d23d9f859fc91). The
resulting commit is attached.
--
Joseph LaFreniere
S
ee6cfed9-0472-5138-3a9f-caaaaa9d1c1e@riseup.net
Hi!
Thanks for the patch.
On 2019-08-03 06:16, LaFreniere, Joseph wrote:
Toggle quote (8 lines)
> I have squashed the fixup into the original commit and rebased on
> current master (82ebb785f178d8618d39b658932d23d9f859fc91). The
> resulting commit is attached.
>
>
> --
> Joseph LaFreniere
Git said this:
$ git apply 0001-gnu-Add-emacs-hyperbole.patch
0001-gnu-Add-emacs-hyperbole.patch:122: space before tab in indent.
(or (and (boundp 'user-mail-address)
0001-gnu-Add-emacs-hyperbole.patch:123: trailing whitespace.
--
0001-gnu-Add-emacs-hyperbole.patch:149: trailing whitespace.
0001-gnu-Add-emacs-hyperbole.patch:155: space before tab in indent.
(dname (or (and (boundp 'message-user-fqdn) (stringp
message-user-fqdn)
0001-gnu-Add-emacs-hyperbole.patch:156: space before tab in indent.
(string-match "\\." message-user-fqdn)
warning: squelched 10 whitespace errors
warning: 15 lines add whitespace errors.
---
Could you take a look at that?
Otherwise LGTM.
(I linted it, inspected the output in the store with 'ls -lR' and opened
the info file)
--
Cheers Swedebugia
A
(name . swedebugia)(address . swedebugia@riseup.net)
878shyrrj4.fsf@librem.i-did-not-set--mail-host-address--so-tickle-me
swedebugia <swedebugia@riseup.net> writes:
Toggle quote (33 lines)
> Hi!
>
> Thanks for the patch.
>
> On 2019-08-03 06:16, LaFreniere, Joseph wrote:
>> I have squashed the fixup into the original commit and rebased on
>> current master (82ebb785f178d8618d39b658932d23d9f859fc91). The
>> resulting commit is attached.
>>
>>
>> -- Joseph LaFreniere
>
> Git said this:
>
> $ git apply 0001-gnu-Add-emacs-hyperbole.patch
> 0001-gnu-Add-emacs-hyperbole.patch:122: space before tab in indent.
> ?? ? (or (and (boundp 'user-mail-address)
> 0001-gnu-Add-emacs-hyperbole.patch:123: trailing whitespace.
> --
> 0001-gnu-Add-emacs-hyperbole.patch:149: trailing whitespace.
>
> 0001-gnu-Add-emacs-hyperbole.patch:155: space before tab in indent.
> ?? (dname (or (and (boundp 'message-user-fqdn)
> (stringp message-user-fqdn)
> 0001-gnu-Add-emacs-hyperbole.patch:156: space before tab in indent.
> ?? ? ? (string-match "\\." message-user-fqdn)
> warning: squelched 10 whitespace errors
> warning: 15 lines add whitespace errors.
>
> ---
>
> Could you take a look at that?
I took a look at this. Regarding "trailing whitespace", I think
those are generated with trailing whitespace in them, so I think it is
normal that when adding .patch files to git that we'd see that
message. Regarding "space before tab in indent", a mixture of tabs and
spaces appears to be consistent with the Hyperbole codebase, so I think
that's ok too.
Attached is a patch that should apply against master. I have tested it a
bit, by going through some of the Hyperbole demo. Things like Koutliner
and Hycontrol seem to work, though I did not test all of Hyperbole's
many features.
Toggle quote (6 lines)
>
>
> Otherwise LGTM.
>
> (I linted it, inspected the output in the store with 'ls -lR' and
> opened the info file)
J
Done: [PATCH] gnu: Add emacs-hyperbole.
(address . 36751-done@debbugs.gnu.org)
20200620193342.ljdm4fhisdstcqo2@gravity
Thanks for the patch, pushed as commit 7d80d795248b029183b27361e9ab4895079375f7.
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl7uZJYACgkQ4xWnWEYT
FWTWxQ/5AcKa7wNmXZYSTKrWPj5qEEQcYXMuP58q6MKgB3MhyyUIRmjSgKp1+byP
AplVjTNs+k2iUst4Hz/Z6r0NhVf8g3t4nqycBjMqDFlHhOcUmO8To4+vXTXSaxsy
eq3wqNUYQx8DGqWth4l236D6bO2CTpBxF15OqiT51RkHrPgQ5eeWbpax/4YE9KdT
o5JELyyH4PnNtHZhIvJbhsNF98aRfkM/0YFEK+Mdi+Bp1Cz9EYo0T0sPS5Hw9N1d
kGR/7dH217yFRa2cdbJBBLPTYHeSOJShehhz51vU/8ZFfJiBnizjtqrQn+f7ZLxv
lycxZsBbvOHbU69qH5DOyzkIYkZ1nY735BUakt9q2tRcr0WaTvlBmSqmWKOuUwEM
8LR7SnJsUHLjTuHKs16TriyO1dJge/W+RQltZPQiWQ13R0pRY4D5UYN/Vk8fDXpm
E2RlbUMl51pUjAN2gO+aquN7PQ+UVgAhENBeH8Ia2a/zAcr0LEhIaS43BQZsVeOv
+udt2iF7FQr86insRmDO2t0GzxBvP5/KN3TkcyNI4JKq3dqUF5z0verKFGR5a002
VlJ48cxip1pzPKRy1EpTiqj2jP6S2tyYseQeNVaRXvk2nrQXH8dHXw/OU7qO5lxj
btqlYHjcY7M3ocRw+fQR65bbbSVebjQqVI9VbhhbkUG1ZTsFdtE=
=ISKl
-----END PGP SIGNATURE-----
Closed
?