[PATCH] installer: Speak of keyboard layout language.

  • Open
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Tobias Geerinckx-Rice
Severity
normal
T
T
Tobias Geerinckx-Rice wrote on 14 May 2019 19:55
(address . guix-patches@gnu.org)
20190514175540.24394-1-me@tobias.gr
* gnu/installer/newt/keymap.scm (run-layout-page): Tweak #:info-text.
---

Guix,

I'm finally trying out this fancy installer.

In the list of keyboard layouts, I scrolled down to ‘US’ but it didn't exist, because (for better or worse) the list we use is language-oriented. I now better understand how people have been confused in the past.

OK to apply this tweak?

T G-R

gnu/installer/newt/keymap.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/installer/newt/keymap.scm b/gnu/installer/newt/keymap.scm
index 2908ba7f0e..6386ac4e45 100644
--- a/gnu/installer/newt/keymap.scm
+++ b/gnu/installer/newt/keymap.scm
@@ -37,7 +37,7 @@
(let ((title (G_ "Layout")))
(run-listbox-selection-page
#:title title
- #:info-text (G_ "Please choose your keyboard layout.")
+ #:info-text (G_ "Please choose your keyboard layout language.")
#:listbox-items layouts
#:listbox-item->text layout->text
#:sort-listbox-items? #f
--
2.21.0
L
L
Ludovic Courtès wrote on 15 May 2019 14:41
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 35733@debbugs.gnu.org)
87tvdvvqi6.fsf@gnu.org
Hi Tobias,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

Toggle quote (2 lines)
> OK to apply this tweak?

Not for 1.0.1 IMO as this would invalidate translations.

Other than that, I don’t know if adding “language” helps, but maybe it
does?

Thanks,
Ludo’.
?