'posix_spawn' glibc 2.26 race condition fires under qemu-binfmt

Danny Milosavljevic wrote on 8 Feb 2018 17:42

ARM compilation via qemu binfmt - Assertion failure

Recipients:

Message-ID:20180208174238.2abc85dc@scratchpost.org

Hi ng0,
On Tue, 06 Feb 2018 10:33:56 +0000ng0@n0.is wrote:

Toggle quote (2 lines)

> recently I've read about slow but native compiling of ARM on qemu.

Unfortunately, there's a (pretty reproducible) problem with it.
guix-master/guix $ ./pre-inst-env guix system disk-image --system=armhf-linux -e "(@ (gnu system install) installation-os)"[... building grub-2.02 ...]phase `configure' succeeded after 821.8 secondsstarting phase `patch-generated-file-shebangs'patch-makefile-SHELL: ./po/Makefile: changing `SHELL' from `/bin/sh' to `/gnu/st[...]phase `patch-generated-file-shebangs' succeeded after 14.6 secondsstarting phase `build'bison -d -p grub_script_yy -b grub_script ./grub-core/script/parser.yflex -o grub_script.yy.c --header-file=grub_script.yy.h ./grub-core/script/yylex[...]bison: ../sysdeps/unix/sysv/linux/spawni.c:360: __spawnix: Assertion `ec >= 0' failed
This is only fixed in glibc 2.27 (not in core-updates).
The fix is:
https://sourceware.org/bugzilla/show_bug.cgi?id=22273

Toggle diff (22 lines)diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.cindex dea1650..f02ac19 100644--- a/sysdeps/unix/sysv/linux/spawni.c+++ b/sysdeps/unix/sysv/linux/spawni.c@@ -365,9 +365,15 @@ __spawnix (pid_t * pid, const char *file,   if (new_pid > 0)     {       ec = args.err;-      assert (ec >= 0);       if (ec != 0)-         __waitpid (new_pid, NULL, 0);+       {+         /* It handles the unlikely case where the auxiliary vfork process+            is killed before calling _exit or execve.  */+         int status;+         __waitpid (new_pid, &status, 0);+         if (WIFSIGNALED (status))+           ec = 0;+       }     }   else     ec = -new_pid;

Chris Marusich wrote on 11 Feb 2018 00:45

Recipients:(name . Danny Milosavljevic)(address . dannym@scratchpost.org)

Message-ID:87fu68o1dd.fsf@gmail.com

Danny Milosavljevic <dannym@scratchpost.org> writes:

Toggle quote (2 lines)

> This is only fixed in glibc 2.27 (not in core-updates).

Should we upgrade glibc in core-updates, then? Or is it better to do itin the next core-updates cycle, to avoid still more unexpected breakage?
-- Chris

Leo Famulari wrote on 11 Feb 2018 02:07

Re: bug#30394: ARM compilation via qemu binfmt - Assertion failure

Recipients:(name . Chris Marusich)(address . cmmarusich@gmail.com)

Message-ID:20180211010728.GB28859@jasmine.lan

On Sun, Feb 11, 2018 at 12:45:18AM +0100, Chris Marusich wrote:

Toggle quote (7 lines)

> Danny Milosavljevic <dannym@scratchpost.org> writes:> > > This is only fixed in glibc 2.27 (not in core-updates).> > Should we upgrade glibc in core-updates, then? Or is it better to do it> in the next core-updates cycle, to avoid still more unexpected breakage?

It's too late in this cycle. Upgrading glibc would require a fullrebuild and would introduce new failures.

Pjotr Prins wrote on 11 Feb 2018 10:53

Re: ARM compilation via qemu binfmt - Assertion failure

Recipients:(name . Chris Marusich)(address . cmmarusich@gmail.com)

Message-ID:20180211095332.GA18764@thebird.nl

On Sun, Feb 11, 2018 at 12:45:18AM +0100, Chris Marusich wrote:

Toggle quote (7 lines)

I think we should not update packages deep in the tree unless there isa security patch. What we have now is well tested.
Pj.

--

Ludovic Courtès wrote on 16 Feb 2018 11:35

Re: bug#30394: ARM compilation via qemu binfmt - Assertion failure

Recipients:(name . Danny Milosavljevic)(address . dannym@scratchpost.org)

Message-ID:87vaexp6gw.fsf@gnu.org

Hello,
Danny Milosavljevic <dannym@scratchpost.org> skribis:

Toggle quote (13 lines)> Unfortunately, there's a (pretty reproducible) problem with it.>> guix-master/guix $ ./pre-inst-env guix system disk-image --system=armhf-linux -e "(@ (gnu system install) installation-os)"> [... building grub-2.02 ...]> phase `configure' succeeded after 821.8 seconds> starting phase `patch-generated-file-shebangs'> patch-makefile-SHELL: ./po/Makefile: changing `SHELL' from `/bin/sh' to `/gnu/st[...]> phase `patch-generated-file-shebangs' succeeded after 14.6 seconds> starting phase `build'> bison -d -p grub_script_yy -b grub_script ./grub-core/script/parser.y> flex -o grub_script.yy.c --header-file=grub_script.yy.h ./grub-core/script/yylex[...]> bison: ../sysdeps/unix/sysv/linux/spawni.c:360: __spawnix: Assertion `ec >= 0' failed

[...]

Toggle quote (12 lines)> https://sourceware.org/bugzilla/show_bug.cgi?id=22273> diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c> index dea1650..f02ac19 100644> --- a/sysdeps/unix/sysv/linux/spawni.c> +++ b/sysdeps/unix/sysv/linux/spawni.c> @@ -365,9 +365,15 @@ __spawnix (pid_t * pid, const char *file,>    if (new_pid > 0)>      {>        ec = args.err;> -      assert (ec >= 0);>        if (ec != 0)

Note that this is only a problem for code that uses the ‘posix_spawn’interface, such as Bison in the example above.
In practice that interface is rarely used, which is probably why I neverhit that assertion before.
Ludo’.

Ludovic Courtès wrote on 9 Mar 2018 13:36

control message for bug #30394

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87r2otzarl.fsf@gnu.org

retitle 30394 'posix_spawn' glibc 2.26 race condition fires under qemu-binfmt

Ludovic Courtès wrote on 31 Jan 2020 18:41

Recipients:(address . control@debbugs.gnu.org)

Message-ID:87k1574j6o.fsf@gnu.org

tags 30394 notabugclose 30394quit

Your comment

This issue is archived.

To comment on this conversation send email to 30394@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date