[PATCH] gnu: Add urho3d.

Oleg Pykhalov wrote on 10 Jan 2018 23:24

Recipients:(address . guix-patches@gnu.org)

Message-ID:87y3l5ic8f.fsf@gmail.com

Hello Guix,
This patch adds a 3D game engine.

From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001
* gnu/packages/game-development.scm (urho3d): New public variable.--- gnu/packages/game-development.scm | 51 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+)

Toggle diff (61 lines)diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scmindex 363d9a253..69045cf9c 100644--- a/gnu/packages/game-development.scm+++ b/gnu/packages/game-development.scm@@ -1150,3 +1150,54 @@ features design tools such as a visual editor, can import 3D models and provide high-quality 3D rendering, it contains an animation editor, and can be scripted in a Python-like language.")     (license license:expat)))++(define-public urho3d+  (package+    (name "urho3d")+    (version "1.7")+    (source (origin+              (method url-fetch)+              (uri (string-append "https://github.com/urho3d/Urho3D"+                                  "/archive/" version ".tar.gz"))+              (file-name (string-append name "-" version ".tar.gz"))+              (sha256+               (base32+                "1im63n9rx8qq1ks6aq6jrl5ikxg87hqhsy06miqc317hpm1iyav5"))))+    (build-system cmake-build-system)+    (inputs `(("libx11" ,libx11)+              ("libxcursor" ,libxcursor)+              ("libxext" ,libxext)+              ("libxi" ,libxi)+              ("libxinerama" ,libxinerama)+              ("libxrandr" ,libxrandr)+              ("libxrender" ,libxrender)+              ("libxscrnsaver" ,libxscrnsaver)+              ("mesa" ,mesa)+              ("alsa-lib" ,alsa-lib)+              ("pulseaudio" ,pulseaudio)))+    (arguments+     '(#:tests?+       #f ; There are no tests+       #:phases+       (modify-phases %standard-phases+         (add-after 'configure 'use-full-library-paths+           (lambda* (#:key inputs #:allow-other-keys)+             (substitute* (string-append "../build/Source/ThirdParty"+                                         "/SDL/include/generated/SDL_config.h")+               (("#define SDL_AUDIO_DRIVER_ALSA_DYNAMIC \"libasound\\.so\\.2\"")+                (string-append "#define SDL_AUDIO_DRIVER_ALSA_DYNAMIC \""+                               (assoc-ref inputs "alsa-lib")+                               "/lib/libasound.so.2"+                               "\""))+               (((string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC"+                                " \"libpulse-simple\\.so\\.0\""))+                (string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC \""+                               (assoc-ref inputs "pulseaudio")+                               "/lib/libpulse-simple.so.0"+                               "\"")))+             #t)))))+    (home-page "https://urho3d.github.io/")+    (synopsis "Cross-platform 2D and 3D game engine")+    (description "Lightweight, cross-platform 2D and 3D game engine+implemented in C++.  Inspired by OGRE and Horde3D.")+    (license license:expat)))-- 2.15.1

Also the latest version of engine could be build with:

Toggle snippet (21 lines)(define-public urho3d-checkout  (let ((commit "4af4148048a6443154c6f0498d32626d10f1e86b")        (revision "1"))    (package      (inherit urho3d)      (name "urho3d-checkout")      (version (string-append (package-version urho3d) "-" revision "."                              (string-take commit 7)))      (source (origin                (method git-fetch)                (uri (git-reference                      (url "https://github.com/urho3d/Urho3D")                      (commit commit)))                (file-name (string-append name "-" version "-checkout"))                (sha256                 (base32                  "1nchxswrkfgzsxghi6c55b27zy9127ni7yvnb4xw2xdddyfm1wl0")))))))--8<---------------cut here---------------end--------------->8---
Thanks,Oleg.

Ludovic Courtès wrote on 12 Jan 2018 15:01

Recipients:(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 30084@debbugs.gnu.org)

Message-ID:87shbbqiq5.fsf@gnu.org

Hi Oleg,
Oleg Pykhalov <go.wigust@gmail.com> skribis:

Toggle quote (7 lines)

> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001> From: Oleg Pykhalov <go.wigust@gmail.com>> Date: Thu, 11 Jan 2018 01:14:41 +0300> Subject: [PATCH] gnu: Add urho3d.>> * gnu/packages/game-development.scm (urho3d): New public variable.

[...]

Toggle quote (4 lines)

> + (lambda* (#:key inputs #:allow-other-keys)> + (substitute* (string-append "../build/Source/ThirdParty"> + "/SDL/include/generated/SDL_config.h")

IIUC there’s a bundled copy of SDL, right? Can we instead build againstour SDL?
Ideally, to be safe from bundling, we should “rm -rf ThirdParty” in asnippet. Is that possible?

Toggle quote (7 lines)

> + (((string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC"> + " \"libpulse-simple\\.so\\.0\""))> + (string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC \""> + (assoc-ref inputs "pulseaudio")> + "/lib/libpulse-simple.so.0"> + "\"")))

Please use a literal string in the ‘substitute*’ pattern (you can usebackslashes to split it on several lines.)

Toggle quote (3 lines)

> + (description "Lightweight, cross-platform 2D and 3D game engine> +implemented in C++. Inspired by OGRE and Horde3D.")

Full sentences please! :-)
https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html
Could you send an updated path?
Thank you,Ludo’.

Oleg Pykhalov wrote on 23 Jan 2018 14:29

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 30084@debbugs.gnu.org)

Message-ID:87r2qgput3.fsf@gmail.com

Hello Ludovic,
Thank you for review!
ludo@gnu.org (Ludovic Courtès) writes:

Toggle quote (20 lines)> Hi Oleg,>> Oleg Pykhalov <go.wigust@gmail.com> skribis:>>> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001>> From: Oleg Pykhalov <go.wigust@gmail.com>>> Date: Thu, 11 Jan 2018 01:14:41 +0300>> Subject: [PATCH] gnu: Add urho3d.>>>> * gnu/packages/game-development.scm (urho3d): New public variable.>> [...]>>> +           (lambda* (#:key inputs #:allow-other-keys)>> +             (substitute* (string-append "../build/Source/ThirdParty">> +                                         "/SDL/include/generated/SDL_config.h")>> IIUC there’s a bundled copy of SDL, right?  Can we instead build against> our SDL?

Yes, it's a bundled copy. We probably can, but how? The build systemprobably configured look for 'Source/ThirdParty/SDL'. So should we makea symbolic link like 'Source/ThirdParty/SDL' -> '/gnu/store/…-SDL'?
I'll check this later. Maybe it will search for a system first SDL andif not find it use their own. Also I have a question about SDL in thefollowing quote.

Toggle quote (3 lines)

> Ideally, to be safe from bundling, we should “rm -rf ThirdParty” in a> snippet. Is that possible?

Unfortunately no. The contents of the 'Source/ThirdParty' has much morethan just SDL. It's too much work for now, but a good TODO.
Source/ThirdParty/SDL
AngelScript Assimp boost Box2D Bullet Civetweb Detour DetourCrowd DetourTileCache FreeType GLEW ik JO kNet LibCpuId LICENSES Lua LuaJIT LZ4 MojoShader Mustache nanodbc PugiXml rapidjson Recast SDL SQLite StanHull STB toluapp WebP
Actually I wonder will those libraries and the engine overall play nicewith OUR SDL library? Should we provide a Guix version and bundledlibraries version?

Toggle quote (10 lines)>> +               (((string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC">> +                                " \"libpulse-simple\\.so\\.0\""))>> +                (string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC \"">> +                               (assoc-ref inputs "pulseaudio")>> +                               "/lib/libpulse-simple.so.0">> +                               "\"")))>> Please use a literal string in the ‘substitute*’ pattern (you can use> backslashes to split it on several lines.)

OK. Thanks for notice!

Toggle quote (7 lines)

>> + (description "Lightweight, cross-platform 2D and 3D game engine>> +implemented in C++. Inspired by OGRE and Horde3D.")>> Full sentences please! :-)>> https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html

Oh, thanks!

Toggle quote (1 lines)

> Could you send an updated path?

From 5a906d8a8a9ff50ed46b5ffc33714b11517e23ca Mon Sep 17 00:00:00 2001
* gnu/packages/game-development.scm (urho3d): New public variable.--- gnu/packages/game-development.scm | 51 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+)

Toggle diff (61 lines)diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scmindex 0b08b04f5..3c5eae5cd 100644--- a/gnu/packages/game-development.scm+++ b/gnu/packages/game-development.scm@@ -1206,3 +1206,54 @@ related games such as Heretic and Hexen.  It comes with a 3d preview mode and a 2D editor view.")     (home-page "http://eureka-editor.sourceforge.net/")     (license license:gpl2+)))++(define-public urho3d+  (package+    (name "urho3d")+    (version "1.7")+    (source (origin+              (method url-fetch)+              (uri (string-append "https://github.com/urho3d/Urho3D"+                                  "/archive/" version ".tar.gz"))+              (file-name (string-append name "-" version ".tar.gz"))+              (sha256+               (base32+                "1im63n9rx8qq1ks6aq6jrl5ikxg87hqhsy06miqc317hpm1iyav5"))))+    (build-system cmake-build-system)+    (inputs `(("libx11" ,libx11)+              ("libxcursor" ,libxcursor)+              ("libxext" ,libxext)+              ("libxi" ,libxi)+              ("libxinerama" ,libxinerama)+              ("libxrandr" ,libxrandr)+              ("libxrender" ,libxrender)+              ("libxscrnsaver" ,libxscrnsaver)+              ("mesa" ,mesa)+              ("alsa-lib" ,alsa-lib)+              ("pulseaudio" ,pulseaudio)))+    (arguments+     '(#:tests?+       #f ; There are no tests+       #:phases+       (modify-phases %standard-phases+         (add-after 'configure 'use-full-library-paths+           (lambda* (#:key inputs #:allow-other-keys)+             (substitute* "../build/Source/ThirdParty\+/SDL/include/generated/SDL_config.h"+               (("#define SDL_AUDIO_DRIVER_ALSA_DYNAMIC \"libasound\\.so\\.2\"")+                (string-append "#define SDL_AUDIO_DRIVER_ALSA_DYNAMIC \""+                               (assoc-ref inputs "alsa-lib")+                               "/lib/libasound.so.2"+                               "\""))+               (((string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC"+                                " \"libpulse-simple\\.so\\.0\""))+                (string-append "#define SDL_AUDIO_DRIVER_PULSEAUDIO_DYNAMIC \""+                               (assoc-ref inputs "pulseaudio")+                               "/lib/libpulse-simple.so.0"+                               "\"")))+             #t)))))+    (home-page "https://urho3d.github.io/")+    (synopsis "Cross-platform 2D and 3D game engine")+    (description "This package provides a lightweight, cross-platform 2D and+3D game engine implemented in C++.  Inspired by OGRE and Horde3D.")+    (license license:expat)))-- 2.15.1

Oleg.

Ludovic Courtès wrote on 23 Jan 2018 15:07

Recipients:(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 30084@debbugs.gnu.org)

Message-ID:87vafs653b.fsf@gnu.org

Hello,
Oleg Pykhalov <go.wigust@gmail.com> skribis:

Toggle quote (26 lines)> ludo@gnu.org (Ludovic Courtès) writes:>>> Hi Oleg,>>>> Oleg Pykhalov <go.wigust@gmail.com> skribis:>>>>> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001>>> From: Oleg Pykhalov <go.wigust@gmail.com>>>> Date: Thu, 11 Jan 2018 01:14:41 +0300>>> Subject: [PATCH] gnu: Add urho3d.>>>>>> * gnu/packages/game-development.scm (urho3d): New public variable.>>>> [...]>>>>> +           (lambda* (#:key inputs #:allow-other-keys)>>> +             (substitute* (string-append "../build/Source/ThirdParty">>> +                                         "/SDL/include/generated/SDL_config.h")>>>> IIUC there’s a bundled copy of SDL, right?  Can we instead build against>> our SDL?>> Yes, it's a bundled copy.  We probably can, but how?  The build system> probably configured look for 'Source/ThirdParty/SDL'.  So should we make> a symbolic link like 'Source/ThirdParty/SDL' -> '/gnu/store/…-SDL'?

Rather, we should adjust CMakeLists.txt (if needed) so that it linksagainst our copy of SDL, like Fis Trivial did with ‘rct’ today.

Toggle quote (13 lines)>> Ideally, to be safe from bundling, we should “rm -rf ThirdParty” in a>> snippet.  Is that possible?>> Unfortunately no.  The contents of the 'Source/ThirdParty' has much more> than just SDL.  It's too much work for now, but a good TODO.>> Source/ThirdParty/SDL>>     AngelScript Assimp boost Box2D Bullet Civetweb Detour DetourCrowd>     DetourTileCache FreeType GLEW ik JO kNet LibCpuId LICENSES Lua>     LuaJIT LZ4 MojoShader Mustache nanodbc PugiXml rapidjson Recast SDL>     SQLite StanHull STB toluapp WebP

Ouch, that’s a lot of stuff! We should at least remove boost, FreeType,GLEW, Lua, LuaJIT, LZ4, SDL, and SQLite, for which we have packages.

Toggle quote (4 lines)

> Actually I wonder will those libraries and the engine overall play nice> with OUR SDL library? Should we provide a Guix version and bundled> libraries version?

We’ll have to try; hopefully they’re shipping an unmodified SDL.

Toggle quote (7 lines)

> From 5a906d8a8a9ff50ed46b5ffc33714b11517e23ca Mon Sep 17 00:00:00 2001> From: Oleg Pykhalov <go.wigust@gmail.com>> Date: Thu, 11 Jan 2018 01:14:41 +0300> Subject: [PATCH] gnu: Add urho3d.>> * gnu/packages/game-development.scm (urho3d): New public variable.

Could you please try unbundling the things mentioned above, and add aFIXME for those we’re not unbundling yet? We should try and see howdifficult it is; for ‘rct’ it was OK.
Thank you!
Ludo’.

Leo Famulari wrote on 13 Feb 2019 01:12

(no subject)

Recipients:(address . control@debbugs.gnu.org)

Message-ID:20190213001219.GB2568@jasmine.lan

tag 30084 moreinfo

Leo Famulari wrote on 22 Mar 2020 21:42

Re: [bug#30084] [PATCH] gnu: Add urho3d.

Recipients:(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 30084@debbugs.gnu.org)

Message-ID:20200322204230.GA19668@jasmine.lan

On Thu, Jan 11, 2018 at 01:24:16AM +0300, Oleg Pykhalov wrote:

Toggle quote (7 lines)

> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001> From: Oleg Pykhalov <go.wigust@gmail.com>> Date: Thu, 11 Jan 2018 01:14:41 +0300> Subject: [PATCH] gnu: Add urho3d.> > * gnu/packages/game-development.scm (urho3d): New public variable.

What is the status of this patch? Do you still intend to add it to Guixor can we close the ticket?

Oleg Pykhalov wrote on 23 Mar 2020 08:54

Recipients:(name . Leo Famulari)(address . leo@famulari.name)

Message-ID:87y2rrld4i.fsf@gmail.com

Hello Leo,
Leo Famulari <leo@famulari.name> writes:

Toggle quote (11 lines)> On Thu, Jan 11, 2018 at 01:24:16AM +0300, Oleg Pykhalov wrote:>> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001>> From: Oleg Pykhalov <go.wigust@gmail.com>>> Date: Thu, 11 Jan 2018 01:14:41 +0300>> Subject: [PATCH] gnu: Add urho3d.>> >> * gnu/packages/game-development.scm (urho3d): New public variable.>> What is the status of this patch? Do you still intend to add it to Guix> or can we close the ticket?

I'm not sure about the time when I will prepare the package withoutbuilt-in third-party dependencies. So we could close the ticket until.
Oleg.

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date