Add virtaal (translation app)

  • Done
  • quality assurance status badge
Details
5 participants
  • Arun Isaac
  • Oleg Pykhalov
  • Ludovic Courtès
  • Christopher Baines
  • Mark Meyer
Owner
unassigned
Submitted by
Mark Meyer
Severity
normal
M
M
Mark Meyer wrote on 16 Dec 2017 11:09
(address . guix-patches@gnu.org)
1513418996.2275632.1206998744.71939143@webmail.messagingengine.com
Hi,
I just wanted to quickly have someone look over the following changes:

- Add python2-pycurl adds pycurl (it's Py2 only)
- Update python2-gobject-2 to 2.28.7 (the most recent, patch still
seems to apply

This update pulls in a lot of changes that were present in
distrubutions for a long time

- Add virtaal

This just adds virtaal with proper dependencies.

Cheers, Mark

--
Mark Meyer
mark@ofosos.org
From 6b2b028d4500a535faa3442daa0c228f9c98b93f Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Fri, 15 Dec 2017 10:09:28 +0100
Subject: [PATCH] gnu: Add python2-pycurl.

* gnu/packages/python-web.scm (python2-pycurl): New public variable.
---
gnu/packages/python-web.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

Toggle diff (59 lines)
diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 12e45b2ef..502834bdc 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -22,6 +22,7 @@
;;; Copyright © 2016 David Craven <david@craven.ch>
;;; Copyright © 2017 Oleg Pykhalov <go.wigust@gmail.com>
;;; Copyright © 2015, 2016 David Thompson <davet@gnu.org>
+;;; Copyright © 2017 Mark Meyer <mark@ofosos.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -45,11 +46,13 @@
#:use-module (gnu packages)
#:use-module (gnu packages check)
#:use-module (gnu packages compression)
+ #:use-module (gnu packages curl)
#:use-module (gnu packages databases)
#:use-module (gnu packages django)
#:use-module (gnu packages pkg-config)
#:use-module (gnu packages python)
#:use-module (gnu packages python-crypto)
+ #:use-module (gnu packages tls)
#:use-module (gnu packages time)
#:use-module (gnu packages xml)
#:use-module ((guix licenses) #:prefix license:)
@@ -238,6 +241,30 @@ C, yielding parse times that can be a thirtieth of the html5lib parse times.")
(define-public python2-html5-parser
(package-with-python2 python-html5-parser))
+(define-public python2-pycurl
+ (package
+ (name "python2-pycurl")
+ (version "7.43.0.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://dl.bintray.com/pycurl/pycurl/pycurl-" version ".tar.gz"))
+ (sha256
+ (base32 "1ali1gjs9iliwjra7w0y5hwg79a2fd0f4ydvv6k27sgxpbr1n8s3"))))
+ (build-system python-build-system)
+ (arguments `(#:python ,python-2)) ; no Python 3 support
+ (native-inputs
+ `(("python-nose" ,python-nose)
+ ("python-bottle" ,python-bottle)))
+ (inputs
+ `(("curl" ,curl)
+ ("gnutls" ,gnutls)))
+ (home-page "http://pycurl.io/")
+ (synopsis "Lightweight Python wrapper around libcurl")
+ (description "Pycurl is a lightweight wrapper around libcurl. It provides
+high speed transfers via libcurl and frequently outperforms alternatives.")
+ (license license:lgpl2.0)))
+
(define-public python-webencodings
(package
(name "python-webencodings")
--
2.15.1
From 8a71cee704727f80e4146ee87a06c462bf59a9c5 Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Sat, 16 Dec 2017 10:57:21 +0100
Subject: [PATCH] gnu: python2-gobject-2: Update to 2.28.7

* gnu/packages/glib.scm (python2-gobject-2): Update to 2.28.7.
---
gnu/packages/glib.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
index de7427859..40d23e104 100644
--- a/gnu/packages/glib.scm
+++ b/gnu/packages/glib.scm
@@ -543,7 +543,7 @@ useful for C++.")
(name "python2-pygobject")
;; This was the last version to declare the 2.0 platform number, i.e. its
;; pkg-config files were named pygobject-2.0.pc
- (version "2.28.6")
+ (version "2.28.7")
(source
(origin
(method url-fetch)
@@ -552,7 +552,7 @@ useful for C++.")
"/pygobject-" version ".tar.xz"))
(sha256
(base32
- "1f5dfxjnil2glfwxnqr14d2cjfbkghsbsn8n04js2c2icr7iv2pv"))
+ "0nkam61rsn7y3wik3vw46wk5q2cjfh2iph57hl9m39rc8jijb7dv"))
(patches (search-patches
"python2-pygobject-2-gi-info-type-error-domain.patch"))))
(build-system gnu-build-system)
--
2.15.1
From c36fde0cfda0d5f9830876abbff804504004451d Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Fri, 15 Dec 2017 12:35:38 +0100
Subject: [PATCH] gnu: Add virtaal.

* gnu/packages/text-editors.scm (virtaal): New public variable.
---
gnu/packages/text-editors.scm | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)

Toggle diff (65 lines)
diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index 44b42ce9b..773000ff4 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -6,6 +6,7 @@
;;; Copyright © 2017 ng0 <ng0@infotropique.org>
;;; Copyright © 2014 Taylan Ulrich Bay?rl?/Kammer <taylanbayirli@gmail.org>
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2017 Mark Meyer <mark@ofosos.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -29,6 +30,7 @@
#:use-module (guix utils)
#:use-module (guix build-system gnu)
#:use-module (guix build-system glib-or-gtk)
+ #:use-module (guix build-system python)
#:use-module ((guix licenses) #:prefix license:)
#:use-module (gnu packages)
#:use-module (gnu packages assembly)
@@ -41,11 +43,42 @@
#:use-module (gnu packages lua)
#:use-module (gnu packages ncurses)
#:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages python)
+ #:use-module (gnu packages python-web)
#:use-module (gnu packages regex)
#:use-module (gnu packages ruby)
#:use-module (gnu packages terminals)
#:use-module (gnu packages xml))
+(define-public virtaal
+ (package
+ (name "virtaal")
+ (version "0.7.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/translate/Virtaal/"
+ version "/virtaal-" version ".tar.bz2"))
+ (sha256
+ (base32
+ "0cyimjp3191qlmw6n0ipqdr9xr0cq4f6dqvz4rl9q31h6l3kywf9"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:python ,python-2
+ #:use-setuptools? #f
+ #:tests? #f))
+ (propagated-inputs
+ `(("python2-pycurl" ,python2-pycurl)
+ ("python2-pygtk" ,python2-pygtk)
+ ("python2-lxml" ,python2-lxml)
+ ("python2-translate-toolkit" ,python2-translate-toolkit)
+ ("python2-simplejson" ,python2-simplejson)))
+ (synopsis "An editor for translation files")
+ (description
+ "Virtaal, a feature rich translation tool that allows you to focus on
+translation, without the tool getting in the way.")
+ (home-page "http://virtaal.translatehouse.org/")
+ (license license:gpl2)))
+
(define-public vis
(package
(name "vis")
--
2.15.1
O
O
Oleg Pykhalov wrote on 16 Dec 2017 12:49
(name . Mark Meyer)(address . mark@ofosos.org)(address . 29733@debbugs.gnu.org)
87ind6x585.fsf@gmail.com
Hello Mark,

This is an amazing program! Thank you for packaging this!

But I see some issues which need to be solved before merging if you
could do it, please. Ask questions if you need here or on on any Guix

Mark Meyer <mark@ofosos.org> writes:

Toggle quote (62 lines)
> I just wanted to quickly have someone look over the following changes:
>
> - Add python2-pycurl adds pycurl (it's Py2 only)
> - Update python2-gobject-2 to 2.28.7 (the most recent, patch still
> seems to apply
>
> This update pulls in a lot of changes that were present in
> distrubutions for a long time
>
> - Add virtaal
>
> This just adds virtaal with proper dependencies.
>
> From 6b2b028d4500a535faa3442daa0c228f9c98b93f Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark@ofosos.org>
> Date: Fri, 15 Dec 2017 10:09:28 +0100
> Subject: [PATCH] gnu: Add python2-pycurl.
>
> * gnu/packages/python-web.scm (python2-pycurl): New public variable.
> ---
> gnu/packages/python-web.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 12e45b2ef..502834bdc 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -22,6 +22,7 @@
> ;;; Copyright 2016 David Craven <david@craven.ch>
> ;;; Copyright 2017 Oleg Pykhalov <go.wigust@gmail.com>
> ;;; Copyright 2015, 2016 David Thompson <davet@gnu.org>
> +;;; Copyright 2017 Mark Meyer <mark@ofosos.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -45,11 +46,13 @@
> #:use-module (gnu packages)
> #:use-module (gnu packages check)
> #:use-module (gnu packages compression)
> + #:use-module (gnu packages curl)
> #:use-module (gnu packages databases)
> #:use-module (gnu packages django)
> #:use-module (gnu packages pkg-config)
> #:use-module (gnu packages python)
> #:use-module (gnu packages python-crypto)
> + #:use-module (gnu packages tls)
> #:use-module (gnu packages time)
> #:use-module (gnu packages xml)
> #:use-module ((guix licenses) #:prefix license:)
> @@ -238,6 +241,30 @@ C, yielding parse times that can be a thirtieth of the html5lib parse times.")
> (define-public python2-html5-parser
> (package-with-python2 python-html5-parser))
>
> +(define-public python2-pycurl
> + (package
> + (name "python2-pycurl")
> + (version "7.43.0.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://dl.bintray.com/pycurl/pycurl/pycurl-" version ".tar.gz"))

Please, use guix lint before sending patches.

./pre-inst-env guix lint python2-pycurl

/home/natsu/src/guix/gnu/packages/python-web.scm:245:2: python2-pycurl@7.43.0.1: line 251 is way too long (93 characters)


There is etc/indent-code.el to make life easier if you not Emacs user,
but I didn't check it myself.


Toggle quote (5 lines)
> + (sha256
> + (base32 "1ali1gjs9iliwjra7w0y5hwg79a2fd0f4ydvv6k27sgxpbr1n8s3"))))
> + (build-system python-build-system)
> + (arguments `(#:python ,python-2)) ; no Python 3 support

Does it actually not support? Requirements in documentation

Toggle quote (11 lines)
> + (native-inputs
> + `(("python-nose" ,python-nose)
> + ("python-bottle" ,python-bottle)))
> + (inputs
> + `(("curl" ,curl)
> + ("gnutls" ,gnutls)))
> + (home-page "http://pycurl.io/")
> + (synopsis "Lightweight Python wrapper around libcurl")
> + (description "Pycurl is a lightweight wrapper around libcurl. It provides
> +high speed transfers via libcurl and frequently outperforms alternatives.")

Another linter warning.

gnu/packages/python-web.scm:264:17: python2-pycurl@7.43.0.1: sentences in description should be followed by two spaces; possible infraction at 46

Toggle quote (2 lines)
> + (license license:lgpl2.0)))

tar xf $(./pre-inst-env guix build -S python2-pycurl)

There are two files in licenses in source tarball COPYING-LGPL
COPYING-MIT. The second (expat) license probably should be included in
the package recipe.

Toggle quote (7 lines)
> +
> (define-public python-webencodings
> (package
> (name "python-webencodings")
> --
> 2.15.1

Also there is a tests directory in source tarball. Could you look on
them? .travis.yml file in pycurl git repository could help

Toggle quote (35 lines)
> From 8a71cee704727f80e4146ee87a06c462bf59a9c5 Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark@ofosos.org>
> Date: Sat, 16 Dec 2017 10:57:21 +0100
> Subject: [PATCH] gnu: python2-gobject-2: Update to 2.28.7
>
> * gnu/packages/glib.scm (python2-gobject-2): Update to 2.28.7.
> ---
> gnu/packages/glib.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/glib.scm b/gnu/packages/glib.scm
> index de7427859..40d23e104 100644
> --- a/gnu/packages/glib.scm
> +++ b/gnu/packages/glib.scm
> @@ -543,7 +543,7 @@ useful for C++.")
> (name "python2-pygobject")
> ;; This was the last version to declare the 2.0 platform number, i.e. its
> ;; pkg-config files were named pygobject-2.0.pc
> - (version "2.28.6")
> + (version "2.28.7")
> (source
> (origin
> (method url-fetch)
> @@ -552,7 +552,7 @@ useful for C++.")
> "/pygobject-" version ".tar.xz"))
> (sha256
> (base32
> - "1f5dfxjnil2glfwxnqr14d2cjfbkghsbsn8n04js2c2icr7iv2pv"))
> + "0nkam61rsn7y3wik3vw46wk5q2cjfh2iph57hl9m39rc8jijb7dv"))
> (patches (search-patches
> "python2-pygobject-2-gi-info-type-error-domain.patch"))))
> (build-system gnu-build-system)
> --
> 2.15.1

LGTM

Toggle quote (59 lines)
>
> From c36fde0cfda0d5f9830876abbff804504004451d Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark@ofosos.org>
> Date: Fri, 15 Dec 2017 12:35:38 +0100
> Subject: [PATCH] gnu: Add virtaal.
>
> * gnu/packages/text-editors.scm (virtaal): New public variable.
> ---
> gnu/packages/text-editors.scm | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
> index 44b42ce9b..773000ff4 100644
> --- a/gnu/packages/text-editors.scm
> +++ b/gnu/packages/text-editors.scm
> @@ -6,6 +6,7 @@
> ;;; Copyright 2017 ng0 <ng0@infotropique.org>
> ;;; Copyright 2014 Taylan Ulrich Bayrl/Kammer <taylanbayirli@gmail.org>
> ;;; Copyright 2017 Tobias Geerinckx-Rice <me@tobias.gr>
> +;;; Copyright 2017 Mark Meyer <mark@ofosos.org>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -29,6 +30,7 @@
> #:use-module (guix utils)
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system glib-or-gtk)
> + #:use-module (guix build-system python)
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (gnu packages)
> #:use-module (gnu packages assembly)
> @@ -41,11 +43,42 @@
> #:use-module (gnu packages lua)
> #:use-module (gnu packages ncurses)
> #:use-module (gnu packages pkg-config)
> + #:use-module (gnu packages python)
> + #:use-module (gnu packages python-web)
> #:use-module (gnu packages regex)
> #:use-module (gnu packages ruby)
> #:use-module (gnu packages terminals)
> #:use-module (gnu packages xml))
>
> +(define-public virtaal
> + (package
> + (name "virtaal")
> + (version "0.7.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/translate/Virtaal/"
> + version "/virtaal-" version ".tar.bz2"))
> + (sha256
> + (base32
> + "0cyimjp3191qlmw6n0ipqdr9xr0cq4f6dqvz4rl9q31h6l3kywf9"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:python ,python-2
> + #:use-setuptools? #f
> + #:tests? #f))

Could you check tests in virtaal-0.7.1/virtaal/test/ please?

Toggle quote (8 lines)
> + (propagated-inputs
> + `(("python2-pycurl" ,python2-pycurl)
> + ("python2-pygtk" ,python2-pygtk)
> + ("python2-lxml" ,python2-lxml)
> + ("python2-translate-toolkit" ,python2-translate-toolkit)
> + ("python2-simplejson" ,python2-simplejson)))
> + (synopsis "An editor for translation files")

gnu/packages/text-editors.scm:75:14: virtaal@0.7.1: no article allowed at the beginning of the synopsis

Toggle quote (10 lines)
> + (description
> + "Virtaal, a feature rich translation tool that allows you to focus on
> +translation, without the tool getting in the way.")
> + (home-page "http://virtaal.translatehouse.org/")
> + (license license:gpl2)))
> +
> (define-public vis
> (package
> (name "vis")

Could't be it builded With Python 3? I see in
use only python 2.7 and 2.7, but still?

Thanks,
Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlo1CEoACgkQckbhHGm3
lWnjbxAArfJQViRCK8iL4BFPDkTbCpWyBvD6id4LmliD/VkOiCl10YJsvAjvxveG
rZd1NKCKz9BlUlV5u3KAvqvoEOOoIgXNyOJQ/9v1BtzXfUwoP7yf45towvO7i/3u
QMnukh06jzSJkte9WUZn+TzO/KeQ9EbGPR7B1isX1/uCiRrTkzIFa0897peM1I7i
NZMRXW/EWwuVDjSHwvWCeJ4wI2nfKTA1GSgSWsTuEmXmtVqGFeeH6z5TRYHHEO9s
XBnOj5oeaNcWaHzZ+6NyhpAYR5qb41giZYAsUTSmApE91lyIwJiS4+WWgBvLRCQI
0EkAHU+ox+8Qv2reIEGTUFPey4K3qdztX07WqvzY2BMOY5X7ZuWSnqE63bsEsHl7
J2tbf0Tjl7Yiiwwj2bKedtuR4vfZoQU9kFncaWj50Sn8iiNIE2oqA3PWJj3O7x94
opMBDefNxq0CjLin+aWPu/gXDGzPKvb4gKwythdsnbik8lICR9Dk8PL013ebBrEx
JpAIFfu5dnRiaPgmY6AQ/h9LctHuSr//oD/oaG0m8gnR6MSJYYpCP+p+Qv/x5NqD
bNcLVq843ceYSJ5hGfUUfu8qy1UhMUXS39XRXvIS91Yhd7PPIH4+jiJieqkTeJ4L
JGtKoGqGUzh/BTaADbFcyOr1KxC5SlnjedAaPGPGiQ1siSn24u0=
=DJ7N
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 7 Mar 2018 14:59
(name . Oleg Pykhalov)(address . go.wigust@gmail.com)
87tvtsrnpv.fsf@gnu.org
Hello Mark & Oleg,

In an attempt to make progress (it’s been 3 months already :-)), I
pushed the first two patches, taking Oleg’s comments into account:

30e43e816 * gnu: python2-gobject@2: Update to 2.28.7
eaa8292e4 * gnu: Add python-pycurl.

Mark, can you take a look at Oleg’s suggestions below? We’re almost
there!

Thanks in advance,
Ludo’.

Oleg Pykhalov <go.wigust@gmail.com> skribis:

Toggle quote (86 lines)
>> From c36fde0cfda0d5f9830876abbff804504004451d Mon Sep 17 00:00:00 2001
>> From: Mark Meyer <mark@ofosos.org>
>> Date: Fri, 15 Dec 2017 12:35:38 +0100
>> Subject: [PATCH] gnu: Add virtaal.
>>
>> * gnu/packages/text-editors.scm (virtaal): New public variable.
>> ---
>> gnu/packages/text-editors.scm | 33 +++++++++++++++++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>>
>> diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
>> index 44b42ce9b..773000ff4 100644
>> --- a/gnu/packages/text-editors.scm
>> +++ b/gnu/packages/text-editors.scm
>> @@ -6,6 +6,7 @@
>> ;;; Copyright 2017 ng0 <ng0@infotropique.org>
>> ;;; Copyright 2014 Taylan Ulrich Bayrl/Kammer <taylanbayirli@gmail.org>
>> ;;; Copyright 2017 Tobias Geerinckx-Rice <me@tobias.gr>
>> +;;; Copyright 2017 Mark Meyer <mark@ofosos.org>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -29,6 +30,7 @@
>> #:use-module (guix utils)
>> #:use-module (guix build-system gnu)
>> #:use-module (guix build-system glib-or-gtk)
>> + #:use-module (guix build-system python)
>> #:use-module ((guix licenses) #:prefix license:)
>> #:use-module (gnu packages)
>> #:use-module (gnu packages assembly)
>> @@ -41,11 +43,42 @@
>> #:use-module (gnu packages lua)
>> #:use-module (gnu packages ncurses)
>> #:use-module (gnu packages pkg-config)
>> + #:use-module (gnu packages python)
>> + #:use-module (gnu packages python-web)
>> #:use-module (gnu packages regex)
>> #:use-module (gnu packages ruby)
>> #:use-module (gnu packages terminals)
>> #:use-module (gnu packages xml))
>>
>> +(define-public virtaal
>> + (package
>> + (name "virtaal")
>> + (version "0.7.1")
>> + (source (origin
>> + (method url-fetch)
>> + (uri (string-append "mirror://sourceforge/translate/Virtaal/"
>> + version "/virtaal-" version ".tar.bz2"))
>> + (sha256
>> + (base32
>> + "0cyimjp3191qlmw6n0ipqdr9xr0cq4f6dqvz4rl9q31h6l3kywf9"))))
>> + (build-system python-build-system)
>> + (arguments
>> + `(#:python ,python-2
>> + #:use-setuptools? #f
>> + #:tests? #f))
>
> Could you check tests in virtaal-0.7.1/virtaal/test/ please?
>
>> + (propagated-inputs
>> + `(("python2-pycurl" ,python2-pycurl)
>> + ("python2-pygtk" ,python2-pygtk)
>> + ("python2-lxml" ,python2-lxml)
>> + ("python2-translate-toolkit" ,python2-translate-toolkit)
>> + ("python2-simplejson" ,python2-simplejson)))
>> + (synopsis "An editor for translation files")
>
> gnu/packages/text-editors.scm:75:14: virtaal@0.7.1: no article allowed at the beginning of the synopsis
>
>> + (description
>> + "Virtaal, a feature rich translation tool that allows you to focus on
>> +translation, without the tool getting in the way.")
>> + (home-page "http://virtaal.translatehouse.org/")
>> + (license license:gpl2)))
>> +
>> (define-public vis
>> (package
>> (name "vis")
>
> Could't be it builded With Python 3? I see in
> <https://github.com/translate/virtaal/blob/master/.travis.yml> that they
> use only python 2.7 and 2.7, but still?
>
> Thanks,
> Oleg.
M
M
Mark Meyer wrote on 7 Mar 2018 20:58
(address . 29733@debbugs.gnu.org)
1520452704.1968021.1295172880.5FB477E6@webmail.messagingengine.com
Hi Ludo, Hi Oleg,
IIRC the test required a pycurl package, which in turn depends on nghttp. But nghttp has been merged, maybe we can finish this now. I'll have a look tomorrow.

Best, Mark

On Wed, Mar 7, 2018, at 14:59, Ludovic Courtès wrote:
Toggle quote (104 lines)
> Hello Mark & Oleg,
>
> In an attempt to make progress (it’s been 3 months already :-)), I
> pushed the first two patches, taking Oleg’s comments into account:
>
> 30e43e816 * gnu: python2-gobject@2: Update to 2.28.7
> eaa8292e4 * gnu: Add python-pycurl.
>
> Mark, can you take a look at Oleg’s suggestions below? We’re almost
> there!
>
> Thanks in advance,
> Ludo’.
>
> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
> >> From c36fde0cfda0d5f9830876abbff804504004451d Mon Sep 17 00:00:00 2001
> >> From: Mark Meyer <mark@ofosos.org>
> >> Date: Fri, 15 Dec 2017 12:35:38 +0100
> >> Subject: [PATCH] gnu: Add virtaal.
> >>
> >> * gnu/packages/text-editors.scm (virtaal): New public variable.
> >> ---
> >> gnu/packages/text-editors.scm | 33 +++++++++++++++++++++++++++++++++
> >> 1 file changed, 33 insertions(+)
> >>
> >> diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
> >> index 44b42ce9b..773000ff4 100644
> >> --- a/gnu/packages/text-editors.scm
> >> +++ b/gnu/packages/text-editors.scm
> >> @@ -6,6 +6,7 @@
> >> ;;; Copyright 2017 ng0 <ng0@infotropique.org>
> >> ;;; Copyright 2014 Taylan Ulrich Bayrl/Kammer <taylanbayirli@gmail.org>
> >> ;;; Copyright 2017 Tobias Geerinckx-Rice <me@tobias.gr>
> >> +;;; Copyright 2017 Mark Meyer <mark@ofosos.org>
> >> ;;;
> >> ;;; This file is part of GNU Guix.
> >> ;;;
> >> @@ -29,6 +30,7 @@
> >> #:use-module (guix utils)
> >> #:use-module (guix build-system gnu)
> >> #:use-module (guix build-system glib-or-gtk)
> >> + #:use-module (guix build-system python)
> >> #:use-module ((guix licenses) #:prefix license:)
> >> #:use-module (gnu packages)
> >> #:use-module (gnu packages assembly)
> >> @@ -41,11 +43,42 @@
> >> #:use-module (gnu packages lua)
> >> #:use-module (gnu packages ncurses)
> >> #:use-module (gnu packages pkg-config)
> >> + #:use-module (gnu packages python)
> >> + #:use-module (gnu packages python-web)
> >> #:use-module (gnu packages regex)
> >> #:use-module (gnu packages ruby)
> >> #:use-module (gnu packages terminals)
> >> #:use-module (gnu packages xml))
> >>
> >> +(define-public virtaal
> >> + (package
> >> + (name "virtaal")
> >> + (version "0.7.1")
> >> + (source (origin
> >> + (method url-fetch)
> >> + (uri (string-append "mirror://sourceforge/translate/Virtaal/"
> >> + version "/virtaal-" version ".tar.bz2"))
> >> + (sha256
> >> + (base32
> >> + "0cyimjp3191qlmw6n0ipqdr9xr0cq4f6dqvz4rl9q31h6l3kywf9"))))
> >> + (build-system python-build-system)
> >> + (arguments
> >> + `(#:python ,python-2
> >> + #:use-setuptools? #f
> >> + #:tests? #f))
> >
> > Could you check tests in virtaal-0.7.1/virtaal/test/ please?
> >
> >> + (propagated-inputs
> >> + `(("python2-pycurl" ,python2-pycurl)
> >> + ("python2-pygtk" ,python2-pygtk)
> >> + ("python2-lxml" ,python2-lxml)
> >> + ("python2-translate-toolkit" ,python2-translate-toolkit)
> >> + ("python2-simplejson" ,python2-simplejson)))
> >> + (synopsis "An editor for translation files")
> >
> > gnu/packages/text-editors.scm:75:14: virtaal@0.7.1: no article allowed at the beginning of the synopsis
> >
> >> + (description
> >> + "Virtaal, a feature rich translation tool that allows you to focus on
> >> +translation, without the tool getting in the way.")
> >> + (home-page "http://virtaal.translatehouse.org/")
> >> + (license license:gpl2)))
> >> +
> >> (define-public vis
> >> (package
> >> (name "vis")
> >
> > Could't be it builded With Python 3? I see in
> > <https://github.com/translate/virtaal/blob/master/.travis.yml> that they
> > use only python 2.7 and 2.7, but still?
> >
> > Thanks,
> > Oleg.


--
Mark Meyer
mark@ofosos.org
L
L
Ludovic Courtès wrote on 7 Mar 2018 22:00
(name . Mark Meyer)(address . mark@ofosos.org)
87d10fr47y.fsf@gnu.org
Heya Mark,

Mark Meyer <mark@ofosos.org> skribis:

Toggle quote (2 lines)
> IIRC the test required a pycurl package, which in turn depends on nghttp. But nghttp has been merged, maybe we can finish this now. I'll have a look tomorrow.

Awesome, let us know if anything goes wrong.

Thanks,
Ludo’.
M
M
Mark Meyer wrote on 10 Mar 2018 19:41
(name . Ludovic Courtès)(address . ludo@gnu.org)
1520707261.2584486.1298499248.0F517F2B@webmail.messagingengine.com
Moin Ludo,
apparently we still don't have HTTP2 in curl. guix-patches 29738 was opened for this. I think I will need to disable some test, will report back tomorrow.

Cheers, Mark

On Wed, Mar 7, 2018, at 22:00, Ludovic Courtès wrote:
Toggle quote (12 lines)
> Heya Mark,
>
> Mark Meyer <mark@ofosos.org> skribis:
>
> > IIRC the test required a pycurl package, which in turn depends on nghttp. But nghttp has been merged, maybe we can finish this now. I'll have a look tomorrow.
>
> Awesome, let us know if anything goes wrong.
>
> Thanks,
> Ludo’.


--
Mark Meyer
mark@ofosos.org
O
O
Oleg Pykhalov wrote on 14 Mar 2018 14:12
(name . Mark Meyer)(address . mark@ofosos.org)
87efkmvm0s.fsf@gmail.com
Hello Mark,

Mark Meyer <mark@ofosos.org> writes:

Toggle quote (4 lines)
> Apparently we still don't have HTTP2 in curl. guix-patches 29738 was
> opened for this. I think I will need to disable some test, will report
> back tomorrow.

It seems that cURL with HTTP2 is ready and waits to push to

Maybe ping Tobias in 29738 to push his patch?

Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlqpH8MACgkQckbhHGm3
lWkz/g/9EMZnx3fQMepDyJZOqrNHWGzysEl26z1O7VALtLXJl6BSajXN3cTiPfBa
vjavT15GrBjB88/e5Y11wkqxVc7lwICX7PxXnltP6eIhl3VfOTuk4oFKdPAycQ8/
lIrySjrORhWWeVgECf37Bl8vHQ1uAPZsyNvmdHlqy1XjiCbUk9jJ9wq+QbKAYsCb
BYs9kvpirIy2KS1rHjdim4Q7yypKL7Dleh40cGmt/TAHV2lWksfoqKRlPysfSTmv
PZ1XnoPYmmKAQysTt1gN0Y+xcGuxjV0eAq6DvO2gGwAWz4HAhGdwv40wXZiHy1fj
WW/s2trcBdsSpMJi3KvSou8fNhoJoJE/FefLZIA1z6h/SaWa164Ot8FnIEpdiUCq
HXM6MXmcWth2hQ4tbL5HkhYTUKyhrdrZhB7zceSmetdAfTkeBJWFTPLtDutoClmb
/eXkkK3ncMlHrq1qnQLrd7ar9NppcKQRBQ68Ago/ciq8Nsr3KnA5doG0bFdWTdg9
jUj+I3c4ubphVzU+VGPL7s19geeCuwJbjZ8IVVRjRgsuIACD/8r8lQzFoDfsvmp9
6EU1EXa/pfLPmG0Bg1KW4Ive0eqA0EySqWHdQJhuhXYi+9aWPzSLAeV4SxeR2OLd
qsu+zFhExJo8pO5HyvhQ7DmOs4a7ywdtCNbis4RUpfK7iM815vM=
=010+
-----END PGP SIGNATURE-----

C
C
Christopher Baines wrote on 19 Mar 2018 09:01
control message for bug #29733
(address . control@debbugs.gnu.org)
871sgg7aum.fsf@cbaines.net
tags 29733 patch
A
A
Arun Isaac wrote on 11 Dec 2020 07:04
Re: [bug#29733] Add virtaal (translation app)
(address . 29733-done@debbugs.gnu.org)
87360clvz0.fsf@systemreboot.net
Hi all,

I finished this patch and pushed to master as
e530fb41287f8d048643c74fb349bd602abbf3e5.

Cheers!
-----BEGIN PGP SIGNATURE-----

iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAl/TC+MbHGFydW5pc2Fh
Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuztdgH/1BV5FiWRWunzNyrzenN
VJMvA+Fma4Zx6RA4ucjPQuoMXjtSaxC4LpIdhNH55jZfHPFsx4iL9onZtyCcuYSG
y6HxQvOg95FokOR7PtzdI5876pYtgVnncIYOenvea0JJKrQqX4u1JBEa7nBs2q7A
god0QfQnwZbmMzGI+CjEy1C+m02er6wMs61yNlKmMyfSC5xkyI0JO7Q4R7y/yUHt
lyFake6qnFtC0YbJfDbo/a7bGeK0cZbCiFHU417Li26fWrxjDyi4rczTYuzy4SYl
OP0Nrt25UXGJ/lpsI4uRMFs4z9CNrfYUetWh0XYIuNHrBDc5GVCNOHMWKlnWLaAE
8A0=
=5J06
-----END PGP SIGNATURE-----

Closed
?