[PATCH] gnu: networkmanager-qt: Disable a failing test.

DoneSubmitted by Hartmut Goebel.
Details
3 participants
  • Hartmut Goebel
  • Leo Famulari
  • Ludovic Courtès
Owner
unassigned
Severity
normal
H
H
Hartmut Goebel wrote on 21 Mar 2017 20:59
(address . guix-patches@gnu.org)
1490126369-10238-1-git-send-email-h.goebel@crazy-compilers.com
The error-message was: "D-Bus library appears to be incorrectly set up;failed to read machine uuid: Failed to open '/etc/machine-id':No such file or directory".
* gnu/packages/kde-frameworks.scm (networkmanager-qt): [disable-failing-tests] New phase.--- gnu/packages/kde-frameworks.scm | 7 +++++++ 1 file changed, 7 insertions(+)
Toggle diff (20 lines)diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scmindex 5b11f12..01bbe29 100644--- a/gnu/packages/kde-frameworks.scm+++ b/gnu/packages/kde-frameworks.scm@@ -1113,6 +1113,13 @@ messages.") (arguments `(#:phases (modify-phases %standard-phases+ (add-after 'unpack 'disable-failing-tests+ (lambda* _+ ;; Disable test requiring a dbus machine-id:+ (substitute* "autotests/CMakeLists.txt"+ (("^ecm_add_test\\(activeconnectiontest\\.cpp .*")+ ""))+ #t)) (replace 'check (lambda _ (setenv "DBUS_FATAL_WARNINGS" "0")-- 2.7.4
H
H
Hartmut Goebel wrote on 21 Mar 2017 21:04
Re:
(address . 26211@debbugs.gnu.org)
f7d6af9d-fa2c-289c-c0df-ec0cfb0d5122@crazy-compilers.com
This fixes a build failure occuring since at least 2016-12-04.
This is the fixed version of the patch I sent (and retracted) yesterdayhttps://debbugs.gnu.org/cgi/bugreport.cgi?bug=26197

-- RegardsHartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com || www.crazy-compilers.com | compilers which you thought are impossible |
L
L
Leo Famulari wrote on 21 Mar 2017 21:24
Re: bug#26211: [PATCH] gnu: networkmanager-qt: Disable a failing test.
(name . Hartmut Goebel)(address . h.goebel@crazy-compilers.com)(address . 26211@debbugs.gnu.org)
20170321202453.GA26232@jasmine
On Tue, Mar 21, 2017 at 08:59:29PM +0100, Hartmut Goebel wrote:
Toggle quote (26 lines)> The error-message was: "D-Bus library appears to be incorrectly set up;> failed to read machine uuid: Failed to open '/etc/machine-id':> No such file or directory".> > * gnu/packages/kde-frameworks.scm (networkmanager-qt):> [disable-failing-tests] New phase.> ---> gnu/packages/kde-frameworks.scm | 7 +++++++> 1 file changed, 7 insertions(+)> > diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm> index 5b11f12..01bbe29 100644> --- a/gnu/packages/kde-frameworks.scm> +++ b/gnu/packages/kde-frameworks.scm> @@ -1113,6 +1113,13 @@ messages.")> (arguments> `(#:phases> (modify-phases %standard-phases> + (add-after 'unpack 'disable-failing-tests> + (lambda* _> + ;; Disable test requiring a dbus machine-id:> + (substitute* "autotests/CMakeLists.txt"> + (("^ecm_add_test\\(activeconnectiontest\\.cpp .*")> + ""))> + #t))
In (gnu packages gnome), there are some packages where we work aroundthis problem with (setenv "DBUS_FATAL_WARNINGS" "0").
If we used that instead, do you know if the test would still be able tocheck some things for us? Or does it just disable the test in anotherway?
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAljRjBUACgkQJkb6MLrKfwhIgA/7BlhuxRPozbllWmaJGYhgyL2kYCtG7Xfd25eBigMhCfOkbmO0FiTkerbpJ95A5v5XePgJ3EaIa+jY9YDh5Sng7UHjYtjRgKFI3cJgu43jCwSRJlvUqbPyuSwcpB8PLqJ88yFVcVoVG6HguOZnh81xTNpXxOFpXtC1/WsmNSXfaMckAH1C6FRa5KEdBhjxrt0BnspsAQUDkoK4msKssi0JI0RUw+x5moL9JDs0aDYuLIMqcBO45SVO/Ady1nHRgi6KZieuSGdodEYm/E3LF6koxFI/MQIr/s6rzNwYLti+NvIjBh0VU5td1yAzFFQaUjWvdKJSzEQ7rh0e2l9iz9GVQUJTKfQJpouZ/GnOSg0TyYaFwzI9UkYgm24YTBgBqPoVIT9+h8p/9WOsgVdek7eoARawIlC+ukHZbS/KhRAQzYBQ0mhOud9RxWA6EOBYrJZ43wHnxEd3g7ozcu1c76WEPzVJXP3ds/4BOtO9eyGjJZTxqGnOtlDUFKo0/VCanlGzWlBVd7Pio027XrktklMLvlV2CqHIcG1Wc//EpGXU9LZsQ06uT8Lu9D1VuENk6xcKV4MrU76kDkO1JdLiY3tnkKAIefLObwYvRNAJDf1orNTkB4eg9vIOwCOUbvOFa7FEstGJgEipb9E1/8zm3nL9Ebzex0QRspiaEwjFCRBnQsw==65Ah-----END PGP SIGNATURE-----

H
H
Hartmut Goebel wrote on 21 Mar 2017 23:12
(name . Leo Famulari)(address . leo@famulari.name)(address . 26211@debbugs.gnu.org)
d534c318-8345-ff0e-0cc0-7dd91ef6a94d@crazy-compilers.com
Am 21.03.2017 um 21:24 schrieb Leo Famulari:
Toggle quote (3 lines)> In (gnu packages gnome), there are some packages where we work around> this problem with (setenv "DBUS_FATAL_WARNINGS" "0").
Unfortunately this will not make the test pass.
TO fix the test, we would need to be able to create /etc&machine-id,which is not possible in the build-container AFAIK.
-- RegardsHartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com || www.crazy-compilers.com | compilers which you thought are impossible |
L
L
Ludovic Courtès wrote on 25 Mar 2017 15:17
(name . Hartmut Goebel)(address . h.goebel@crazy-compilers.com)(address . 26211@debbugs.gnu.org)
87lgrtwidy.fsf@gnu.org
Hi Hartmut,
Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:
Toggle quote (4 lines)> The error-message was: "D-Bus library appears to be incorrectly set up;> failed to read machine uuid: Failed to open '/etc/machine-id':> No such file or directory".
The output is:
Toggle snippet (24 lines)starting phase `check'process 2014: D-Bus library appears to be incorrectly set up; failed to read machine uuid: Failed to open "/etc/machine-id": No such file or directorySee the manual page for dbus-uuidgen to correct this issue.Test project /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build Start 1: managertest 1/25 Test #1: managertest ...................... Passed 0.01 sec Start 2: settingstest 2/25 Test #2: settingstest ..................... Passed 0.01 sec Start 3: activeconnectiontest 3/25 Test #3: activeconnectiontest .............***Failed 0.81 sec Start 4: 8021xsettingtest
[...]
96% tests passed, 1 tests failed out of 25
Total Test time (real) = 0.97 sec
The following tests FAILED: 3 - activeconnectiontest (Failed)Errors while running CTestphase `check' failed after 1.0 seconds
So the failure is the ‘activeconnectiontest’ test, not the D-Bus thing.Outside the chroot build environment (and outside of ‘guix environment-C’), this test passes.
When running “ctest --verbose”, we see:
Toggle snippet (20 lines)3: Test command: /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build/autotests/activeconnectiontest3: Test timeout computed to be: 9.99988e+063: ********* Start testing of ActiveConnectionTest *********3: Config: Using QtTest library 5.7.1, Qt 5.7.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.4)3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap&) Unhandled property "Devices"3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "Carrier"3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "HwAddress"3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "PermHwAddress"3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "Speed"3: PASS : ActiveConnectionTest::initTestCase()3: FAIL! : ActiveConnectionTest::testActiveConnection() Compared values are not the same3: Actual (activeConnectionStateChangedSpy.count()): 03: Expected (1) : 13: Loc: [/tmp/guix-build-networkmanager-qt-5.28.0.drv-0/networkmanager-qt-5.28.0/autotests/activeconnectiontest.cpp(118)]3: PASS : ActiveConnectionTest::cleanupTestCase()3: Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 805ms3: ********* Finished testing of ActiveConnectionTest ********* 3/25 Test #3: activeconnectiontest .............***Failed 0.81 sec
We can get more details as explained athttp://doc.qt.io/qt-5/qtest-overview.html by running:
dbus-launch /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build/autotests/activeconnectiontest -vs
That didn’t really help me though. The strace output shows nothingobvious either (such uses code looking for actual network interfaces via/proc/net/dev or using ioctls); it seems the code has complete mocks fornetwork interfaces and shouldn’t depend on the real network interfaces.
Could be maybe seek advice from upstream?
HTH,Ludo’.
L
L
Ludovic Courtès wrote on 2 Jun 2017 18:32
control message for bug #26211
(address . control@debbugs.gnu.org)
87r2z24agm.fsf@gnu.org
tags 26211 moreinfo
L
L
Ludovic Courtès wrote on 8 Sep 2017 17:46
Re: bug#26211: [PATCH] gnu: networkmanager-qt: Disable a failing test.
(name . Hartmut Goebel)(address . h.goebel@crazy-compilers.com)(address . 26211@debbugs.gnu.org)
87a8259os0.fsf@gnu.org
Hi Hartmut,
Any update on this?
Thanks,Ludo’.
ludo@gnu.org (Ludovic Courtès) skribis:
Toggle quote (73 lines)> Hi Hartmut,>> Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:>>> The error-message was: "D-Bus library appears to be incorrectly set up;>> failed to read machine uuid: Failed to open '/etc/machine-id':>> No such file or directory".>> The output is:>> starting phase `check'> process 2014: D-Bus library appears to be incorrectly set up; failed to read machine uuid: Failed to open "/etc/machine-id": No such file or directory> See the manual page for dbus-uuidgen to correct this issue.> Test project /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build> Start 1: managertest> 1/25 Test #1: managertest ...................... Passed 0.01 sec> Start 2: settingstest> 2/25 Test #2: settingstest ..................... Passed 0.01 sec> Start 3: activeconnectiontest> 3/25 Test #3: activeconnectiontest .............***Failed 0.81 sec> Start 4: 8021xsettingtest>> [...]>> 96% tests passed, 1 tests failed out of 25>> Total Test time (real) = 0.97 sec>> The following tests FAILED:> 3 - activeconnectiontest (Failed)> Errors while running CTest> phase `check' failed after 1.0 seconds>>> So the failure is the ‘activeconnectiontest’ test, not the D-Bus thing.> Outside the chroot build environment (and outside of ‘guix environment> -C’), this test passes.>> When running “ctest --verbose”, we see:>> 3: Test command: /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build/autotests/activeconnectiontest> 3: Test timeout computed to be: 9.99988e+06> 3: ********* Start testing of ActiveConnectionTest *********> 3: Config: Using QtTest library 5.7.1, Qt 5.7.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 4.9.4)> 3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: void NetworkManager::NetworkManagerPrivate::propertiesChanged(const QVariantMap&) Unhandled property "Devices"> 3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "Carrier"> 3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "HwAddress"> 3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "PermHwAddress"> 3: QWARN : ActiveConnectionTest::initTestCase() networkmanager-qt: virtual void NetworkManager::DevicePrivate::propertyChanged(const QString&, const QVariant&) Unhandled property "Speed"> 3: PASS : ActiveConnectionTest::initTestCase()> 3: FAIL! : ActiveConnectionTest::testActiveConnection() Compared values are not the same> 3: Actual (activeConnectionStateChangedSpy.count()): 0> 3: Expected (1) : 1> 3: Loc: [/tmp/guix-build-networkmanager-qt-5.28.0.drv-0/networkmanager-qt-5.28.0/autotests/activeconnectiontest.cpp(118)]> 3: PASS : ActiveConnectionTest::cleanupTestCase()> 3: Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 805ms> 3: ********* Finished testing of ActiveConnectionTest *********> 3/25 Test #3: activeconnectiontest .............***Failed 0.81 sec>> We can get more details as explained at> <http://doc.qt.io/qt-5/qtest-overview.html> by running:>> dbus-launch /tmp/guix-build-networkmanager-qt-5.28.0.drv-0/build/autotests/activeconnectiontest -vs>> That didn’t really help me though. The strace output shows nothing> obvious either (such uses code looking for actual network interfaces via> /proc/net/dev or using ioctls); it seems the code has complete mocks for> network interfaces and shouldn’t depend on the real network interfaces.>> Could be maybe seek advice from upstream?>> HTH,> Ludo’.
H
H
Hartmut Goebel wrote on 17 Sep 2017 13:18
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 26211-close@debbugs.gnu.org)
7debf929-5d76-d354-e7e8-10f0637d18b6@crazy-compilers.com
This patch is no longer required with the current version.
-- RegardsHartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com || www.crazy-compilers.com | compilers which you thought are impossible |
L
L
Ludovic Courtès wrote on 17 Sep 2017 15:22
control message for bug #26211
(address . control@debbugs.gnu.org)
87tw01ihoc.fsf@gnu.org
tags 26211 fixedclose 26211
?
Your comment

This issue is archived.

To comment on this conversation send email to 26211@debbugs.gnu.org